public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Eric Gallager <egall@gwmail.gwu.edu>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones
Date: Thu, 21 Jul 2016 17:10:00 -0000	[thread overview]
Message-ID: <5c5a9b7f-f8cb-ce72-489f-3fad441c494c@redhat.com> (raw)
In-Reply-To: <CAMfHzOvGnmyY5-wLnrTnUrttGoDAmwjxp33Po6T68yj04oPVvA@mail.gmail.com>

On 07/14/2016 01:57 PM, Eric Gallager wrote:

>
> So apparently the "-f" flag properly overwrites symlinks that point to
> regular files, but I also did this in my gcc builddir:
>
> $ mkdir isl-0.1.2.3
> $ ln -s isl-0.1.2.3 isl-s
> $ ln -sfv isl isl-s
> isl-s/isl -> isl
> $ ln -sfFv isl isl-s
> isl-s/isl -> isl
> $ ls -l isl-s
> lrwxr-xr-x  1 root  wheel  11 Jul 14 07:03 isl-s -> isl-0.1.2.3
> $ unlink isl-s
> $ ln -sfFv isl isl-s
> isl-s -> isl
> $ ls -l isl-s
> lrwxr-xr-x  1 root  wheel  3 Jul 14 15:51 isl-s -> isl
>
> ...it just doesn't overwrite symlinks that point to a directory.
Joys :(

AFAIK unlink may not necessarily be available on the various host 
systems GCC supports (solaris, aix, hpux, etc etc).

So rather than relying on ln to remove the link, why don't we just 
explicitly remove it with rm -f?

Jeff

  reply	other threads:[~2016-07-21 17:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28  2:38 Eric Gallager
2016-07-13 21:36 ` Jeff Law
2016-07-14 10:57   ` Eric Gallager
2016-07-14 13:54     ` NightStrike
2016-07-14 17:24     ` Jeff Law
2016-07-14 19:57       ` Eric Gallager
2016-07-21 17:10         ` Jeff Law [this message]
2016-07-21 19:39           ` Eric Gallager
2016-08-03 16:12             ` Jeff Law
2016-07-14 13:53   ` NightStrike
2016-07-21 18:15 Bernd Edlinger
2016-07-22 22:28 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c5a9b7f-f8cb-ce72-489f-3fad441c494c@redhat.com \
    --to=law@redhat.com \
    --cc=egall@gwmail.gwu.edu \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).