From: "Martin Liška" <mliska@suse.cz>
To: Jiufu Guo <guojiufu@linux.ibm.com>
Cc: Jiufu Guo via Gcc-patches <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>,
wschmidt@linux.ibm.com, segher@kernel.crashing.org,
Richard Biener <richard.guenther@gmail.com>,
"Bin.Cheng" <amker.cheng@gmail.com>
Subject: Re: [PATCH V2] PING^2 correct COUNT and PROB for unrolled loop
Date: Fri, 10 Jul 2020 09:37:06 +0200 [thread overview]
Message-ID: <5c8bedfd-0f8c-53de-9479-025b4c3d3a01@suse.cz> (raw)
In-Reply-To: <h48tuyg9kwf.fsf@genoa.aus.stglabs.ibm.com>
On 7/10/20 4:14 AM, Jiufu Guo wrote:
> Thanks so much for your time and kindly help!!!
And I run your patch on SPEC2006 with:
https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549728.html
Doing that I see just few changes:
diff -qr /tmp/before /tmp/after
Files /tmp/before/Meat.fppized.f90.000i.profile-report and /tmp/after/Meat.fppized.f90.000i.profile-report differ
Files /tmp/before/bezier.cpp.000i.profile-report and /tmp/after/bezier.cpp.000i.profile-report differ
Files /tmp/before/module_big_step_utilities_em.fppized.f90.000i.profile-report and /tmp/after/module_big_step_utilities_em.fppized.f90.000i.profile-report differ
Files /tmp/before/module_cu_bmj.fppized.f90.000i.profile-report and /tmp/after/module_cu_bmj.fppized.f90.000i.profile-report differ
Files /tmp/before/momx2.f.000i.profile-report and /tmp/after/momx2.f.000i.profile-report differ
Files /tmp/before/momx3.f.000i.profile-report and /tmp/after/momx3.f.000i.profile-report differ
Files /tmp/before/tml.f.000i.profile-report and /tmp/after/tml.f.000i.profile-report differ
Files /tmp/before/tranx2.f.000i.profile-report and /tmp/after/tranx2.f.000i.profile-report differ
Files /tmp/before/tranx3.f.000i.profile-report and /tmp/after/tranx3.f.000i.profile-report differ
But I see few regression, e.g.:
$ cat bezier.ii
int bezier_value_t, bezier_value_du_1;
int bezier_value_u[4], bezier_value_du[4];
void bezier_value() {
int i = 1;
for (; i < 4; i++) {
bezier_value_u[i] = 1;
bezier_value_du[i] = i * bezier_value_u[i - 1];
bezier_value_t = bezier_value_du_1;
}
}
$ g++ bezier.ii -c -march=native -O3 -Wno-multichar -Wno-aggressive-loop-optimizations -fdump-tree-pcom=/tmp/bad.txt
...
And your patch changed:
- <bb 15> [local count: 134217728]:
+ <bb 15> [local count: 89478486]:
where the function looks like:
<bb 3> [local count: 268435456]:
...
if (ivtmp_45 > 1)
goto <bb 15>; [50.00%]
else
goto <bb 10>; [50.00%]
<bb 15> [local count: 89478486]:
goto <bb 3>; [100.00%]
So 89478486 != 268435456 / 2. That seems a regression caused by your patch.
Can you please check it?
Martin
next prev parent reply other threads:[~2020-07-10 7:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 8:17 [PATCH] " Jiufu Guo
2020-02-03 16:04 ` Pat Haugen
2020-02-03 16:20 ` Jeff Law
2020-02-03 16:23 ` Jan Hubicka
2020-02-11 2:29 ` Jiufu Guo
2020-02-17 6:23 ` [PATCH V2] " Jiufu Guo
2020-02-28 7:56 ` Jiufu Guo
2020-03-19 2:21 ` Jiufu Guo
2020-05-19 6:15 ` Jiufu Guo
2020-06-03 5:22 ` [PATCH V2] PING^ " Jiufu Guo
2020-06-18 1:22 ` [PATCH V2] PING^2 " Jiufu Guo
2020-07-02 2:35 ` Jiufu Guo
2020-07-09 11:55 ` Martin Liška
2020-07-10 2:14 ` Jiufu Guo
2020-07-10 7:37 ` Martin Liška [this message]
2020-07-10 13:09 ` Jiufu Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8bedfd-0f8c-53de-9479-025b4c3d3a01@suse.cz \
--to=mliska@suse.cz \
--cc=amker.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guojiufu@linux.ibm.com \
--cc=hubicka@ucw.cz \
--cc=richard.guenther@gmail.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).