From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 78A463858D28 for ; Mon, 19 Jun 2023 05:41:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78A463858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35J5HuYQ008838; Mon, 19 Jun 2023 05:41:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Nh2DOdIZEyOCRRHTfMHNqeIIJHF9A12YSa29JeycGsU=; b=QH6ZIr7ccGBiZCrYOTvwO5Ci+MyCe8u4VWMA1R4O9JdVlUAxQ85XZIHXJlEtfxXpvdJH YuiflIuWnIE/6bsgSmPg6ktpgtn4BGk4j+GA+5h76NDPzokUKKyB+mZsdfQOyW2+oLSc 9KWYxufKPw2mztcLINB1JmwBYtegCbnwv1rf7DO+sjwlQif0BnxKzpP9TjZLy82rRPAd t0knVGYHe4ch1t+VOK11R62AAWg/2ZUbSh0BZvFYAqZMo6mVTTMX7n5Y8+LnWZLX3sSz 4AM7LKau0vFax9+5GgPM4jgW9QH1oty3NQJKiuGy6fYpoDa/lvcT+nQjgfkEqA24npGe Fw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ragr5rghe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Jun 2023 05:41:16 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35J5HwVP008953; Mon, 19 Jun 2023 05:41:16 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ragr5rggp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Jun 2023 05:41:16 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35J3vWjW018714; Mon, 19 Jun 2023 05:41:14 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3r943e15p8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Jun 2023 05:41:14 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35J5fCX263439262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Jun 2023 05:41:12 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 34E1120043; Mon, 19 Jun 2023 05:41:12 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 697FF20040; Mon, 19 Jun 2023 05:41:09 +0000 (GMT) Received: from [9.177.23.162] (unknown [9.177.23.162]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 19 Jun 2023 05:41:08 +0000 (GMT) Message-ID: <5cb9d9f0-81dc-4024-cdf4-6c315871ec3f@linux.ibm.com> Date: Mon, 19 Jun 2023 13:41:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH ver 2] rs6000, fix vec_replace_unaligned builtin arguments Content-Language: en-US To: Carl Love Cc: Peter Bergner , Segher Boessenkool , gcc-patches@gcc.gnu.org, David Edelsohn References: <004d44c3139e2af8c70ed57a4cb813a6b1cf3d67.camel@us.ibm.com> From: "Kewen.Lin" In-Reply-To: <004d44c3139e2af8c70ed57a4cb813a6b1cf3d67.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _04s6B16iqo9KXwM_gBhbYeEGmVWXzvC X-Proofpoint-GUID: xOgzRy0xNyoIOXtbc_FUONlHtn8KXVJY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-19_02,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306190050 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Carl, on 2023/6/16 00:00, Carl Love wrote: > GCC maintainers: > > Version 2, fixed various typos. Updated the change log body to say the > instruction counts were updated. The instruction counts changed as a > result of changing the first argument of the vec_replace_unaligned > builtin call from vector unsigned long long (vull) to vector unsigned > char (vuc). When the first argument was vull the builtin call > generated the vinsd instruction for the two test cases. The updated > call with vuc as the first argument generates two vinsw instructions > instead. Patch was retested on Power 10 with no regressions. > > The following patch fixes the first argument in the builtin definition > and the corresponding test cases. Initially, the builtin specification > was wrong due to a cut and past error. The documentation was fixed in: > > commit ed3fea09b18f67e757b5768b42cb6e816626f1db > Author: Bill Schmidt > Date: Fri Feb 4 13:07:17 2022 -0600 > > rs6000: Correct function prototypes for vec_replace_unaligned > > Due to a pasto error in the documentation, vec_replace_unaligned was > implemented with the same function prototypes as vec_replace_elt. It was > intended that vec_replace_unaligned always specify output vectors as having > type vector unsigned char, to emphasize that elements are potentially > misaligned by this built-in function. This patch corrects the > misimplementation. > .... > > This patch fixes the arguments in the definitions and updates the > testcases accordingly. Additionally, a few minor spacing issues are > fixed. > > The patch has been tested on Power 10 with no regressions. Please let > me know if the patch is acceptable for mainline. Thanks. > > Carl > > -------------------------------------------------- > rs6000, fix vec_replace_unaligned builtin arguments > > The first argument of the vec_replace_unaligned builtin should always be > unsigned char, as specified in gcc/doc/extend.texi. > > This patch fixes the builtin definitions and updates the testcases to use > the correct arguments. The expected instruction counts for the testcase > are updated. > > gcc/ChangeLog: > * config/rs6000/rs6000-overload.def (__builtin_vec_replace_un): > Fix first argument type. > > gcc/testsuite/ChangeLog: > * gcc.target/powerpc/ver-replace-word-runnable.c Wrong case name, s/ver/vec/ Sorry that I didn't catch this during the previous review. How do you generate changelog? I guess you don't manually type this but use something like gcc-{commit}-mklog? that should get this name right, it's not perfect though. :) Excepting for the vinsd/vinsw expected insn counts thing, that was replied in another thread, the others look good to me. BR, Kewen