From: Michael Eager <eager@eagerm.com>
To: Andrew Sadek <andrew.sadek.se@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] [Microblaze]: PIC Data Text Relative
Date: Tue, 20 Mar 2018 01:30:00 -0000 [thread overview]
Message-ID: <5cd4774f-13a2-5310-a27c-8298409be8d4@eagerm.com> (raw)
In-Reply-To: <bbc87995-edc7-ea58-24f0-a2d293dd3422@eagerm.com>
Hi Andrew --
Please take a look at the test case description:
https://gcc.gnu.org/wiki/HowToPrepareATestcase
and see if you can do one of the following:
- Modify the regex expression in the scan-assembler to accept
either format of generated output
or
- Add { dg-option } directives to turn off your new options
if specified. (You should be able to specify -mno-pic....)
or
- Duplicate the test cases and add { dg-option } directives
to specify the correct options, with and without your
new options.
or
- Add test cases with a { dg-option } directive with your
new options.
This is not required -- your patch appears to work OK. Normally,
the new PIC Data options would not be used when running the test
suite, so the tests would not fail. It's just nice to have the
test suite updated when new options are added.
On 03/19/2018 01:07 PM, Michael Eager wrote:
> Hi Andrew --
>
> Good work.
>
> Please submit your updated patch. Check that you follow
> GNU coding standards. Also make sure that the new options
> are documented in gcc/doc/invoke.texi.
>
> On 03/18/18 03:27, Andrew Sadek wrote:
>> Hello Michael,
>>
>> I have run the test using the new PIC options.
>> Actually, I have discovered 2 unhandled cases in
>> 'microblaze_expand_move' + missing conditions in linker relax
>> leading some test cases execution to fail.
>> After fixing them, I made a re-run for the whole regression, and the
>> results analogy below:
>>
>> Original, without my patch:
>> === gcc Summary ===
>>
>> # of expected passes 90776
>> # of unexpected failures 1317
>> # of unexpected successes 3
>> # of expected failures 207
>> # of unresolved testcases 115
>> # of unsupported tests 2828
>>
>> With my patch, calling '-fPIE - mpic-data-text-rel'
>> === gcc Summary ===
>>
>> # of expected passes 90843
>> # of unexpected failures 1256
>> # of unexpected successes 3
>> # of expected failures 207
>> # of unresolved testcases 115
>> # of unsupported tests 2853
>>
>> After running the 'dg-cmp-results.sh' in contrib folder, the
>> PASS->FAIL are below:
>>
>> PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2
>> -flto -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2
>> -flto -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2
>> -flto -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2
>> -flto -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>>
>> the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the others
>> in microblaze,
>> expectation is r0 or r13 as a base register which is not the case here
>> 'r20', and these tests also fails with -fPIE.
>> Moreover, the test cases that failed due 'unresolved
>> GLOBAL_OFFSET_TABLE' now pass as we do not have GOT in data text
>> relative.
>>
>> Please tell me if any adjustments needed or If I need to re-run nything.
>>
>> Thanks
>>
>> On Sun, Mar 18, 2018 at 12:25 PM, Andrew Sadek
>> <andrew.sadek.se@gmail.com <mailto:andrew.sadek.se@gmail.com>> wrote:
>>
>> Hello Michael,
>>
>> I have run the test using the new PIC options.
>> Actually, I have discovered 2 unhandled cases in
>> 'microblaze_expand_move' + missing conditions in linker relax
>> leading some test cases execution to fail.
>> After fixing them, I made a re-run for the whole regression, and the
>> results analogy below:
>>
>> Original, without my patch:
>> === gcc Summary ===
>>
>> # of expected passes 90776
>> # of unexpected failures 1317
>> # of unexpected successes 3
>> # of expected failures 207
>> # of unresolved testcases 115
>> # of unsupported tests 2828
>>
>> With my patch, calling '-fPIE - mpic-data-text-rel'
>> === gcc Summary ===
>>
>> # of expected passes 90843
>> # of unexpected failures 1256
>> # of unexpected successes 3
>> # of expected failures 207
>> # of unresolved testcases 115
>> # of unsupported tests 2853
>>
>> After running the 'dg-cmp-results.sh' in contrib folder, the
>> PASS->FAIL are below:
>>
>> PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var1.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/data_var2.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2 -flto
>> -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2 -flto
>> -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O3 -g
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2
>> -flto -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2
>> -flto -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O3
>> -g scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O0
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O1
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2
>> -flto -fno-use-linker-plugin -flto-partition=none scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2
>> -flto -fuse-linker-plugin -fno-fat-lto-objects scan-assembler
>> lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O3
>> -g scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>> PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -Os
>> scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
>>
>> the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the
>> others in microblaze,
>> expectation is r0 or r13 as a base register which is not the case
>> here 'r20', and these tests also fails with -fPIE.
>> Moreover, the test cases that failed due 'unresolved
>> GLOBAL_OFFSET_TABLE' now pass as we do not have GOT in data text
>> relative.
>>
>> Attached the compare output of the scripit with verbosity 2.
>> Please tell me if any adjustments needed or If I need to re-run
>> nything.
>>
>> Thanks
>>
>>
>> On Tue, Mar 13, 2018 at 10:44 PM, Michael Eager <eager@eagerm.com
>> <mailto:eager@eagerm.com>> wrote:
>>
>> On 03/13/18 00:56, Andrew Sadek wrote:
>>
>> Ok, so you mean with '-fPIC -mpic-data-text-relative' as I
>> do in my test case ?
>> If all is Ok, execution and compilation shall ideally pass
>> for the test cases.
>>
>>
>> Correct.
>>
>> I want to make sure of two things:
>> -- Your patch doesn't break anything (i.e., cause a
>> regression) when
>> you don't use the options. This seems complete.
>> -- Your patch works as intended when you do use the options.
>>
>> But I have noticed that there are some output pattern checks
>> done in some test cases and this may fail since the output
>> assembly is different,
>> anyway I shall give it a try and send you the results with
>> the new options.
>>
>>
>> There should be no target dependencies in the generic GCC tests.
>> Different instruction patterns which generate the correct
>> results should
>> not be a problem.
>>
>>
>> -- Michael Eager eager@eagerm.com
>> <mailto:eager@eagerm.com>
>> 1960 Park Blvd., Palo Alto, CA 94306
>>
>>
>>
>>
>> --
>> Andrew
>>
>>
>>
>>
>> --
>>
>> Andrew
>
--
Michael Eager eager@eagerm.com
1960 Park Blvd., Palo Alto, CA 94306
next prev parent reply other threads:[~2018-03-20 1:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAE=jbAMyXXpWUPnC_dcmyWNeOXcJ-Wo4+KomQ9KwpX2KuLDqkg@mail.gmail.com>
2018-02-27 0:07 ` Michael Eager
2018-02-27 8:14 ` Andrew Sadek
2018-03-02 16:12 ` Andrew Sadek
2018-03-05 19:21 ` Michael Eager
2018-03-12 13:19 ` Andrew Sadek
2018-03-12 14:30 ` Michael Eager
2018-03-13 6:10 ` Andrew Sadek
2018-03-13 6:42 ` Michael Eager
2018-03-13 7:56 ` Andrew Sadek
2018-03-13 20:51 ` Michael Eager
[not found] ` <CAE=jbAMCJ_8HR=ztOrY_FLfhYEMAFivyMO=Tz8EBdagd9zgs5g@mail.gmail.com>
2018-03-18 14:56 ` Andrew Sadek
2018-03-19 20:09 ` Michael Eager
2018-03-20 1:30 ` Michael Eager [this message]
2018-03-20 2:06 ` Michael Eager
2018-03-20 14:18 ` Andrew Sadek
2018-03-20 15:49 ` Michael Eager
2018-03-22 18:45 ` Andrew Sadek
2018-04-18 12:44 ` Andrew Sadek
2018-04-18 16:57 ` Michael Eager
2018-04-19 10:43 ` Andrew Sadek
2018-04-27 1:41 ` Michael Eager
2018-04-27 10:41 ` Andrew Sadek
[not found] ` <1285bbac-fa9c-34f5-c43d-82c0c17d89c9@eagerm.com>
2018-05-03 17:13 ` Andrew Sadek
2018-05-05 11:17 ` Andrew Sadek
[not found] ` <CAE=jbAMZJTQsEygLtPpXaSi=YGkOFje92CpEc6KhuuZk5HWCLA@mail.gmail.com>
2018-05-06 11:46 ` Michael Eager
2018-02-26 7:56 Andrew Guirguis
2018-02-26 8:36 ` Andrew Sadek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd4774f-13a2-5310-a27c-8298409be8d4@eagerm.com \
--to=eager@eagerm.com \
--cc=andrew.sadek.se@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).