From: David Malcolm <dmalcolm@redhat.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [pushed 2/2] testsuite: check that generated .sarif files validate against the SARIF schema [PR109360]
Date: Mon, 24 Jun 2024 18:27:09 -0400 [thread overview]
Message-ID: <5ced30f68e42da0bf2f975a17ba3ca32c92654d5.camel@redhat.com> (raw)
In-Reply-To: <ZnaKrS4KsWc_iaa-@kendros.lan>
On Sat, 2024-06-22 at 11:26 +0300, Dimitar Dimitrov wrote:
> On Fri, Jun 21, 2024 at 08:55:36AM -0400, David Malcolm wrote:
> > This patch extends the dg directive verify-sarif-file so that if
> > the "jsonschema" tool is available, it will be used to validate the
> > generated .sarif file.
> >
> > Tested with jsonschema 3.2 with Python 3.8
>
> Hi David,
>
> The new testcase fails on my Fedora 40 with jsonschema 4.19.1 and
> Python
> 3.12.3:
>
> ```
> Executing on host: jsonschema --version (timeout = 300)
> spawn -ignore SIGHUP jsonschema --version
> /usr/bin/jsonschema:5: DeprecationWarning: The jsonschema CLI is
> deprecated and will be removed in a future version. Please use check-
> jsonschema instead, which can be installed from
> https://pypi.org/project/check-jsonschema/
> from jsonschema.cli import main
> 4.19.1
> FAIL: c-c++-common/analyzer/malloc-sarif-1.c (test .sarif output
> against SARIF schema)
> ```
Sorry about that.
>
> The deprecation warning output seems to confuse DejaGnu and it fails
> the test.
Thanks for the heads-up; I'll upgrade my machine to a less ancient
version and update the patch accordingly.
Dave
next prev parent reply other threads:[~2024-06-24 22:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 12:55 [pushed 1/2] diagnostics: fixes to SARIF output [PR109360] David Malcolm
2024-06-21 12:55 ` [pushed 2/2] testsuite: check that generated .sarif files validate against the SARIF schema [PR109360] David Malcolm
2024-06-22 8:26 ` Dimitar Dimitrov
2024-06-24 22:27 ` David Malcolm [this message]
2024-06-26 0:31 ` [pushed] testsuite: use check-jsonschema for validating .sarif files [PR109360] David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ced30f68e42da0bf2f975a17ba3ca32c92654d5.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=dimitar@dinux.eu \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).