public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>, gcc-patches@gcc.gnu.org
Cc: Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v3] add support for --disable-gcov
Date: Tue, 12 Jun 2018 21:18:00 -0000	[thread overview]
Message-ID: <5d11f24b-6598-e160-5864-bacc8d8310bd@redhat.com> (raw)
In-Reply-To: <20180611072553.26334-1-rasmus.villemoes@prevas.dk>

On 06/11/2018 01:25 AM, Rasmus Villemoes wrote:
> For some targets (in my case VxWorks 5.5), libgcov does not compile due
> to missing functions and macros such as getpid() and F_OK.
> 
> Incidentally, gcc/Makefile.in already contains comments such as
> 
> # Install gcov if it was compiled.
> 
> but there is no logic in place to actually allow gcov to not be
> compiled.
I think in the past folks would do things like

make LANGUAGES="c c++"

Which would skip building gcov.



> 
> So add an option for disabling build and install of libgcov and the
> related host tools.
> 
> 2018-06-10  Rasmus Villemoes  <rasmus.villemoes@prevas.dk>
> 
> gcc/
> 	* configure.ac: Add --disable-gcov option.
> 	* configure: Regenerate.
> 	* Makefile.in: Honour @enable_gcov@.
> 	* doc/install.texi: Document --disable-gcov.
> 
> libgcc/
> 	* configure.ac: Add --disable-gcov option.
> 	* configure: Regenerate.
> 	* Makefile.in: Honour @enable_gcov@.
OK.  Presumably you're going through the process to get write access.
Once that's wrapped up you can install this patch.

Thanks,
jeff

  reply	other threads:[~2018-06-12 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 13:06 [PATCH] libgcc: Add support for --disable-libgcov Rasmus Villemoes
2018-05-25 16:40 ` Joseph Myers
2018-05-25 21:35   ` [PATCH v2] " Rasmus Villemoes
2018-06-01 12:11     ` Rasmus Villemoes
2018-06-11  7:26       ` [PATCH v3] add support for --disable-gcov Rasmus Villemoes
2018-06-12 21:18         ` Jeff Law [this message]
2018-06-27 19:23           ` Rainer Orth
2018-06-27 21:01             ` Rasmus Villemoes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d11f24b-6598-e160-5864-bacc8d8310bd@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=rasmus.villemoes@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).