From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43382 invoked by alias); 12 Jun 2018 21:18:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43369 invoked by uid 89); 12 Jun 2018 21:18:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=configureac, UD:configure.ac, configure.ac, UD:ac X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Jun 2018 21:18:18 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C77BE3082A34; Tue, 12 Jun 2018 21:18:17 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-48.rdu2.redhat.com [10.10.112.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF3E710021B2; Tue, 12 Jun 2018 21:18:16 +0000 (UTC) Subject: Re: [PATCH v3] add support for --disable-gcov To: Rasmus Villemoes , gcc-patches@gcc.gnu.org Cc: Joseph Myers References: <99e19880-9cd6-8895-5e26-21825a8f6021@prevas.dk> <20180611072553.26334-1-rasmus.villemoes@prevas.dk> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <5d11f24b-6598-e160-5864-bacc8d8310bd@redhat.com> Date: Tue, 12 Jun 2018 21:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180611072553.26334-1-rasmus.villemoes@prevas.dk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00716.txt.bz2 On 06/11/2018 01:25 AM, Rasmus Villemoes wrote: > For some targets (in my case VxWorks 5.5), libgcov does not compile due > to missing functions and macros such as getpid() and F_OK. > > Incidentally, gcc/Makefile.in already contains comments such as > > # Install gcov if it was compiled. > > but there is no logic in place to actually allow gcov to not be > compiled. I think in the past folks would do things like make LANGUAGES="c c++" Which would skip building gcov. > > So add an option for disabling build and install of libgcov and the > related host tools. > > 2018-06-10 Rasmus Villemoes > > gcc/ > * configure.ac: Add --disable-gcov option. > * configure: Regenerate. > * Makefile.in: Honour @enable_gcov@. > * doc/install.texi: Document --disable-gcov. > > libgcc/ > * configure.ac: Add --disable-gcov option. > * configure: Regenerate. > * Makefile.in: Honour @enable_gcov@. OK. Presumably you're going through the process to get write access. Once that's wrapped up you can install this patch. Thanks, jeff