From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id B644B3858D32 for ; Mon, 9 Oct 2023 15:01:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B644B3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-CSE-ConnectionGUID: Y9RlSqfrRqi5cvgrsZwsiQ== X-CSE-MsgGUID: 8Dy8zxpJQ5OP9wvjgM0QMg== X-IronPort-AV: E=Sophos;i="6.03,210,1694764800"; d="scan'208";a="21201820" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 09 Oct 2023 07:01:33 -0800 IronPort-SDR: kEwjoP55xCofGkzQ1f0Z91lt+8ElcRR7R5y2MHCkZn+kED+Mbko5TW464cXlzOM6A7YaahC6ew v5WdtDS0pPM5+B224NnQjTEs8h14Jm5z4PaNVwCgAjjv5XFI38hpagd45kyTTXvA50A6zeXYXF NuSSklJpJmJEjZ3KV3PIldhyegpZWVkxjMWd+S3z6hoq8zXKJ1a8mmVfzPCWKHtlDSTw8+wP8z +DrBUmiRiaGb3iL6SeEXFK1D7gvlWshDCZM0aw9jlPuPtu+sJi3c6ZZ7eCb4RllGn/TrJ8KtgS XqQ= Message-ID: <5d648bd7-cbd9-46f1-b37f-df752b0ede2e@codesourcery.com> Date: Mon, 9 Oct 2023 17:01:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pushed] analyzer: improvements to out-of-bounds diagrams [PR111155] Content-Language: en-US To: David Malcolm , Tobias Burnus , References: <20231008225854.783706-1-dmalcolm@redhat.com> <3591f8c9-3cc9-4e95-be04-1e99003f3bad@codesourcery.com> <7ed5fea1f533e1a8311e65cdf0586a24377e1ab3.camel@redhat.com> From: Tobias Burnus In-Reply-To: <7ed5fea1f533e1a8311e65cdf0586a24377e1ab3.camel@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi David, On 09.10.23 16:08, David Malcolm wrote: > On Mon, 2023-10-09 at 12:09 +0200, Tobias Burnus wrote: >> The following works: >> (A) Using "kind =3D=3D boundaries::kind::HARD" - i.e. adding >> "boundaries::" >> (B) Renaming the parameter name "kind" to something else - like "k" >> as used >> in the other functions. >> >> Can you fix it? > Sorry about the breakage, and thanks for the investigation. Well, without an older compiler, one does not see it. It also worked flawlessly on my laptop today. > Does the following patch fix the build for you? Yes =E2=80=93 as mentioned either of the variants above should work and (A)= is what you have in your patch. And it is what I actually tried for the full build. Hence, yes, it works :-= ) Thanks for the quick action! Tobias > gcc/analyzer/ChangeLog: > * access-diagram.cc (boundaries::add): Explicitly state > "boundaries::" scope for "kind" enum. > --- > gcc/analyzer/access-diagram.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/analyzer/access-diagram.cc b/gcc/analyzer/access-diagram= .cc > index 2197ec63f53..c7d190e3188 100644 > --- a/gcc/analyzer/access-diagram.cc > +++ b/gcc/analyzer/access-diagram.cc > @@ -652,7 +652,8 @@ public: > m_logger->log_partial ("added access_range: "); > range.dump_to_pp (m_logger->get_printer (), true); > m_logger->log_partial (" (%s)", > - (kind =3D=3D kind::HARD) ? "HARD" : "soft"); > + (kind =3D=3D boundaries::kind::HARD) > + ? "HARD" : "soft"); > m_logger->end_log_line (); > } > } ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955