From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id EF5593858401 for ; Thu, 1 Sep 2022 08:58:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF5593858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2818EMRa034423; Thu, 1 Sep 2022 08:58:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=yXyYicvOr6vxaaP65m0izbfKcYpi9L6sNFqXbxCvHss=; b=GYYm1nNjd3dUC5zUY85KQxAzHHugOX/wcyuePuEiGXuJMAii0BqrKESU4o3WFThrb12b c/kka/RWVtgvIEkt36p7HA/HY4tNzzGppjEBX/52pTNvd/dW8r5rCICJJDsa9c3jQ0Kd bIJhl27evjXeiXcwT/D3NiYONg5kJDRHu8OIdXuunh9VreYzkk4Pep7MarQ29RvHhWVx SMcXGaAiA7W+WI/FNQaxqWK36za6SM7/XhLGQA8NRLW8JWpgSJ53eJNkPWwDebldOtON ymhEyuAFMwgHTIytxCUJfvwbmBsPNUsil4TgCsNN8lh6i9zhP8RE1xlv/3ayMDMZDSKC Sw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jas1x99y7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Sep 2022 08:58:08 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2818G59O039405; Thu, 1 Sep 2022 08:58:07 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jas1x99x5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Sep 2022 08:58:07 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2818qMo3010183; Thu, 1 Sep 2022 08:58:05 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma01fra.de.ibm.com with ESMTP id 3j8hkabjc8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Sep 2022 08:58:05 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2818sjhG37749050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Sep 2022 08:54:45 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E3684AE051; Thu, 1 Sep 2022 08:58:02 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE61EAE04D; Thu, 1 Sep 2022 08:58:00 +0000 (GMT) Received: from [9.200.42.102] (unknown [9.200.42.102]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 1 Sep 2022 08:58:00 +0000 (GMT) Message-ID: <5d7a002c-829a-da5a-f630-3533084aef0e@linux.ibm.com> Date: Thu, 1 Sep 2022 16:57:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000/test: Fix bswap64-4.c with has_arch_ppc64 [PR106680] Content-Language: en-US To: Peter Bergner Cc: Segher Boessenkool , David Edelsohn , GCC Patches References: <69277846-f587-b79e-f741-a2942d326778@linux.ibm.com> <4e527a22-2dd6-9fa3-b255-4f71b90b77f7@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <4e527a22-2dd6-9fa3-b255-4f71b90b77f7@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: RfmCIQ8kVS6GcT1AY_XNpwnqptgX4hkY X-Proofpoint-ORIG-GUID: WAuim96Qa6s3XpsG6O9N6l8QLCrtmNcD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-01_06,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 mlxlogscore=776 clxscore=1015 lowpriorityscore=0 bulkscore=0 impostorscore=0 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209010038 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2022/8/31 22:13, Peter Bergner wrote: > On 8/31/22 4:33 AM, Kewen.Lin wrote: >> @@ -1,7 +1,8 @@ >> /* { dg-do compile { target { powerpc*-*-* } } } */ >> /* { dg-skip-if "" { powerpc*-*-aix* } } */ >> -/* { dg-options "-O2 -mpowerpc64" } */ >> /* { dg-require-effective-target ilp32 } */ >> +/* { dg-options "-O2 -mpowerpc64" } */ >> +/* { dg-require-effective-target has_arch_ppc64 } */ > > With many of our recent patches moving the dg-options before any > dg-requires-effectice-target so it affects the results of the > dg-requires-effectice-target test, this looks like it's backwards > from that process. I understand why, so I think an explicit comment > here in the test case explaining why it's after in this case. > Just so in a few years when we come back to this test case, we > won't accidentally undo this change. Oops, the diff shows it's like "after", but it's actually still "before". :) The dg-options is meant to be placed before the succeeding has_arch_ppc64 effective target which is supposed to use dg-options to compile. I felt good to let ilp32 checking go first then has_arch_ppc64, so moved dg-option downward. Sorry for the confusion, I should have placed the has_arch_ppc64 effective target just after the dg-options. Anyway, it's a good idea to add more comments in test case source! Thanks! BR, Kewen