From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id CAE683857C51 for ; Fri, 18 Nov 2022 20:14:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CAE683857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x434.google.com with SMTP id k22so5911559pfd.3 for ; Fri, 18 Nov 2022 12:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9nCdwniDOlbdugeyYm00kHFbUvmuRWG/MCgwgpBYYc4=; b=D7HR92GV2PQSydA8TdglHJiGNa4LNVRtO9c5pMB9U2Rh7b/2XFmtJQsAKiLIy4qwgT SR9zDk0zp+2B5cKhrwL+WLOgqk+iIOVl25uuU06zUCl5VS2GEkwfrHrkWTSMyMPg35+f zptdV81VcwCRXKgtRY3o8J3KB2WBYxW3f/hUbvwWyRStZQGF+jE9/km6YjPmeppW9KtM 9hjYZLzwkaN0lJrGJQnD8Hfl6h83OCHo7hC+1KO6fSfCT6K1oXJfInbJrsykh/yuVUWU flKlsCM4yX05+dsc8ZOXDEKvfucpAQzpwMtXE4KIRHRfmrMWRP9Rr0aYEORz8BNBk/zu Zbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9nCdwniDOlbdugeyYm00kHFbUvmuRWG/MCgwgpBYYc4=; b=srxqf+cCXvDD8lhGu+g89OgwK2ekavri4mtVgE0HpwmQkjQpineaJm1/QRMYhAA6Tq u5+SX2ZAjgzlzaVre9E2yOqxYgceAoZobPkpU8E+g9gqZEhU2L9pgFQpA8P4QWX6O5oW mS5fOe4H8ey/Q8+9SEg9uPFGE82b3rBcUgd3oX4/hR7PoQfatH5Gys0juBGw5loC57G/ 7tlDuQ/nzaFOSkBitp2JJNRxub5a7NS5BRJOmBbDFjmKQBtkhy+IqhFZKkXJP7S8CoPD pfR41cAsC01ZFPS3mplfbS9xws9JpfHoDyR0OQskuzMwoE1IY/csn1zEgJp+KcZv5Mde q2Yw== X-Gm-Message-State: ANoB5pmSsi4ChGfL8QVm+1QPZTU7mNkmcFybkVNiaRSYwNud7jTYfUni ilgL2HTHJVW2nQ8ruLm7PMPR25bq8c8= X-Google-Smtp-Source: AA0mqf64jAqZPe04r3saRvb2huJ7aCbA5H0C4feN5B7bOvFSLlf7KxjrrH3DZ/EMQZJmqbbNWMb6ow== X-Received: by 2002:aa7:8d01:0:b0:562:83c1:59e0 with SMTP id j1-20020aa78d01000000b0056283c159e0mr9442159pfe.34.1668802496777; Fri, 18 Nov 2022 12:14:56 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id e5-20020a056a0000c500b0053e468a78a8sm3536332pfj.158.2022.11.18.12.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 12:14:55 -0800 (PST) Message-ID: <5d9f6221-a088-35b7-8e3b-5fc1a86b5f07@gmail.com> Date: Fri, 18 Nov 2022 13:14:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] libcpp: Avoid remapping filenames within directives Content-Language: en-US To: Richard Purdie , gcc-patches@gcc.gnu.org References: <20221102104713.643862-1-richard.purdie@linuxfoundation.org> From: Jeff Law In-Reply-To: <20221102104713.643862-1-richard.purdie@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/2/22 04:47, Richard Purdie via Gcc-patches wrote: > Code such as: > > #include __FILE__ > > can interact poorly with the *-prefix-map options when cross compiling. In > general you're after to remap filenames for use in target context but the > local paths should be used to find include files at compile time. Ingoring > filename remapping for directives allows avoiding such failures. > > Fix this to improve such usage and then document this against file-prefix-map > (referenced by the other *-prefix-map options) to make the behaviour clear > and defined. > > libcpp/ChangeLog: > > * macro.cc (_cpp_builtin_macro_text): Don't remap filenames within directives > > gcc/ChangeLog: > > * doc/invoke.texi: Document prefix-maps don't affect directives THanks.  Installed.  Sorry about the wait. jeff