From: Jeff Law <law@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] Handle targets with 2 byte wchar_t better in strlenopt-58.c
Date: Wed, 05 Dec 2018 19:13:00 -0000 [thread overview]
Message-ID: <5db5ac9f-ef2f-a1be-e4a0-f55e8e9d60d6@redhat.com> (raw)
In-Reply-To: <CAGWvnykVXRmtpw6vDVeSv_VVnoTFVvCRgQGA29Lto2h2mqAUGw@mail.gmail.com>
On 12/5/18 11:59 AM, David Edelsohn wrote:
> Jeff,
>
> Thanks for the patch.
>
> I continue to see a failure on AIX 32 bit mode (2 byte wchar).
>
> FAIL: gcc.dg/strlenopt-58.c scan-tree-dump-times optimized
> "call_in_true_branch_not_eliminated" 0
>
> I'm not certain if this is AIX-specific or more fallout from wchar
> size. I could ignore with target powerpc-ibm-aix* or with target !
> 4byte_wchar_t.
>
> Any further insight / preference?
I didn't try to address that specific failure yet -- my patch just fixed
two earlier warnings.
That specific failure either requires a deeper testsuite fix for
possibly even a fix to the compiler -- I haven't really analyzed it yet
(it's a failure to optimize issue and I've generally avoided looking at
those).
You could xfail it on 4byte_wchar_t.
jeff
next prev parent reply other threads:[~2018-12-05 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 18:59 David Edelsohn
2018-12-05 19:13 ` Jeff Law [this message]
2018-12-05 20:18 ` Martin Sebor
-- strict thread matches above, loose matches on Subject: below --
2018-12-04 23:23 Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5db5ac9f-ef2f-a1be-e4a0-f55e8e9d60d6@redhat.com \
--to=law@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).