From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91017 invoked by alias); 5 Dec 2018 19:13:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 90988 invoked by uid 89); 5 Dec 2018 19:13:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=avoided, H*f:sk:CAGWvny X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Dec 2018 19:13:37 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42B0D307D943; Wed, 5 Dec 2018 19:13:36 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-68.rdu2.redhat.com [10.10.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FBB85C7C0; Wed, 5 Dec 2018 19:13:34 +0000 (UTC) Subject: Re: [committed] Handle targets with 2 byte wchar_t better in strlenopt-58.c To: David Edelsohn Cc: GCC Patches References: From: Jeff Law Openpgp: preference=signencrypt Message-ID: <5db5ac9f-ef2f-a1be-e4a0-f55e8e9d60d6@redhat.com> Date: Wed, 05 Dec 2018 19:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00306.txt.bz2 On 12/5/18 11:59 AM, David Edelsohn wrote: > Jeff, > > Thanks for the patch. > > I continue to see a failure on AIX 32 bit mode (2 byte wchar). > > FAIL: gcc.dg/strlenopt-58.c scan-tree-dump-times optimized > "call_in_true_branch_not_eliminated" 0 > > I'm not certain if this is AIX-specific or more fallout from wchar > size. I could ignore with target powerpc-ibm-aix* or with target ! > 4byte_wchar_t. > > Any further insight / preference? I didn't try to address that specific failure yet -- my patch just fixed two earlier warnings. That specific failure either requires a deeper testsuite fix for possibly even a fix to the compiler -- I haven't really analyzed it yet (it's a failure to optimize issue and I've generally avoided looking at those). You could xfail it on 4byte_wchar_t. jeff