From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123169 invoked by alias); 3 Apr 2017 17:01:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 123113 invoked by uid 89); 3 Apr 2017 17:01:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Apr 2017 17:01:25 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v33Gwjeo142749 for ; Mon, 3 Apr 2017 13:01:25 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 29kqbpb3gy-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 03 Apr 2017 13:01:25 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 3 Apr 2017 13:01:19 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 3 Apr 2017 13:01:15 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v33H1F9A56885314; Mon, 3 Apr 2017 17:01:15 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 23CBCAE04E; Mon, 3 Apr 2017 13:01:04 -0400 (EDT) Received: from otta.rchland.ibm.com (unknown [9.10.86.70]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id D3CE7AE04B; Mon, 3 Apr 2017 13:01:03 -0400 (EDT) Subject: Re: [PATCH, rs6000] Fix PR target/80246, DFP builtins using the wrong types To: Segher Boessenkool References: <20170329222858.GZ4402@gate.crashing.org> <530c97bd-1669-dd67-528e-3f879efa8bac@vnet.ibm.com> <87o9wfz2rc.fsf@linux-m68k.org> <20170402185354.GJ4402@gate.crashing.org> Cc: Andreas Schwab , GCC Patches , David Edelsohn , Bill Schmidt From: Peter Bergner Date: Mon, 03 Apr 2017 17:01:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17040317-0008-0000-0000-000001E38FC7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006876; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00842557; UDB=6.00415046; IPR=6.00620733; BA=6.00005262; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014888; XFM=3.00000013; UTC=2017-04-03 17:01:17 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17040317-0009-0000-0000-00003457556B Message-Id: <5ddc3aa0-f8ad-3ca4-4d70-1759f0bd9bb1@vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-03_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704030151 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00094.txt.bz2 On 4/3/17 11:04 AM, Peter Bergner wrote: > On 4/2/17 1:53 PM, Segher Boessenkool wrote: >> I also have a fix for the dfp-builtin-1.c problem. > > Something like the following maybe? It seems to work for me. > I think the hard_dfp predicate was added after the dfp-builtin-[12].c > test cases were added, which is maybe why Mike used powerpc_vsx_ok? > Seems like we should switch it to using hard_dfp now. As we discussed offline, I'll commit the following patch to fix up the dfp-builtin-1.c failures. I'll also commit this to the GCC 5 & 6 release branches, since the same issue exists there. Peter Index: dfp-builtin-1.c =================================================================== --- dfp-builtin-1.c (revision 246653) +++ dfp-builtin-1.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do compile { target { powerpc*-*-linux* } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ +/* { dg-require-effective-target hard_dfp } */ /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */ /* { dg-options "-mcpu=power7 -O2" } */ /* { dg-final { scan-assembler-times "ddedpd " 4 } } */ @@ -8,8 +8,12 @@ /* { dg-final { scan-assembler-times "diex " 1 } } */ /* { dg-final { scan-assembler-times "dscli " 2 } } */ /* { dg-final { scan-assembler-times "dscri " 2 } } */ -/* { dg-final { scan-assembler-times "std " 1 } } */ -/* { dg-final { scan-assembler-times "ld " 1 } } */ +/* { dg-final { scan-assembler-times "std " 1 { target lp64 } } } */ +/* { dg-final { scan-assembler-times "ld " 1 { target lp64 } } } */ +/* 32-bit needs a stack frame, and needs two GPR mem insns per _Decimal64. */ +/* { dg-final { scan-assembler-times "stwu " 2 { target ilp32 } } } */ +/* { dg-final { scan-assembler-times "stw " 2 { target ilp32 } } } */ +/* { dg-final { scan-assembler-times "lwz " 2 { target ilp32 } } } */ /* { dg-final { scan-assembler-times "stfd " 1 } } */ /* { dg-final { scan-assembler-times "lfd " 1 } } */ /* { dg-final { scan-assembler-not "bl __builtin" } } */ Index: dfp-builtin-2.c =================================================================== --- dfp-builtin-2.c (revision 246653) +++ dfp-builtin-2.c (working copy) @@ -1,7 +1,5 @@ /* { dg-do compile { target { powerpc*-*-linux* } } } */ -/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ -/* { dg-skip-if "" { powerpc*-*-*spe* } { "*" } { "" } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ +/* { dg-require-effective-target hard_dfp } */ /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */ /* { dg-options "-mcpu=power7 -O2" } */ /* { dg-final { scan-assembler-times "ddedpdq " 4 } } */