From: Jeff Law <law@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>,
Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC] Fix recent popcount change is breaking
Date: Tue, 10 Jul 2018 14:42:00 -0000 [thread overview]
Message-ID: <5e23af45-e199-a8a4-3890-86c041b19b65@redhat.com> (raw)
In-Reply-To: <CAFiYyc07h=+N9O5_iZFL_euup1P+8S_c2PoUpWKyH6CS4HMWWg@mail.gmail.com>
On 07/10/2018 07:17 AM, Richard Biener wrote:
> On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah
> <kugan.vivekanandarajah@linaro.org> wrote:
>>
>> Hi,
>>
>> Jeff told me that the recent popcount built-in detection is causing
>> kernel build issues as
>> ERROR: "__popcountsi2"
>> [drivers/net/wireless/broadcom/brcm80211/brcmfmac/brcmfmac.ko] undefined!
>>
>> I could also reproduce this. AFIK, we should check if the libfunc is
>> defined while checking popcount?
>>
>> I am testing the attached RFC patch. Is this reasonable?
>
> It doesn't work that way, all targets have this libfunc in libgcc. This means
> the kernel has to provide it. The only thing you could do is restrict
> replacement of CALL_EXPRs (in SCEV cprop) to those the target
> natively supports.
I can certainly live with that, but I think we should reach out to the
kernel developers to proactively make them aware of the requirement to
provide popcount.
Jeff
next prev parent reply other threads:[~2018-07-10 14:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 13:06 Kugan Vivekanandarajah
2018-07-10 13:18 ` Richard Biener
2018-07-10 13:27 ` Jakub Jelinek
2018-07-10 13:34 ` Richard Biener
2018-07-10 14:44 ` Jeff Law
2018-07-10 14:42 ` Jeff Law [this message]
2018-07-11 1:13 ` Kugan Vivekanandarajah
2018-07-11 1:19 ` Andrew Pinski
2018-07-11 1:35 ` Kugan Vivekanandarajah
2018-07-11 5:43 ` Andrew Pinski
2018-07-11 11:26 ` Kugan Vivekanandarajah
2018-07-11 12:31 ` Richard Biener
2018-07-27 13:34 ` Martin Liška
2018-07-27 15:14 ` Richard Biener
2018-07-27 23:36 ` Kugan Vivekanandarajah
2018-11-24 6:38 ` Bin.Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e23af45-e199-a8a4-3890-86c041b19b65@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kugan.vivekanandarajah@linaro.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).