From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Robin Dapp <rdapp@linux.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite/s390: Adapt test expections.
Date: Tue, 5 Apr 2022 07:35:00 +0200 [thread overview]
Message-ID: <5e2da73f-9186-d92d-6c42-17b97eabdf79@linux.ibm.com> (raw)
In-Reply-To: <9c253c2d-ea33-fd62-03ca-caf60c5902d5@linux.ibm.com>
On 4/4/22 13:52, Robin Dapp wrote:
> Hi,
>
> some tests expect a convert instruction but nowadays the conversion is
> already done at compile time. This results in a literal-pool load.
> Change the tests accordingly.
>
> OK for trunk?
>
> Regards
> Robin
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/s390/zvector/vec-double-compile.c: Expect vl
> instead of vc*.
> * gcc.target/s390/zvector/vec-float-compile.c: Dito.
> * gcc.target/s390/zvector/vec-signed-compile.c: Dito.
> * gcc.target/s390/zvector/vec-unsigned-compile.c: Dito.
I've seen Mike's comment but I'm not opposed to checking it in that way. These kind of comments have
probably saved me a few hours of bisecting already. Next time you might consider moving it to the
commit message instead.
Ok. Thanks!
Bye,
Andreas
prev parent reply other threads:[~2022-04-05 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 11:52 Robin Dapp
2022-04-04 22:15 ` Mike Stump
2022-04-05 5:35 ` Andreas Krebbel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e2da73f-9186-d92d-6c42-17b97eabdf79@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdapp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).