From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by sourceware.org (Postfix) with ESMTPS id 7993E3858D20 for ; Mon, 9 Jan 2023 11:14:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7993E3858D20 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf36.google.com with SMTP id g10so459054qvo.6 for ; Mon, 09 Jan 2023 03:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=JafDxXnlSVV5vzFhXEz7bAO+GzzsqGiZKqPx9w40dyE=; b=mAD9XS9s9czBMZqTLiaOINLvO54+b3OGZZwlwpXPWUjJulgKsIzP3pacRK/cm/WBDh p/+fU6HkYJ7/7RWiFPGxJ4Y/EAjsThoMKCldM9WTsXIeQzTDX1doPbcMV+YsowxT5ywf 0m8Yj4HaIMXfJoh4vcpXM6sjRuWRgNe83cFLZQPlpNAhcwE5deeIpWY5o9Tum8eNlKUW yCTpyzcvaRLdG8b62v8UQ5kefKxnudjLrWMucHScQIwXZ+CTv+Hkv9zVMW1X6oS502x+ +qdspZQSv6ClMSWuDzOW/xdOIjf62Xn8U+U6hlFjFkpgMj8uwlnvj6INa+BU+mWrxrCi ZoTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JafDxXnlSVV5vzFhXEz7bAO+GzzsqGiZKqPx9w40dyE=; b=P1KAr4gxrZ71vmVsbxFq7qa7MfWICFrikUbI05mcRJ5gkM4QL5oty478pRNwvV7ZCj EfMqpSbLvbwckja8pN4gTAYbvWqI58MLsK/aDZ9St++1cGhUG7ZcBK7XxVPepxyPj4Hr fIl/INAHnwNxg+OELHzw4Gwi04Pyf+9vN8ywNj7MmkPf6igylIX9L1gSm3jvXNvqkSm5 KSbdaAG+ylUaPva5b5MsOGMZykFYb2OW2QxHhFLcRyVUV4qPImyvOUt8D67dbHSDW4ld cL6b2teZF0gwX+gcUOPxD1ymp4q0S6kd3wjJatCAxBOnMzFAStrGtWkBYPrnKE1YTtaY Hrhw== X-Gm-Message-State: AFqh2krjQq0WGuqxVFi1PLo3SLhn8dxQwLsgTXu4AEfXVo6G/7n0MyWK AifztRDFkAW4SEqdLUC8LASZxiAfyc6rdg== X-Google-Smtp-Source: AMrXdXteD8jMe2F6Hp6uIFfYtBbvTY8c30J1bPwaNWru03XhUBR7SzQHf4qc/h3DKCDaqzaVJiFy2Q== X-Received: by 2002:ad4:5109:0:b0:532:de3:9b70 with SMTP id g9-20020ad45109000000b005320de39b70mr24443588qvp.3.1673262884688; Mon, 09 Jan 2023 03:14:44 -0800 (PST) Received: from ?IPV6:2601:19c:527f:bfd0::3? ([2601:19c:527f:bfd0::3]) by smtp.googlemail.com with ESMTPSA id w29-20020a05620a0e9d00b006fcab4da037sm5169141qkm.39.2023.01.09.03.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 03:14:44 -0800 (PST) Sender: Nathan Sidwell Message-ID: <5e8dd94a-3bed-689c-9c20-ec3a12785c14@acm.org> Date: Mon, 9 Jan 2023 06:14:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] c++tools: Fix compilation of server.cc on hpux To: John David Anglin , GCC Patches References: Content-Language: en-US From: Nathan Sidwell In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3038.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/7/23 14:12, John David Anglin wrote: > Tested on trunk and gcc-12 with hppa64-hp-hpux11.11. ah, I see that is the use that was unprotected, ok. > > Okay? > > Dave > --- > > Fix compilation of server.cc on hpux. > > Select and FD_ISSET are declared in sys/time.h on most versions > of hpux. As a result, HAVE_PSELECT and HAVE_SELECT can be 0. > > 2023-01-07 John David Anglin > > c++tools/ChangeLog: > > PR c++tools/107616 > * server.cc (server): Don't call FD_ISSET when HAVE_PSELECT > and HAVE_SELECT are zero. > > diff --git a/c++tools/server.cc b/c++tools/server.cc > index 00154a05925..693aec6820a 100644 > --- a/c++tools/server.cc > +++ b/c++tools/server.cc > @@ -753,8 +753,10 @@ server (bool ipv6, int sock_fd, module_resolver *resolver) > } > } > > +#if defined (HAVE_PSELECT) || defined (HAVE_SELECT) > if (active < 0 && sock_fd >= 0 && FD_ISSET (sock_fd, &readers)) > active = -1; > +#endif > } > > if (active >= 0) > -- Nathan Sidwell