From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id CFE543858C50 for ; Tue, 20 Sep 2022 07:18:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CFE543858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=linux.vnet.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28K7C1O6005899; Tue, 20 Sep 2022 07:17:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=J3cp21OommhQ1fVeEq7YDTxhtEE1B6OZEgq1s4Zc6+U=; b=I9bo+E824150B3QyRQLSm5P3ulic28d9Ad8g+CzoRiUzPZYt+0gjEjg2Ygn6d2b1LsBL kb2ozBFmPk4sz9Y4TBq+12fa+zm0VMrdUBQp+OTwr43ma6m1O7Q65FjeJcK9scNgJWn5 GxUIzvSjkbEPQv8Ja64sFZE5xRJTIzXTqW6O7s+6EJttQNC+J0/3h6Ic9OYt7luEdfNK JpMvv/iLz+SZStgb+dTK3K7tC3ulWSzzcavLtNrkAcc5seP4wIVkZVRVIndAy+BzmW03 ARyhAUJdWCrqZA619WhpuExxpcJ/vzA8EJ2y41kTf5ZvS6nyrRNVLoji2JdeyJ+XSm4W Kg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jq8wu852d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Sep 2022 07:17:57 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 28K7ErVs019568; Tue, 20 Sep 2022 07:17:57 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jq8wu851w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Sep 2022 07:17:57 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 28K772tL022014; Tue, 20 Sep 2022 07:17:56 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma02dal.us.ibm.com with ESMTP id 3jn5v9ptw4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Sep 2022 07:17:56 +0000 Received: from smtpav03.wdc07v.mail.ibm.com ([9.208.128.112]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 28K7HtnH51446170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Sep 2022 07:17:55 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D99858054; Tue, 20 Sep 2022 07:17:55 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E576E5805A; Tue, 20 Sep 2022 07:17:53 +0000 (GMT) Received: from [9.199.153.98] (unknown [9.199.153.98]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 20 Sep 2022 07:17:53 +0000 (GMT) Message-ID: <5e948661-0429-0783-3ba4-b7150299a844@linux.vnet.ibm.com> Date: Tue, 20 Sep 2022 12:47:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] sched1: Fix -fcompare-debug issue in schedule_region [PR105586] Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: <0312d474-d2de-6c68-5812-5b79f1176b0b@gmail.com> From: Surya Kumari Jangala In-Reply-To: <0312d474-d2de-6c68-5812-5b79f1176b0b@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: LFDry881pIc-Tg0heaAJVByGnbtLIKaP X-Proofpoint-GUID: IiZO9wcAfrF6FtiICbDf2EY6iNuylFcA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-20_02,2022-09-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 mlxscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209200042 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, Richard, Thank you for reviewing the patch! I have committed the patch to the gcc repo. Can I backport this patch to prior versions of gcc, as this is an easy patch to backport and the issue exists in prior versions too? Regards, Surya On 31/08/22 9:09 pm, Jeff Law via Gcc-patches wrote: > > > On 8/23/2022 5:49 AM, Surya Kumari Jangala via Gcc-patches wrote: >> sched1: Fix -fcompare-debug issue in schedule_region [PR105586] >> >> In schedule_region(), a basic block that does not contain any real insns >> is not scheduled and the dfa state at the entry of the bb is not copied >> to the fallthru basic block. However a DEBUG insn is treated as a real >> insn, and if a bb contains non-real insns and a DEBUG insn, it's dfa >> state is copied to the fallthru bb. This was resulting in >> -fcompare-debug failure as the incoming dfa state of the fallthru block >> is different with -g. We should always copy the dfa state of a bb to >> it's fallthru bb even if the bb does not contain real insns. >> >> 2022-08-22  Surya Kumari Jangala  >> >> gcc/ >>     PR rtl-optimization/105586 >>     * sched-rgn.cc (schedule_region): Always copy dfa state to >>     fallthru block. >> >> gcc/testsuite/ >>     PR rtl-optimization/105586 >>     * gcc.target/powerpc/pr105586.c: New test. > Interesting.    We may have stumbled over this bug internally a little while ago -- not from a compare-debug standpoint, but from a "why isn't the processor state copied to the fallthru block" point of view.   I had it on my to investigate list, but hadn't gotten around to it yet. > > I think there were requests for ChangeLog updates and a function comment for save_state_for_fallthru_edge.  OK with those updates. > > jeff >