From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap2.colo.codethink.co.uk (imap2.colo.codethink.co.uk [78.40.148.184]) by sourceware.org (Postfix) with ESMTPS id D40973851C05; Tue, 19 May 2020 07:55:28 +0000 (GMT) Authentication-Results: sourceware.org; dmarc=permerror header.from=codethink.co.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=mark.eggleston@codethink.co.uk Received: from [90.200.106.131] (helo=[192.168.0.10]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1jax5y-0001t2-6y; Tue, 19 May 2020 08:55:26 +0100 Subject: Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392 From: Mark Eggleston To: fortran , gcc-patches References: <33e793d6-7453-f603-8e58-d7c700add5f6@codethink.co.uk> Message-ID: <5ea5d0ef-3c91-8eb5-c739-964556a39853@codethink.co.uk> Date: Tue, 19 May 2020 08:55:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <33e793d6-7453-f603-8e58-d7c700add5f6@codethink.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, KAM_COUK, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 07:55:30 -0000 Messed up the e-mail addressed, gcc-patches now added. Also, I note that I missed the PR fortran/50392 which should be inserted at the start of the change log entries. On 19/05/2020 08:49, Mark Eggleston wrote: > Please find attached patch for PR50392. > > This patch was extracted from the comments in the PR and was written > back in 2011! I have verified that it fixes the PR on master, gcc-8, > gcc-9 and gcc-10. > > Commit message: > > Fortran  : ICE in gfc_trans_label_assign PR50392 > > A function may contain an assigned goto.  If the the return variable > is an integer a statement can be assigned to it.  Prior to this fix > this resulted in an ICE. > > 2020-05-19  Tobias Burnus > > gcc/fortran/ > >     * trans-decl.c (gfc_get_symbol_decl): Remove unnecessary block >     delimiters.  Add auxiliary variables if a label is assigned to >     a return variable. (gfc_gat_fake_result): ??????? > > 2020-05-19  Mark Eggleston > > gcc/testsuite/ > >     * gfortran.dg/pr50392.f: New test. > > As can be seen there is a sequence of question marks in the > description of the changes made. I don't know how to describe the > inserted code, Tobias Burnus: you may be able to help as it is your code. > > Tested on x86_64 using make check-fortran for master, gcc-8, ggc-9 and > gcc-10. > > Once the addition to the description to the code changes is complete > will it be OK to commit to master and backport to gcc-8, 9 and 10. > -- https://www.codethink.co.uk/privacy.html