* Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392 [not found] <33e793d6-7453-f603-8e58-d7c700add5f6@codethink.co.uk> @ 2020-05-19 7:55 ` Mark Eggleston 2020-05-27 6:53 ` Mark Eggleston 1 sibling, 0 replies; 3+ messages in thread From: Mark Eggleston @ 2020-05-19 7:55 UTC (permalink / raw) To: fortran, gcc-patches Messed up the e-mail addressed, gcc-patches now added. Also, I note that I missed the PR fortran/50392 which should be inserted at the start of the change log entries. On 19/05/2020 08:49, Mark Eggleston wrote: > Please find attached patch for PR50392. > > This patch was extracted from the comments in the PR and was written > back in 2011! I have verified that it fixes the PR on master, gcc-8, > gcc-9 and gcc-10. > > Commit message: > > Fortran : ICE in gfc_trans_label_assign PR50392 > > A function may contain an assigned goto. If the the return variable > is an integer a statement can be assigned to it. Prior to this fix > this resulted in an ICE. > > 2020-05-19 Tobias Burnus <tobias@codesourcery.com> > > gcc/fortran/ > > * trans-decl.c (gfc_get_symbol_decl): Remove unnecessary block > delimiters. Add auxiliary variables if a label is assigned to > a return variable. (gfc_gat_fake_result): ??????? > > 2020-05-19 Mark Eggleston <markeggleston@gnu.gcc.org> > > gcc/testsuite/ > > * gfortran.dg/pr50392.f: New test. > > As can be seen there is a sequence of question marks in the > description of the changes made. I don't know how to describe the > inserted code, Tobias Burnus: you may be able to help as it is your code. > > Tested on x86_64 using make check-fortran for master, gcc-8, ggc-9 and > gcc-10. > > Once the addition to the description to the code changes is complete > will it be OK to commit to master and backport to gcc-8, 9 and 10. > -- https://www.codethink.co.uk/privacy.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392 [not found] <33e793d6-7453-f603-8e58-d7c700add5f6@codethink.co.uk> 2020-05-19 7:55 ` [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392 Mark Eggleston @ 2020-05-27 6:53 ` Mark Eggleston 2020-05-27 12:51 ` Thomas Koenig 1 sibling, 1 reply; 3+ messages in thread From: Mark Eggleston @ 2020-05-27 6:53 UTC (permalink / raw) To: fortran, gcc-patches ping On 19/05/2020 08:49, Mark Eggleston wrote: > Please find attached patch for PR50392. > > This patch was extracted from the comments in the PR and was written > back in 2011! I have verified that it fixes the PR on master, gcc-8, > gcc-9 and gcc-10. > > Commit message: > > Fortran : ICE in gfc_trans_label_assign PR50392 > > A function may contain an assigned goto. If the the return variable > is an integer a statement can be assigned to it. Prior to this fix > this resulted in an ICE. > > 2020-05-19 Tobias Burnus <tobias@codesourcery.com> > > gcc/fortran/ > > * trans-decl.c (gfc_get_symbol_decl): Remove unnecessary block > delimiters. Add auxiliary variables if a label is assigned to > a return variable. (gfc_gat_fake_result): ??????? > > 2020-05-19 Mark Eggleston <markeggleston@gnu.gcc.org> > > gcc/testsuite/ > > * gfortran.dg/pr50392.f: New test. > > As can be seen there is a sequence of question marks in the > description of the changes made. I don't know how to describe the > inserted code, Tobias Burnus: you may be able to help as it is your code. > > Tested on x86_64 using make check-fortran for master, gcc-8, ggc-9 and > gcc-10. > > Once the addition to the description to the code changes is complete > will it be OK to commit to master and backport to gcc-8, 9 and 10. > -- https://www.codethink.co.uk/privacy.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392 2020-05-27 6:53 ` Mark Eggleston @ 2020-05-27 12:51 ` Thomas Koenig 0 siblings, 0 replies; 3+ messages in thread From: Thomas Koenig @ 2020-05-27 12:51 UTC (permalink / raw) To: Mark Eggleston, fortran, gcc-patches Hi Mark, > ping Looks good. Thanks! ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-27 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <33e793d6-7453-f603-8e58-d7c700add5f6@codethink.co.uk>
2020-05-19 7:55 ` [PATCH] Fortran : ICE in gfc_trans_label_assign PR50392 Mark Eggleston
2020-05-27 6:53 ` Mark Eggleston
2020-05-27 12:51 ` Thomas Koenig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).