From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Tejas Belagod <Tejas.Belagod@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch 7/8, Arm, GCC] Emit build attributes for PACBTI target feature. [ Was RE: [Patch 6/7, Arm, GCC] Emit build attributes for PACBTI target feature.]
Date: Tue, 7 Dec 2021 14:48:16 +0000 [thread overview]
Message-ID: <5ee84862-83fe-6629-9022-f6018e374f2d@foss.arm.com> (raw)
In-Reply-To: <PAXPR08MB7075DA07D1D24635F114DEC3EA869@PAXPR08MB7075.eurprd08.prod.outlook.com>
On 28/10/2021 12:43, Tejas Belagod via Gcc-patches wrote:
>
>
>> -----Original Message-----
>> From: Gcc-patches <gcc-patches-
>> bounces+belagod=gcc.gnu.org@gcc.gnu.org> On Behalf Of Tejas Belagod via
>> Gcc-patches
>> Sent: Friday, October 8, 2021 1:19 PM
>> To: gcc-patches@gcc.gnu.org
>> Subject: [Patch 6/7, Arm, GCC] Emit build attributes for PACBTI target
>> feature.
>>
>> Hi,
>>
>> This patch emits assembler directives for PACBTI build attributes as defined
>> by the ABI. (https://github.com/ARM-software/abi-
>> aa/releases/download/2021Q1/addenda32.pdf)
>>
>> Tested on arm-none-eabi.
>>
>> 2021-10-04 Tejas Belagod <tbelagod@arm.com>
>>
>> gcc/ChangeLog:
>>
>> * config/arm/arm.c (arm_file_start): Emit EABI attributes for
>> Tag_PAC_extension, Tag_BTI_extension, TAG_BTI_use,
>> TAG_PACRET_use.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/arm/acle/pacbti-m-predef-1.c: New test.
>> * gcc.target/arm/acle/pacbti-m-predef-3: New test.
>> * gcc.target/arm/acle/pacbti-m-predef-6.c: New test.
>
>
> This patch emits assembler directives for PACBTI build attributes
> as defined by the ABI.
> https://github.com/ARM-software/abi-aa/releases/download/2021Q1/addenda32.pdf
>
> 2021-10-25 Tejas Belagod <tbelagod@arm.com>
>
> gcc/ChangeLog:
>
> * config/arm/arm.c (arm_file_start): Emit EABI attributes for
> Tag_PAC_extension, Tag_BTI_extension, TAG_BTI_use, TAG_PACRET_use.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/arm/acle/pacbti-m-predef-1.c: New test.
> * gcc.target/arm/acle/pacbti-m-predef-3: New test.
> * gcc.target/arm/acle/pacbti-m-predef-6.c: New test.
I'm not sure what the value of making these executable tests is. It
means that they can only be used when the test model has PAC/BTI
available. But they don't really test the PAC/BTI generation, so that
seems rather pointless.
Better, IMO to make them simple compile/scan-assembler tests that check
the build attributes are correct.
R.
>
> Tested the following configurations, OK for trunk?
>
> -mthumb/-march=armv8.1-m.main+pacbti/-mfloat-abi=soft
> -marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat-abi=softfp
> mcmodel=small and tiny
> aarch64-none-linux-gnu native test and bootstrap
>
> Thanks,
> Tejas.
>
next prev parent reply other threads:[~2021-12-07 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 11:43 Tejas Belagod
2021-12-07 14:48 ` Richard Earnshaw [this message]
2021-12-10 16:36 ` [Patch 7/8 V2] Arm: Emit build attributes for PACBTI target feature Andrea Corallo
2021-12-10 16:48 ` Richard Earnshaw
2021-12-13 16:52 ` [Patch 7/8 V3] " Andrea Corallo
2021-12-10 16:51 ` [Patch 7/8 V2] " Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee84862-83fe-6629-9022-f6018e374f2d@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tejas.Belagod@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).