From: David Malcolm <dmalcolm@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] attribs: Add missing auto_diagnostic_group 3 times
Date: Tue, 04 Oct 2022 08:27:24 -0400 [thread overview]
Message-ID: <5eec5804f8ca04b06acc2113baab08b555a2c58b.camel@redhat.com> (raw)
In-Reply-To: <Yzv4q6gMMgJnAMQj@tucnak>
On Tue, 2022-10-04 at 11:11 +0200, Jakub Jelinek wrote:
> Hi!
>
> In these spots, the error/error_at has some inform afterwards which
> are
> explanation part of the same diagnostics, so should be tied with
> auto_diagnostic_group with it.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK for trunk; I think future such patches can be self-approved as per
the "obvious" rule.
Thanks
Dave
>
> 2022-10-04 Jakub Jelinek <jakub@redhat.com>
>
> * attribs.cc (handle_ignored_attributes_option,
> decl_attributes,
> common_function_versions): Use auto_diagnostic_group.
>
> --- gcc/attribs.cc.jj 2022-10-03 18:31:16.130032566 +0200
> +++ gcc/attribs.cc 2022-10-03 21:27:02.364104260 +0200
> @@ -251,6 +251,7 @@ handle_ignored_attributes_option (vec<ch
> /* We don't accept '::attr'. */
> if (cln == nullptr || cln == opt)
> {
> + auto_diagnostic_group d;
> error ("wrong argument to ignored attributes");
> inform (input_location, "valid format is %<ns::attr%> or
> %<ns::%>");
> continue;
> @@ -732,6 +733,7 @@ decl_attributes (tree *node, tree attrib
> || (spec->max_length >= 0
> && nargs > spec->max_length))
> {
> + auto_diagnostic_group d;
> error ("wrong number of arguments specified for %qE
> attribute",
> name);
> if (spec->max_length < 0)
> @@ -1167,6 +1169,7 @@ common_function_versions (tree fn1, tree
> std::swap (fn1, fn2);
> attr1 = attr2;
> }
> + auto_diagnostic_group d;
> error_at (DECL_SOURCE_LOCATION (fn2),
> "missing %<target%> attribute for multi-versioned
> %qD",
> fn2);
>
> Jakub
>
prev parent reply other threads:[~2022-10-04 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 9:11 Jakub Jelinek
2022-10-04 12:27 ` David Malcolm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eec5804f8ca04b06acc2113baab08b555a2c58b.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).