From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 075143858430 for ; Wed, 20 Dec 2023 22:55:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 075143858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 075143858430 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703112947; cv=none; b=heAqNGPsV7y4jgRzk0RsWzH+dBZVKJvWw+Ei8xEvDKh42A4VD/LZaSWKqiC8U6cX+0GPHtFBN6/qkYexLDNSyeTypNJnxw64xcp9HhoMPaCtafYKNJP6UDZkD8rjSC+A41SUHhiqiDOpWQZhCc/QsccO5HI+Mq1VyfjN2yimseM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703112947; c=relaxed/simple; bh=PDP6sYZB+uUYtyZLI/2iFB5RIBAdd0LpOvV89MKOa3g=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Px/zfwhP3DWDiLbDIA6coNQix97w2yfqASpwCDBEUqEUoSN6fQaccpw7q0QpeUGxBbioe9A/z68GhG8F09m20zBd6CiTP6nQxoGkSzEpYLH685NkWS+IobS7m0AZv9jnTtsjYOoa8jpeAyCag4p/n5Bl74W/fdslpR3tneC+YFM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6d9f7af8918so126181a34.0 for ; Wed, 20 Dec 2023 14:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1703112943; x=1703717743; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X9GYMpa4fLxq50pNDZ9/3UKWT3AjtpFyO5delMd8k0I=; b=Ld/dq1Ak//IFrZPzAoLy3usJZ8nQmAtMqXDo26MfQjzLySfcSP/muSv803QmcYSOSR rXX4qhycTez4V8rLoigZm5eS43WqL2kgUyOTbtNMhWbEHhUifFZSanH2PNhXC0whQUXT kkXyQsw/9DM5zWgAS5J4iEBYzxjWOHMU3xM/5B/7EHp8DKfLhxJO3d/XpZMxrLjbICrv b1mFj4W0/E2JOJa+tlNr2Sep1QXbaUxQjlz2g6eNDGWAbQZ9OxttbEm931bXVatw8Utk Q08+P5tEBU2OrJ0lg1sfRjPtvl0QgGdTuZUS2wNe42UqWFDIcsDgUiFe4qK79SZgdnf2 PR/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703112943; x=1703717743; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X9GYMpa4fLxq50pNDZ9/3UKWT3AjtpFyO5delMd8k0I=; b=i3GnYtEEyEjxapYtrU43Fv06mk/kurzGJS+yo8uDUr9nvYFPHiPLMMJuvM9ev2iA1k pGHZ7uzigJlFZ+F7z+1leup/iJr0m+QczRfq17MXeSHJDsiAiOdG5l0jSLbm18Urg/fU 7RoAxxZT4spyIIOZXowkWBETi28Y2chE802v0fZfCngpXtrRs2Z4fj8x+rzbi7MGuVlT t7vT+zHjK3h+wyqGytJ3nHcA3n9Xou0fZJh2jlUcG+HfNyQQVvKUMGMXOqaYS+QlqZf7 JdqfYbtJQDmIDqMHMYbJc+td7HzNSZsoGkEmRcBVAvxNTBGuVVIQDi14P+j5mMIOzpe0 9Eaw== X-Gm-Message-State: AOJu0YxgWvy1D5XmXE5zkyCVAtTJUSbdv1IX0A04ey+v5iuZ418zUEeY c1VCQkKsE4MKaQrVHPrPYc758Q== X-Google-Smtp-Source: AGHT+IFVNRQJ9CgfN3lh+fBbKdvXQGgcGfbCvzlLCCBu4TcSzZwYhVZ8qv//rC7+1PDyrS5+JLqeug== X-Received: by 2002:a9d:758b:0:b0:6db:b088:13b7 with SMTP id s11-20020a9d758b000000b006dbb08813b7mr1350383otk.42.1703112943439; Wed, 20 Dec 2023 14:55:43 -0800 (PST) Received: from [10.0.17.83] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id v16-20020a9d69d0000000b006da5f4908b5sm121244oto.77.2023.12.20.14.55.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 14:55:43 -0800 (PST) Message-ID: <5f1b3ce3-e699-4fbc-b680-b56085af0df4@rivosinc.com> Date: Wed, 20 Dec 2023 14:55:41 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3][RFC] RISC-V: Add vector related reservations Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, kito.cheng@gmail.com, Robin Dapp Newsgroups: gmane.comp.gcc.patches References: <20231215185328.794425-1-ewlu@rivosinc.com> <20231215185328.794425-3-ewlu@rivosinc.com> <39a1a8fb-6d6f-4c81-a4df-5d658467e34f@gmail.com> From: Edwin Lu In-Reply-To: <39a1a8fb-6d6f-4c81-a4df-5d658467e34f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/2023 10:57 AM, Jeff Law wrote: > > > On 12/15/23 11:53, Edwin Lu wrote: >> This patch copies the vector reservations from generic-ooo.md and >> inserts them into generic.md and sifive.md. The vector pipelines are >> necessary to avoid an ICE from the assert > >> >> gcc/ChangeLog: >> >>     * config/riscv/generic-ooo.md: syntax >>     * config/riscv/generic.md (pipe0): new reservation >>     (generic_vec_load): ditto >>     (generic_vec_store): ditto >>     (generic_vec_loadstore_seg): ditto >>     (generic_generic_vec_alu): ditto >>     (generic_vec_fcmp): ditto >>     (generic_vec_imul): ditto >>     (generic_vec_fadd): ditto >>     (generic_vec_fmul): ditto >>     (generic_crypto): ditto >>     (generic_vec_perm): ditto >>     (generic_vec_reduction): ditto >>     (generic_vec_ordered_reduction): ditto >>     (generic_vec_idiv): ditto >>     (generic_vec_float_divsqrt): ditto >>     (generic_vec_mask): ditto >>     (generic_vec_vesetvl): ditto >>     (generic_vec_setrm): ditto >>     (generic_vec_readlen): ditto >>     * config/riscv/sifive-7.md (sifive_7): new reservation >>     (sifive_7_vec_load): ditto >>     (sifive_7_vec_store): ditto >>     (sifive_7_vec_loadstore_seg): ditto >>     (sifive_7_sifive_7_vec_alu): ditto >>     (sifive_7_vec_fcmp): ditto >>     (sifive_7_vec_imul): ditto >>     (sifive_7_vec_fadd): ditto >>     (sifive_7_vec_fmul): ditto >>     (sifive_7_crypto): ditto >>     (sifive_7_vec_perm): ditto >>     (sifive_7_vec_reduction): ditto >>     (sifive_7_vec_ordered_reduction): ditto >>     (sifive_7_vec_idiv): ditto >>     (sifive_7_vec_float_divsqrt): ditto >>     (sifive_7_vec_mask): ditto >>     (sifive_7_vec_vesetvl): ditto >>     (sifive_7_vec_setrm): ditto >>     (sifive_7_vec_readlen): ditto >> >> Signed-off-by: Edwin Lu >> Co-authored-by: Robin Dapp >> --- >>   gcc/config/riscv/generic-ooo.md |  19 ++--- >>   gcc/config/riscv/generic.md     | 118 ++++++++++++++++++++++++++++++++ >>   gcc/config/riscv/sifive-7.md    | 118 ++++++++++++++++++++++++++++++++ >>   3 files changed, 242 insertions(+), 13 deletions(-) >> >> diff --git a/gcc/config/riscv/generic-ooo.md >> b/gcc/config/riscv/generic-ooo.md >> index de93245f965..18b606bb981 100644 >> --- a/gcc/config/riscv/generic-ooo.md >> +++ b/gcc/config/riscv/generic-ooo.md > I'm not sure why you changed these.  In general we try to keep lines > under 80 columns in the source.  Things like insn reservations are in a > grey area as the lists sometimes get very long.  In general I'd leave > this stuff alone if it doesn't have a function change. > Hmm when I was testing things before, I encountered an error where the scheduler had a problem with "\ " with the assert enabled, but now I can't reproduce it. I'll revert it back to what it originally was and experiment some more. >> >> index 3e49d942495..7ac974ad634 100644 >> --- a/gcc/config/riscv/generic.md >> +++ b/gcc/config/riscv/generic.md > Note that some of the stuff pointed out on patch #1 applies here to, > like rdfrm not being a vector load/store.  So as you clean up patch #1, > make sure to mirror the cleanups in patch #2 of the series. > Will do! Edwin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id A360F386183E for ; Wed, 20 Dec 2023 22:55:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A360F386183E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A360F386183E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703112952; cv=none; b=tDASU/2KTYzsNsiZDoelaWrIl4OfQVsLeuwk2iDwoQjL4mjLJtAoMC6wZbsN+iEAzgt6d+DmbeQyyQEBeT0PtJVbPgGkDF+LLJp5FkStpDBuVWT74q4A5XZmVU0J+me1Sagdcuk0Bapm0dFVTCI80McAMYFIiF97l8eOy3ySvZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703112952; c=relaxed/simple; bh=PDP6sYZB+uUYtyZLI/2iFB5RIBAdd0LpOvV89MKOa3g=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=RlHMzIXW/htprL8hLU+rWBbMbdfLhGkgzfHa36jZRB5gIKenqmoPWGXNkPVcXpcrSBPSfKstVzHGVBUCUWbknXgdoPJzvH1v644NNQuoK14/vye/hwNk8PF2SGoupC0ZFmoPBV7qIG+LJHDxJ7oEqQIE9HGzdAu8QH/+RaWABmg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rG5Ti-0003Jd-B8 for gcc-patches@gcc.gnu.org; Wed, 20 Dec 2023 23:55:50 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [PATCH 2/3][RFC] RISC-V: Add vector related reservations Date: Wed, 20 Dec 2023 14:55:41 -0800 Message-ID: <5f1b3ce3-e699-4fbc-b680-b56085af0df4@rivosinc.com> References: <20231215185328.794425-1-ewlu@rivosinc.com> <20231215185328.794425-3-ewlu@rivosinc.com> <39a1a8fb-6d6f-4c81-a4df-5d658467e34f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla Thunderbird Cc: gnu-toolchain@rivosinc.com, kito.cheng@gmail.com, Robin Dapp Content-Language: en-US In-Reply-To: <39a1a8fb-6d6f-4c81-a4df-5d658467e34f@gmail.com> X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20231220225541.G_mKbfW9uJb8f-AOfJRUheaJHRHSyXO7l0QL8_1Htio@z> On 12/20/2023 10:57 AM, Jeff Law wrote: > > > On 12/15/23 11:53, Edwin Lu wrote: >> This patch copies the vector reservations from generic-ooo.md and >> inserts them into generic.md and sifive.md. The vector pipelines are >> necessary to avoid an ICE from the assert > >> >> gcc/ChangeLog: >> >>     * config/riscv/generic-ooo.md: syntax >>     * config/riscv/generic.md (pipe0): new reservation >>     (generic_vec_load): ditto >>     (generic_vec_store): ditto >>     (generic_vec_loadstore_seg): ditto >>     (generic_generic_vec_alu): ditto >>     (generic_vec_fcmp): ditto >>     (generic_vec_imul): ditto >>     (generic_vec_fadd): ditto >>     (generic_vec_fmul): ditto >>     (generic_crypto): ditto >>     (generic_vec_perm): ditto >>     (generic_vec_reduction): ditto >>     (generic_vec_ordered_reduction): ditto >>     (generic_vec_idiv): ditto >>     (generic_vec_float_divsqrt): ditto >>     (generic_vec_mask): ditto >>     (generic_vec_vesetvl): ditto >>     (generic_vec_setrm): ditto >>     (generic_vec_readlen): ditto >>     * config/riscv/sifive-7.md (sifive_7): new reservation >>     (sifive_7_vec_load): ditto >>     (sifive_7_vec_store): ditto >>     (sifive_7_vec_loadstore_seg): ditto >>     (sifive_7_sifive_7_vec_alu): ditto >>     (sifive_7_vec_fcmp): ditto >>     (sifive_7_vec_imul): ditto >>     (sifive_7_vec_fadd): ditto >>     (sifive_7_vec_fmul): ditto >>     (sifive_7_crypto): ditto >>     (sifive_7_vec_perm): ditto >>     (sifive_7_vec_reduction): ditto >>     (sifive_7_vec_ordered_reduction): ditto >>     (sifive_7_vec_idiv): ditto >>     (sifive_7_vec_float_divsqrt): ditto >>     (sifive_7_vec_mask): ditto >>     (sifive_7_vec_vesetvl): ditto >>     (sifive_7_vec_setrm): ditto >>     (sifive_7_vec_readlen): ditto >> >> Signed-off-by: Edwin Lu >> Co-authored-by: Robin Dapp >> --- >>   gcc/config/riscv/generic-ooo.md |  19 ++--- >>   gcc/config/riscv/generic.md     | 118 ++++++++++++++++++++++++++++++++ >>   gcc/config/riscv/sifive-7.md    | 118 ++++++++++++++++++++++++++++++++ >>   3 files changed, 242 insertions(+), 13 deletions(-) >> >> diff --git a/gcc/config/riscv/generic-ooo.md >> b/gcc/config/riscv/generic-ooo.md >> index de93245f965..18b606bb981 100644 >> --- a/gcc/config/riscv/generic-ooo.md >> +++ b/gcc/config/riscv/generic-ooo.md > I'm not sure why you changed these.  In general we try to keep lines > under 80 columns in the source.  Things like insn reservations are in a > grey area as the lists sometimes get very long.  In general I'd leave > this stuff alone if it doesn't have a function change. > Hmm when I was testing things before, I encountered an error where the scheduler had a problem with "\ " with the assert enabled, but now I can't reproduce it. I'll revert it back to what it originally was and experiment some more. >> >> index 3e49d942495..7ac974ad634 100644 >> --- a/gcc/config/riscv/generic.md >> +++ b/gcc/config/riscv/generic.md > Note that some of the stuff pointed out on patch #1 applies here to, > like rdfrm not being a vector load/store.  So as you clean up patch #1, > make sure to mirror the cleanups in patch #2 of the series. > Will do! Edwin