From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8FBAD3858299 for ; Wed, 29 Nov 2023 19:03:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FBAD3858299 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FBAD3858299 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701284626; cv=none; b=vKSHE/52ya/7VvcT/PaAZAXw77tI6TFJQePf9pyUqTtx14yzOjnNUTM+TWrWf/hzQGqT5rPbQQW8kY2zbdnAcnEfDbJimhN+//qPCFRrqk6QaUVvg2An0RGryU9egDaUCYW8DvjiWcC4IUggvbLzyxHCje4ZFpHgtiEkErn5aZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701284626; c=relaxed/simple; bh=t7PAjXrb9t0GSdHh1RJ/55wo8OBbxo/w/5woy22eyas=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ew7EaNL5Tvm5gqX/Uba0SyI3vj4g+rDIZIiznh9NFAavvtB2Nwn77OmRcrmUpsAX7QTzmpR0qN4kAyRnfAosgE0Q+fdhfCnsA7MiXo6AyrAb9Wievx22WwtgYViBHdEBrnAs8ZAXKv4fjhre2tw0ctgM7WvsSUqlLFgpUR+vthM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701284625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ckoHHN3uae7uF2PFL9orp/zfLjEdKl2Jzvl8EfP/0k=; b=L3p1GYnwBcu+gneZETiikxRXwzbxltLOQg0xuw/eYRuaUuwx1cXabvhtUe3JeyCEVYERiU lU4VujLnrJ6yLEsbitXpg8PLZOWFCnNzQQvNSRpwd3gU8P1HtksY9rOiL7Xu+MmAHe360e tu1PVFd3PMjMb+IDqAnKaa+An22WOXM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-kuBazVOyO_6i68kpvGwPAw-1; Wed, 29 Nov 2023 14:03:44 -0500 X-MC-Unique: kuBazVOyO_6i68kpvGwPAw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-67a4da4e3c3so1046256d6.3 for ; Wed, 29 Nov 2023 11:03:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701284622; x=1701889422; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9ckoHHN3uae7uF2PFL9orp/zfLjEdKl2Jzvl8EfP/0k=; b=u7QONPn5DYC4TsItyFZzmq7TLosEaUO5QuCZm4w3DYumylZmQbfovGyBDXtLoKwmCu vqbp5Sv+h6J8XENLtfwyTOxoCx48EDkQCQg/A9BLgJ5wbupC29/29drplG1gkhhal1FR dQnzXWc4d9E+ieab3veny7Ape2ldZQMuXvX7wW9M9w5rRXiV95nmAMT3cp2JhOb5628t J/TwyrBuKXnCMYFI+dmhJowopQv2GU5rFDmm+Blx3n4nheLNfrWRhRD4C2rlyt9PSFfU 5ONgYlTlLyUdTE3fA58g+Q3kzDOEamCtBjgmAOUs6t1CCnu4y9ZT87E8m4n7YNB1YzRu iO4Q== X-Gm-Message-State: AOJu0Yw8KJdckOZWc9X+ilKs02jT/53nM91AuQjr8211y8RSgv8IzYH4 ti7wLlffFwHf8VqkfL3pCk32xN+kNYUqOUbQffEBEyC+6NMQcuIZBu/xJA3wemkkVRipKEydDtS H2UKTveKsNdnFcLXvXg== X-Received: by 2002:ad4:4207:0:b0:67a:2940:6f45 with SMTP id k7-20020ad44207000000b0067a29406f45mr12651313qvp.21.1701284622665; Wed, 29 Nov 2023 11:03:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IFr1/HPB4+wv/JUKzGtJ1ji/8g2dDVcXs/hfJGBztX5kHK+YqSRzTNWeBnc9ptsJ0uap5/6tw== X-Received: by 2002:ad4:4207:0:b0:67a:2940:6f45 with SMTP id k7-20020ad44207000000b0067a29406f45mr12651289qvp.21.1701284622373; Wed, 29 Nov 2023 11:03:42 -0800 (PST) Received: from [192.168.1.145] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id di18-20020ad458f2000000b0067a41ed5541sm3271499qvb.64.2023.11.29.11.03.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 11:03:41 -0800 (PST) Message-ID: <5f1e4efb-86ad-41e8-b69d-f91961ed6235@redhat.com> Date: Wed, 29 Nov 2023 14:03:40 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH #2/4] c++: mark short-enums as packed To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, David Malcolm , Rainer Orth , Mike Stump , Nathan Sidwell , "H.J. Lu" References: <78e7499c-2278-44ff-8455-503e3690e3fd@redhat.com> <9d922575-6f5a-4458-b3dc-a25dce128e24@redhat.com> <9f88b17b-4202-454c-abbd-6d9c999ceee8@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/29/23 04:39, Alexandre Oliva wrote: > Hello, Jason, > > On Nov 22, 2023, Jason Merrill wrote: > >> On 11/22/23 13:12, Jason Merrill wrote: >>> I'm coming to the conclusion that your C++ patch is fine but we >>> should remove the TYPE_PACKED warning from >>> check_address_or_pointer_of_packed_member.  And maybe add >>> -Wcast-align=strict to -Wextra. > >> Since I seem to have opinions, I'm preparing a patch for this. > > Thanks for that patch. It makes sense to me, but I suppose that, if > it goes in, I should revert the already-installed #1/4 in this series > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637244.html > rather than install #4/4 that Mike approved. > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637336.html > > I wasn't sure whether your earlier conclusion (quoted above) was meant > as an 'Ok' for the C++ patch. Please confirm if so. TIA, Yes. Jason