From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 64DB33858C78 for ; Sun, 3 Dec 2023 20:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64DB33858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 64DB33858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701637065; cv=none; b=YSXCbxZ45PStCRo3aIuS0CWwY4T1LFc+tSATy0CqETQ4mjFHpP9cmAD+Wxz3NP4r6NJCK+LaU/6NTSPZ4gI4pKEd6M8pEg8xHPateNgQyEbxs2iWgtMKdPxz+8ri9Ye6U94DEDeNgvlfgglRxiqrfLNZGPjxPpa7JMW5LmrqldU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701637065; c=relaxed/simple; bh=TkeC5DQTYak51sFP2ru6R3aYC7g4xwlDqbAisvR/hnw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=g70ZFgLF5QD5L2rPRrX3iB4TQk9cJbz88GIxAvyxzHExfJmhUiRPC07Ca9dNgbmgKUmcRNe+5sHtVedBjOWiDWaNMmIGlWOY593dETuDL9gOw0nHbtRU22We5syplY/HYodcx4thwA7vPqSZdpGrpENzJpxCGDcxPjC1YLO7mTk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6d87ee7aee9so762649a34.2 for ; Sun, 03 Dec 2023 12:57:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701637062; x=1702241862; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gva4vx1GqwvAEMbvntmQitEPKyDDKn0FTZ8Er8F9qyc=; b=Ll/hyn9fEIzLjXtPvjQzxYu2y0ohJkEoJ5RMMQmwLl55sWEIe5+lhTKhdd8SgoXV/T ARfS9ElAR15oiGtVpQxIK2H/pzGhAdAf7dS933TivVe+NnV179twLutPOPHgSDuK5cZP ZHejZRVp0Y2dp/UGTZI4Yd9605AKT3kpQDLfHCeTXt//ATXDp0yZnTAAajBOrsu/rC17 LpJngdWqAeKP3KUpqEVaBHdMfb+ScNTHHo4h67mtDZ56anKwQOUuTCZOlBIDt/03ipXT 9KA9juaCpmFlAhyupPH815YiXg9z/umtnA7JLUuCZg+HWkiEhHx5vkfkJb/C0Kcm+AAt tccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701637062; x=1702241862; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gva4vx1GqwvAEMbvntmQitEPKyDDKn0FTZ8Er8F9qyc=; b=AmCAvrOGj5E0FlCXFRQpSc+eAXN/Vw5D57dcrOq+KsQUeIGyGFPr5It5uuD3cg7OPF 6Keq2TtZAyW50z4dd5BE2h+pKyWLwhdmkE6cuvnWZkiCXX/+/Brjksawt0IVkc7i1WTt 5LNZFM0kTUVPFEBxC1MQa3jSR0sY+Mt7NTZZgFtNZbVoBcAEugZfpvNgvZh3PSrb1cZ1 hZVchCeU3lCRyPcvVm2friHhyGuK5xpBNRkMQYOMrE3vvtGBZ4FV0fdpUqru9x2h/AKQ +EN/lXLlI1kwgBfJXSf9qjrSzRrA3bdY61Wrl48xSLvR6bwoi66g3mueBUtmZ7fQ3SXj 1VWw== X-Gm-Message-State: AOJu0YwMDjh1sVEQlzZC/wAcl6bADHGsdFn9Jl/dgtNG3Lbb71VbjMBD Z6Uuxb/QBWhaKLtp5NtkFZ4= X-Google-Smtp-Source: AGHT+IGDU+fAyiVUSyimYjphpCFz94yd6cXY9yN48yD1uIL7pv7ihI8PSNDF7777LMcP7wakA2QUFQ== X-Received: by 2002:a9d:7396:0:b0:6d8:8088:1545 with SMTP id j22-20020a9d7396000000b006d880881545mr1719905otk.46.1701637061876; Sun, 03 Dec 2023 12:57:41 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id t11-20020a056a00138b00b006ce538550bbsm236410pfg.74.2023.12.03.12.57.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Dec 2023 12:57:41 -0800 (PST) Message-ID: <5f1eb4d5-d168-4ce9-8eb8-39644206fff3@gmail.com> Date: Sun, 3 Dec 2023 13:57:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [committed] Fix gnu23-builtins-no-dfp Content-Language: en-US To: Thomas Schwinge , Florian Weimer , Joseph Myers Cc: gcc-patches@gcc.gnu.org References: <87fs0luded.fsf@euler.schwinge.homeip.net> <3dbc2b93-78fb-47b3-95a6-1efc76d78077@gmail.com> <87cyvn91h4.fsf@mid.deneb.enyo.de> <878r6btqyv.fsf@euler.schwinge.homeip.net> From: Jeff Law In-Reply-To: <878r6btqyv.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/3/23 05:23, Thomas Schwinge wrote: > Hi! > > On 2023-12-03T08:41:59+0100, Florian Weimer wrote: >> * Jeff Law: >> >>> Anyway, this test was the one I was most concerned about. Basically >>> we're testing that on a !dfp target that the builtins are not available. >>> It expects a warning, but gets an error by default now. I just >>> changed the test to use -fpermissive, so that the test behaves as it did >>> previously. >> >> In these ambiguous cases, I cloned tests into -fpermissive and error >> variants. This might be appropriate here as well (or I should remove >> the clones again if those are the wrong thing to do). > > For that test case, it did seem appropriate to me to simply > 's%dg-warning%dg-error', which I already had posted in > > "c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/gnu23-builtins-no-dfp-1.c'", > awaiting review. Rationale: For this test case it's secondary *how* > "implicit declaration of function" is diagnosed, so I'd test the standard > way, which instead of "warning" now is "error". (But no strong feelings > either way.) ;-) Sorry, I missed your fix. I like it better then mine. Approved, along with reverting my bits. jeff