From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73843 invoked by alias); 2 Aug 2019 09:10:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73835 invoked by uid 89); 2 Aug 2019 09:10:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=soft, HContent-Transfer-Encoding:8bit X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Aug 2019 09:10:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CBB46344; Fri, 2 Aug 2019 02:10:16 -0700 (PDT) Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.206.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F7BB3F575; Fri, 2 Aug 2019 02:10:15 -0700 (PDT) Subject: Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544) To: Bernd Edlinger , Richard Biener Cc: "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan , Kyrill Tkachov , Eric Botcazou References: <3da1f037-f060-87ca-36ed-93c2ab73e620@arm.com> From: "Richard Earnshaw (lists)" Message-ID: <5f4abb4f-d34d-00d9-2f06-653786a3dcaa@arm.com> Date: Fri, 02 Aug 2019 09:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2019-08/txt/msg00122.txt.bz2 On 01/08/2019 12:19, Bernd Edlinger wrote: > On 7/31/19 3:16 PM, Richard Earnshaw (lists) wrote: >> >> >> On 30/07/2019 21:51, Bernd Edlinger wrote: >>> +/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft -mabi=aapcs -O3" } */ >> >> This isn't going to work as-is, we test many combinations of the compiler, either with explicit dejagnu settings or with the compiler defaults and the dejagnu settings can't generally be overridden this way. >> >> For -marm you require an effective-target of arm_arm_ok.  For ldrd, it should be enough to just require an effective-target of arm_ldrd_strd_ok, then you can . >> >> I don't think we really care about any ABIs other than aapcs, so I'd just leave that off.  And as for setting the float-abi, I don't see anything in the tests that would require that, so that can probably be omitted as well. >> >> I think with all this, you can then write something like >> >> /* { dg-require-effective-target arm_arm_ok && arm_ldrd_strd_ok } */ >> /* { dg-options "-marm -mno-unaligned-access -O3 } */ >> >> But I haven't tested that, so you might need to fiddle with it a bit, especially the effective-target rule. >> > > Okay, it seems we need two dg-require-effective-target rules for this to work, > as in the attached new version of the patch which I am currently boot-strapping. > > Is it OK for trunk after successful boot-strap and reg-testing? > The tests are OK. If the match rules for the stm instruction turn out to cause problems I think we can just drop them without materially weakening the tests. But lets wait and see on that. I'll leave the mid-end bits to Richi, I'm not familiar with that code. R. > > Thanks > Bernd. >