From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 8A9CF38308C4 for ; Wed, 14 Dec 2022 11:24:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A9CF38308C4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BEBDEot001671; Wed, 14 Dec 2022 11:24:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=mJ42coCpDehYQcwk9tbGL86SmWvP73W78rEbUdvLhN8=; b=oB+mOecLROlJ69NrDMZXP6n2xXyrlC4dmd67FLQvCvRxSM9exeuhdMYX3H8fR3pKeku4 X9PRXC40GG6HYN5kSsJgPdykw8Lbt33zzR8Tm7TopILoKNNNU1cqVeQgk5ugfrFDOhoq fFE39uT7ak+KGLh4rShxdXqMG4xBh5HDSj9ECbAPo5vkkLYBJfstXJXboTNCmeIVCh34 lWAzReTcMGaDnBJi1MEVUEaLDUFvLu2rxZV79kbM1uIedmwo3TjFSqvcqp4+o75AZA9L AlgrpyxYPTtScqC8n6QDAyJIl5H+ZtUiQF+svWWbAZY08ZAnzu2vq/lkg6Q1yuN9UDaT 9g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mfddx08t6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 11:24:29 +0000 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BEBNhdf021382; Wed, 14 Dec 2022 11:24:29 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mfddx08sb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 11:24:29 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BEA2JNO024651; Wed, 14 Dec 2022 11:24:27 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3meypyh2hq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 11:24:27 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BEBOPV215270312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Dec 2022 11:24:25 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 257F420043; Wed, 14 Dec 2022 11:24:25 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1A14D20040; Wed, 14 Dec 2022 11:24:23 +0000 (GMT) Received: from [9.197.253.236] (unknown [9.197.253.236]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 14 Dec 2022 11:24:22 +0000 (GMT) Message-ID: <5f7b4c26-7509-ff89-2fbd-8b1ed3028594@linux.ibm.com> Date: Wed, 14 Dec 2022 19:24:21 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^2 [PATCH v2] rs6000: Rework option -mpowerpc64 handling [PR106680] Content-Language: en-US To: GCC Patches Cc: Peter Bergner , Iain Sandoe , David Edelsohn , Segher Boessenkool References: <63afd344-38fa-7a8e-4958-8256c2a9bca7@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4SxPv-pSFAIIzZj9sZ_Mbgry5PqUDvn1 X-Proofpoint-ORIG-GUID: 2dwpLVfNDig4tMVh4V0VsVB34b-E7Cja Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-14_04,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212140087 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603350.html BR, Kewen > on 2022/10/12 16:12, Kewen.Lin via Gcc-patches wrote: >> Hi, >> >> PR106680 shows that -m32 -mpowerpc64 is different from >> -mpowerpc64 -m32, this is determined by the way how we >> handle option powerpc64 in rs6000_handle_option. >> >> Segher pointed out this difference should be taken as >> a bug and we should ensure that option powerpc64 is >> independent of -m32/-m64. So this patch removes the >> handlings in rs6000_handle_option and add some necessary >> supports in rs6000_option_override_internal instead. >> >> With this patch, if users specify -m{no-,}powerpc64, the >> specified value is honoured, otherwise, for 64bit it >> always enables OPTION_MASK_POWERPC64; while for 32bit >> and TARGET_POWERPC64 and OS_MISSING_POWERPC64, it disables >> OPTION_MASK_POWERPC64. >> >> btw, following Segher's suggestion, I did some tries to warn >> when OPTION_MASK_POWERPC64 is set for OS_MISSING_POWERPC64. >> If warn for the case that powerpc64 is specified explicitly, >> there are some TCs using -m32 -mpowerpc64 on ppc64-linux, >> they need some updates, meanwhile the artificial run >> with "--target_board=unix'{-m32/-mpowerpc64}'" will have >> noisy warnings on ppc64-linux. If warn for the case that >> it's specified implicitly, they can just be initialized by >> TARGET_DEFAULT (like -m32 on ppc64-linux) or set from the >> given cpu mask, we have to special case them and not to warn. >> As Segher's latest comment, I decide not to warn them and >> keep it consistent with before. >> >> Bootstrapped and regress-tested on: >> - powerpc64-linux-gnu P7 and P8 {-m64,-m32} >> - powerpc64le-linux-gnu P9 and P10 >> - powerpc-ibm-aix7.2.0.0 {-maix64,-maix32} >> >> Hi Iain, could you help to test this new patch on darwin >> again? Thanks in advance! >> >> Is it ok for trunk if darwin testing goes well? >> >