From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C07783850436; Thu, 10 Dec 2020 17:14:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C07783850436 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0BAH1xwX142134; Thu, 10 Dec 2020 12:14:30 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 35bq5csqms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Dec 2020 12:14:30 -0500 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0BAH2IvL143285; Thu, 10 Dec 2020 12:14:30 -0500 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 35bq5csqme-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Dec 2020 12:14:29 -0500 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0BAHCbpk013072; Thu, 10 Dec 2020 17:14:29 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma03dal.us.ibm.com with ESMTP id 3581u9ug2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Dec 2020 17:14:29 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0BAHESEm27853104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Dec 2020 17:14:28 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 58486112062; Thu, 10 Dec 2020 17:14:28 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 64A50112061; Thu, 10 Dec 2020 17:14:27 +0000 (GMT) Received: from [9.160.24.173] (unknown [9.160.24.173]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 10 Dec 2020 17:14:27 +0000 (GMT) Subject: Re: [PATCH] libstdc++: Add C++ runtime support for new 128-bit long double format To: Jonathan Wakely , Tulio Magno Quites Machado Filho Cc: Michael Meissner , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Bill Schmidt , David Edelsohn , Segher Boessenkool References: <20201111215001.GA231697@redhat.com> <20201130213029.GA10782@ibm-toto.the-meissners.org> <20201201151011.GA2761400@redhat.com> <20201201160430.GL2309743@redhat.com> <87v9dibiah.fsf@linux.ibm.com> <20201204003542.GC2309743@redhat.com> <20201210161415.GA2309743@redhat.com> From: Peter Bergner Message-ID: <5f94d7e3-772c-398f-e2f6-7eb62d4509d3@linux.ibm.com> Date: Thu, 10 Dec 2020 11:14:26 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201210161415.GA2309743@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-10_06:2020-12-09, 2020-12-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 mlxscore=0 malwarescore=0 adultscore=0 clxscore=1011 priorityscore=1501 spamscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012100105 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2020 17:14:35 -0000 On 12/10/20 10:14 AM, Jonathan Wakely wrote: > On 04/12/20 00:35 +0000, Jonathan Wakely wrote: >> On 03/12/20 20:07 -0300, Tulio Magno Quites Machado Filho via Libstdc++ wrote: >>> I suggest to replace frexpf128 with __frexpieee128. >>> >>> The former is available on a glibc that support _Float128 (since glibc 2.26). >>> The later is available on a glibc that supports binary128 long double (since >>> glibc 2.32) >> >> Hmm, yes, you pointed me to __frexpieee128 a few months ago, but for >> some reason I either didn't switch to using it, or lost a patch when >> squashing and rebasing branches. Hopefully I just forgot to change it, >> but I'll double check to make sure I haven't left any work on an old >> branch. Thanks for suggesting it (again!) > > As expected, it still works with a check for __frexpieee128 instead. > > So are you happy for me to push this to master with that change? > > (It won't be until Tuesday now, as I have some time off). FYI, Tulio is on vacation through December 22nd and I'm not sure how closely he is watching his email, if at all. Given Tulio mentioned the change in the first place, I think he's ok with the change. He can beat me later if I'm wrong! :-) Peter