On 06/20/2017 01:35 PM, Rainer Orth wrote: > JonY <10walls@gmail.com> writes: > >> On 06/20/2017 01:01 PM, Rainer Orth wrote: >>> Given that there were no other comments, I've installed the patch. It >>> would still be nice if the Cygwin/MingW maintainer could comment on the >>> testcase situation for those targets. >> >> Honestly, I'm not sure how ms-bitfields work on non-Windows targets, > > I just noticed that it's handled in generic code in i386.c and the > affected tests worked on the likes of Linux and Solaris ;-) gcc/testsuite/gcc.dg/array-quals-1.c asm bits probably won't work due to object format difference gcc/testsuite/gcc.dg/lto/20091013-1_1.c I'm not familiar with LTO enough to comment on it gcc/testsuite/gcc.dg/lto/20091013-1_2.c dto. gcc/testsuite/gcc.dg/pr32370.c This probably should be safe to enable for all. gcc/testsuite/gcc.dg/pr50251.c dto. gcc/testsuite/gcc.dg/tls/thr-cse-1.c I think this should stay as is. gcc/testsuite/gcc.dg/weak/weak-15.c ELF weak symbols don't really work on Windows PE format and are known to be broken gcc/testsuite/gcc.dg/weak/weak-16.c dto. gcc/testsuite/gcc.dg/weak/weak-2.c dto. gcc/testsuite/gcc.dg/weak/weak-3.c dto. gcc/testsuite/gcc.dg/weak/weak-4.c dto. gcc/testsuite/gcc.dg/weak/weak-5.c dto. libffi/testsuite/libffi.call/cls_longdouble_va.c iirc libffi hasn't been ported for 64bit Windows gcc/testsuite/g++.dg/abi/bitfield3.C Should remain 32bit specific gcc/testsuite/g++.dg/ext/dllexport3.C Should be x86_64-*-cygwin too gcc/testsuite/g++.dg/ext/selectany1.C dto. gcc/testsuite/g++.dg/ext/selectany2.C dto. gcc/testsuite/g++.old-deja/g++.ext/attrib5.C Probably broken due to the underscore prefix in asm names for 32bit mingw/cygwin gcc/testsuite/gcc.dg/dll-3.c Should be x86_64-*-cygwin too gcc/testsuite/gcc.dg/dll-4.c dto. gcc/testsuite/gcc.dg/dll-5.c dto. gcc/testsuite/gcc.dg/dll-8.c dto. gcc/testsuite/gcc.dg/tree-ssa/loop-1.c dto. gcc/testsuite/gcc.target/i386/fastcall-1.c Keep as is, x86 specific test case. I can't comment on the ARM mingw* port, I have no experience with it.