From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 19CCD3853561 for ; Sat, 22 Apr 2023 00:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19CCD3853561 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-63b60365f53so3529271b3a.0 for ; Fri, 21 Apr 2023 17:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682123028; x=1684715028; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=csnZ8Dc5D7Y12vjKQ0Z8Dp8tbCSu+/pX2GtRs7WbKTQ=; b=qIxcZq45rcOKfoaIWikZhtEizcyUwuyOQnPPT15pVcafJFELucnpkXZkoqCzDi3ZXA ZtsxnCwckIxiQg8zZ52OZ0aMnKkjcbmaqyBcDeAb3jAlsrv4wLlJSButbcEOFgAQ7JZF YvSwqmN/hLRRDjzDYq9N4iSrptQMdumSf+IdVyUzAtEZyDibep+g6ErkW/WvyvzuOjNa tsm5ASFi4hM5qtKQXWaKSZtpZBwUVkDCAbHuAiUEn9i2J1khI0pcux8x9xZVS4GmAbr0 4060hBPcZXhSDJQAymadN5Y4ys6yrwEnh2/vKoXahQX9+S0vbXTf6ogXf7V8N9Lxazrk YP/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682123028; x=1684715028; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=csnZ8Dc5D7Y12vjKQ0Z8Dp8tbCSu+/pX2GtRs7WbKTQ=; b=fblr29pQB5v1tZgEzg6cp5dWtedM5+uIOzGnyToS120WosHUnj2StX99iNvlTqBrq/ CK6Pz99DO1yufkSSH6KyUssWN8fuVQnCJLt8COYh5Bdsogl/N0CUQDNagTe5jCpZxHYX 4tqRZYiWgdLySkkSRWKR8MW7BubjS46fQdFgO6CqavPtDyYuQGBY6h4ut6lCYJUXLMlE XzhvnCSmME0L8p4SQMb9NZHwYUnRDS6rNdpdP+IfA1CcCGbo3Ln2rE+RffmmsdLuk33s skkHi35s0zz33KQrntEyBhXIl2mpTlEL5P3c6yrbhbKpvrhjFjTYGtXCcHuZnYmI1LuM 3Z4g== X-Gm-Message-State: AAQBX9cFAW/lyaOP9ZZcoo/62SBbejkkTpXv1GbAXXL0DukeGPCcfvRu MX4EStouqG9C599TJq8ZT0E= X-Google-Smtp-Source: AKy350YljzUH1prYM3MzM6gHxHQoEH1zxI+0zFkaIOiRLj2qfCoVT8T6LRB1LSKZ2eQqpXgYX8GGKw== X-Received: by 2002:a05:6a00:2e06:b0:63a:33d5:9224 with SMTP id fc6-20020a056a002e0600b0063a33d59224mr8353334pfb.18.1682123027799; Fri, 21 Apr 2023 17:23:47 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id fc2-20020a056a002e0200b0062d859a33d1sm3507135pfb.84.2023.04.21.17.23.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 17:23:47 -0700 (PDT) Message-ID: <5ff6dba5-7928-4f3d-d9d4-870b083bdff4@gmail.com> Date: Fri, 21 Apr 2023 18:23:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] vect: Verify that GET_MODE_NUNITS is greater than one. Content-Language: en-US To: Michael Collison , gcc-patches@gcc.gnu.org References: <20230314215256.4153026-1-collison@rivosinc.com> From: Jeff Law In-Reply-To: <20230314215256.4153026-1-collison@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/14/23 15:52, Michael Collison wrote: > While working on autovectorizing for the RISCV port I encountered an issue > where can_duplicate_and_interleave_p assumes that GET_MODE_NUNITS is a > evenly divisible by two. The RISC-V target has vector modes (e.g. VNx1DImode), > where GET_MODE_NUNITS is equal to one. > > Tested on RISCV and x86_64-linux-gnu. Okay? > > 2023-03-09 Michael Collison > > * tree-vect-slp.cc (can_duplicate_and_interleave_p): > Check that GET_MODE_NUNITS is greater than one. Is this still relevant? I know other changes were made to deal with the case where GET_MODE_NUNITS returns 1, but I don't know if they made this obsolete. Any chance we could get a testcase for this? I realize it might depend on unmerged RVV bits. jeff