From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 65B5D3858D38 for ; Fri, 1 Dec 2023 07:10:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65B5D3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 65B5D3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701414657; cv=none; b=kFBzebzwriJjfsDq1/ii+r3vbleDxTr37gbKg6ymbZqD6nbrsRvv2Vq/CQIKcxk/C3VolY4S8dkX40oAi/G0NZt4dWd/S5+Bsl0/1FfpWatMbkbnvumGDkcYKSgu13QYOdfjY64Ze8vmPN83tXBxkO7rUq+qUWMrXtdO8r//Gkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701414657; c=relaxed/simple; bh=dJOntEacYD3mFvs86MFV5/QZ9z+SonshAqZSCcLtHTI=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=MSLKwalnaj7QbFQPORFb5/sWD3AEhCBlD9+kpbrqIpZTHsXa0Vqr0iG//z4k9gXnJyyKEqeYF9OLYMNPLg+7JxPLSPFbSnOwrOkzlvgVu/11A8zc1L+zfYPUardHNR4kYGj6lqYgtY5rFdXA4BOiseCnHADWmCOBm2bNjhNokKw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 085351FD52; Fri, 1 Dec 2023 07:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1701414654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ogyv5zuL1v45mpq1UiIPEPBTmzLpi+0dZNaTSeQmmeU=; b=Wzbiio6asxZvDOHzT2H+1pNhqw17TUK+aIrAZvTixDrcBeGEdEY8nNeKiMfhwxpITn635k itfLwWOs8C9HTuhZIzIYQSXo61NFYOcYmv9zTkW+6bZuof7Vse3B3fmE1fzxj63UzQ0dXJ 62UU+CedUMfAuVbyPd3Ke1/GooBNNKU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1701414654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ogyv5zuL1v45mpq1UiIPEPBTmzLpi+0dZNaTSeQmmeU=; b=R0zDT/cA2uknnqbkEEb/+KhpFdmgzDXabD+RCyKjlkDYPji9d15SfIorhEeqTb3xAWHFm8 vSeJHGGwflFzhpCQ== Date: Fri, 1 Dec 2023 08:07:14 +0100 (CET) From: Richard Biener To: Hans-Peter Nilsson cc: oliva@adacore.com, gcc-patches@gcc.gnu.org, botcazou@adacore.com, jeffreyalaw@gmail.com, ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32 In-Reply-To: <20231201033538.87F472042C@pchp3.se.axis.com> Message-ID: <5ro82896-4qq5-po26-12p5-97rnnoo31p37@fhfr.qr> References: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com> <20231129180047.1334620430@pchp3.se.axis.com> <20231130170910.5B7C720442@pchp3.se.axis.com> <20231201033538.87F472042C@pchp3.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spamd-Result: default: False [-4.29 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com,comcast.net]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.19)[-0.954]; RCPT_COUNT_SEVEN(0.00)[7]; DBL_BLOCKED_OPENRESOLVER(0.00)[arm.com:email,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[adacore.com,gcc.gnu.org,gmail.com,CeBiTec.Uni-Bielefeld.DE,comcast.net]; BAYES_HAM(-3.00)[100.00%] X-Spam-Score: -4.29 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 1 Dec 2023, Hans-Peter Nilsson wrote: > > From: Hans-Peter Nilsson > > Date: Thu, 30 Nov 2023 18:09:10 +0100 > > Richard B.: > > > > In the end we might need to move/duplicate the test to some > > > > gcc.target/* dir and restrict it to a specific tuning. > > > > I intend to post two alternative patches to get this > > resolved: > > 1: Move the tests to gcc.target/i386/scev-[3-5].c > > Subject: [PATCH 1/2] testsuite: Fix XPASS for gcc.dg/tree-ssa/scev-3.c, -4.c and -5.c [PR112786] > > This is the first alternative, perhaps the more appropriate one. > > Tested cris-elf, arm-eabi (default), x86_64-linux, ditto -m32, > h8300-elf and shle-linux; xpassing, skipped and passing as > applicable and intended. > > Ok to commit? Digging in history reveals the testcases were added by Jiangning Liu , not for any particular bugreport but "The problem is originally from a real benchmark, and the test case only tries to detect the GIMPLE level changes." I'm not sure we can infer the testcase should be moved to gcc.target/arm/ because of that, but it does seem plausible. I read from your messages that the testcases pass on arm*-*-*? Richard. > -- >8 -- > PR testsuite/112786 > * gcc.dg/tree-ssa/scev-3.c, gcc.dg/tree-ssa/scev-4.c, > gcc.dg/tree-ssa/scev-5.c: Revert last change and move... > * gcc.target/i386/scev-3.c, gcc.target/i386/scev-4.c: > gcc.target/i386/scev-5.c: ...here. > --- > gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-3.c | 3 +-- > gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-4.c | 3 +-- > gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-5.c | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > rename gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-3.c (80%) > rename gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-4.c (81%) > rename gcc/testsuite/{gcc.dg/tree-ssa => gcc.target/i386}/scev-5.c (81%) > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c b/gcc/testsuite/gcc.target/i386/scev-3.c > similarity index 80% > rename from gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > rename to gcc/testsuite/gcc.target/i386/scev-3.c > index beea9aed9fe9..ac8c8d4519e3 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-3.c > +++ b/gcc/testsuite/gcc.target/i386/scev-3.c > @@ -40,5 +40,4 @@ __BB(6): > > } > > -/* Not all 32-bit systems fail this, but several do. */ > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ > +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c b/gcc/testsuite/gcc.target/i386/scev-4.c > similarity index 81% > rename from gcc/testsuite/gcc.dg/tree-ssa/scev-4.c > rename to gcc/testsuite/gcc.target/i386/scev-4.c > index a97f75f81f65..b0d594053019 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-4.c > +++ b/gcc/testsuite/gcc.target/i386/scev-4.c > @@ -45,5 +45,4 @@ __BB(6): > > } > > -/* Not all 32-bit systems fail this, but several do. */ > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ > +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c b/gcc/testsuite/gcc.target/i386/scev-5.c > similarity index 81% > rename from gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > rename to gcc/testsuite/gcc.target/i386/scev-5.c > index 08f4260403c4..c911a9298866 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/scev-5.c > +++ b/gcc/testsuite/gcc.target/i386/scev-5.c > @@ -40,5 +40,4 @@ __BB(6): > > } > > -/* Not all 32-bit systems fail this, but several do. */ > -/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ilp32 } } } */ > +/* { dg-final { scan-tree-dump-times "&a" 1 "ivopts" { xfail ia32 } } } */ > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)