From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 071F13858C56 for ; Sat, 20 Jan 2024 00:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 071F13858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 071F13858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705711981; cv=none; b=ZXarZ5nIb4A4oUq7CdA1/d6+Lat1BL1QsvlbA1kZ7aMUJaNniV2nWSmeVHxNB+R5fmJjAJH66v0LzyaZIQq83KBd6+Xk5X2lgRS8auQze5WMczYgQnlxIyexmaRTu8mWRXvnaZEyWkwCIYXDbhvDMG5ko0Wr3sz1233+n2terFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705711981; c=relaxed/simple; bh=rHuGuQEmE9Lxey13XSOVuEl/BXbrRWqrS+lemRRKMFw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VAvadvUp4kC2AsDVw3eQzw4M4hnU5g3/ee07/xxnxgGbSm+dDo1WGnw5RDWqyDM7lecosmRC64KWkKwNKZB5HP2qfDb1aZpPzreJPGsNnR5wdKts2aQatYhZ3Uh+Rj2K9++8rybX0fgaO6wBj2obgZBUcNTqiyu+npD6vMyKtek= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-361aad59aefso2488965ab.0 for ; Fri, 19 Jan 2024 16:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705711976; x=1706316776; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4y9X3HGoR+pAE8G2SFIxxTqJ/qe7qfvtpOOg2EO9vOY=; b=k5KXO30Iv+jESPURrMtvjQJl5M57p2Orgac5bZrMan3PatSt1iALQjSBfnMKm83Aik tXKbpUsl8GIAZKA/YFY4sGjLk85eGpXSDldXcj+dInCOnk6HT53jOsBuwRHF71kZRS+q ErWgxi7iwzV4/kU3CbgxyRBzNNDK2Mnr+B94yaVJpux/FdKhDjFbGZc0/RRPFUbSZlar 2eA83FdjqgIyxIQHpBR+MjaB429Mu4NDk7uTw7BAFmsIypOpIVsSmfPtT36YKj5YQ3Ta lxlVtDUFnpnGFol3EV7KEBe3BuYlDco7W5XWIW2qcqd2EAPY1fibVtkfhoNBGdhBhlIN a94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705711976; x=1706316776; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4y9X3HGoR+pAE8G2SFIxxTqJ/qe7qfvtpOOg2EO9vOY=; b=MrvhKCsdqbD5LawmUTEItL5v1UMP00fYiJRLuHnaxKU5/7W+CBsv+NXJ+tZnYPxOZC D5VsiqM35BTGV6fGzO57j0hCLEmjd1GdgmRCNSrARwvEmqK1ocIn7YE2z16ASKXv/6uU E4zMgGTu+h3TU7BbcK7izRJ9kEPGdTYzwjyIUIBtjHEDBwuzUAIeIVksNjP0WVkB0U0Y g4R25ppY3HHsrG5SDxF3yF0rW2Qo55PcR5/UJazwoW/Lc+jUcnlAO3IyboAVwnaVes2T cRR4klOv5d1uFgB3Ax/qlsK956blHOUfaZElq5ARaYm7x9ItCxa1x9756twpPsdDkwKh Ijbg== X-Gm-Message-State: AOJu0Yw93SPV5K+vlPWyRZ/SHby7JlyLBZ/hfStsqwmNX3WxzT2rNt3i qSz01cfMF1WJhQ66Jf5Z7f1fQFzgAOj6q6QNZ1x5s5loSQ8RkO79 X-Google-Smtp-Source: AGHT+IEUfch3Q7Z+RXdS7TiUxvxSmMv/C/Z4PehTBqhrVX/sIkHayGaSMTrI0c6IEJgIPEuN/UKwXA== X-Received: by 2002:a05:6e02:cad:b0:35f:aad1:5151 with SMTP id 13-20020a056e020cad00b0035faad15151mr508814ilg.28.1705711976003; Fri, 19 Jan 2024 16:52:56 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id x1-20020a056e021bc100b00361b0ef6573sm243746ilv.82.2024.01.19.16.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jan 2024 16:52:55 -0800 (PST) Message-ID: <6015693d-ec76-4737-a4a1-f319418bafc5@gmail.com> Date: Fri, 19 Jan 2024 17:52:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] RISC-V: Suppress warning Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org Cc: pan2.li@intel.com, schwab@linux-m68k.org References: <20240120002739.2860933-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20240120002739.2860933-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/19/24 17:27, Juzhe-Zhong wrote: > ../../gcc/config/riscv/riscv.cc: In function 'void riscv_init_cumulative_args(CUMULATIVE_ARGS*, tree, rtx, tree, int)': > ../../gcc/config/riscv/riscv.cc:4879:34: error: unused parameter 'fndecl' [-Werror=unused-parameter] > 4879 | tree fndecl, > | ~~~~~^~~~~~ > ../../gcc/config/riscv/riscv.cc: In function 'bool riscv_vector_mode_supported_any_target_p(machine_mode)': > ../../gcc/config/riscv/riscv.cc:10537:56: error: unused parameter 'mode' [-Werror=unused-parameter] > 10537 | riscv_vector_mode_supported_any_target_p (machine_mode mode) > | ~~~~~~~~~~~~~^~~~ > cc1plus: all warnings being treated as errors > make[3]: *** [Makefile:2559: riscv.o] Error 1 > > Suppress these warnings. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_init_cumulative_args): Suppress warning. > (riscv_vector_mode_supported_any_target_p): Ditto. There's actually more cleanup to do in there ;-) One of the arguments currently marked as unused is actually used. And the better way to handle unused arguments is to just drop their name (like you did with riscv_vector_mode_supported_any_target_p). I'm actually in the process of bootstrapping and regression testing the additional fixes to riscv_init_cumulative_args. jeff