From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 092AE3858286 for ; Thu, 21 Dec 2023 04:41:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 092AE3858286 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 092AE3858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703133704; cv=none; b=SEMfYfSYcPZvfl8JXV1DAlTylPvtlnMtQLAoiBFshblj4KnZwiDJfLvbRYmNyA2JDigj/QQF/6h7ltwn9CMrCoCTOWleMxMhYe2RhLpxBz+nxbvI6FpinjuruY6L3ujVevRbz7VfgKsFwuETOIzwtQeTsQQqe7Zy7VoJC5yqk7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703133704; c=relaxed/simple; bh=PK5TR0GcqEXUOjHAALrPYahD4PWr+e4JAY0LE8EsrDk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cpbxJj0zGlkTioplAfLnBqhl/seBcp81enSYr1Dcph1VBctYFqTUQ7/KX3yxGbzCYXIAX+hIF+OyYH6SQVsnWYoyx/hXFNX81mfi3GApUEApMb/Jlf5O7ukWWcBzKS2hXbHoR5b0rHe/4iuxiuR+xwH9Zd1Y/drVTmmSiZqeUtE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7ba8e33dd0cso3715839f.0 for ; Wed, 20 Dec 2023 20:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703133702; x=1703738502; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N/322ZKQdT/4+vy9faDLqjwmsGQDu2zPY8OziySvVpM=; b=QQuNOwMkSF2s5blHPqp1iGaonYUFncScs6Mt2wW0qykoVHIFF43ig+qJ+FwpqPCUii 9Jx9sTmmHm7/EgutClrrlSEs2mlH9fydxVehTdanqdxZwWzIGhobe05wytFa9lNBXhiy Kt1VCl4vQHadPEoOuLRng7uCp7o7+/Ufn53+HpYKxTgUkl41J4BlLHYUQh8f00lgT949 0EtVhw7Vxbs5k5bwKfIUeFaFN60fIt6b/VWM8DPFZSj3H4nAWqaA0F9mqzaiBsirzcq5 ch9xitBslZO1j7tcpjLPo7EMlfO+9bevjQTob6D+QKXhtFic6k9+6fLgJso4FjDzzVWf N+iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703133702; x=1703738502; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N/322ZKQdT/4+vy9faDLqjwmsGQDu2zPY8OziySvVpM=; b=j3xMeqfZ4xo7OqtQu1UsrNgp0rJdeTFbuD32p5q86uxwz9NrLIeeOrXIkVQ9g+qCdG V71xfsTGLRStMYuxukihikoY+4x4gbQWlquLAuS8HUob2XIfGhYnH+qbU9RVy0bF8l4M EwoFABU2rxrNfzRpa9XGE9pk8d3zTV0EOrpculkY7xx8crmOK2MYqdUhSbX8iIIi9gDP Ofg5s0nAeKlun/JIeCd8TK9PppC7LWVjkB5o2euLetkx+i96WvKCUzmXPZcHTPPol+L+ FDXTiQ2CmW3G0/Dviq5+Fcmgq9jewjB/aAlthDnVP2LzeP46HrVkHn9/Kxxd/Go6WeyU OaUA== X-Gm-Message-State: AOJu0YzUwoGAsVQQpJUQU7Q7jXJFhQFJSbLrUnLfdg/6wQKa0z52qZCX VISELNIEXCp3XBFHDrz6Cq4= X-Google-Smtp-Source: AGHT+IGqhOutUoPqGJcTHuOdpOBL0lTAYOEUiYHdppsDY//DnI8oSbodH2bFcYlCMba/Ls6MciQVxQ== X-Received: by 2002:a05:6e02:1b0d:b0:35f:ac8b:7009 with SMTP id i13-20020a056e021b0d00b0035fac8b7009mr8455512ilv.24.1703133702112; Wed, 20 Dec 2023 20:41:42 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id t2-20020a056e02060200b0035d6078c9afsm284573ils.18.2023.12.20.20.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Dec 2023 20:41:41 -0800 (PST) Message-ID: <60201857-c9c2-4e20-a79d-cc4bdbfb17bb@gmail.com> Date: Wed, 20 Dec 2023 21:41:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] RISC-V: Adds the prefix "th." for the instructions of XTheadVector. Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , "cooper.joshua" , gcc-patches Cc: "jim.wilson.gcc" , palmer , andrew , "philipp.tomsich" , =?UTF-8?Q?Christoph_M=C3=BCllner?= , jinma , Cooper Qu References: <20231220122055.343-1-cooper.joshua@linux.alibaba.com> <20231220123249.555-1-cooper.joshua@linux.alibaba.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/23 15:48, 钟居哲 wrote: > >> So rather than looking at the mode, would it make more sense to have an >>>attribute (or re-use an existing attribute) to identify which opcodes >>>are going to need prefixing?  We've got access to the INSN via >>>current_output_insn.  So we can lookup attributes trivially. > > Yes, I totally aggree with Jeff's idea. We have addes many attributes > for each RVV instructions. > For example, VSETVL PASS is highly depending on those attribute to do > the optimizations. Also note that with attributes, we can potentially even deal with cases where some alternatives need special handling while other alternatives simply aren't available with the thead extension. Not sure if that's going to be needed or not, but it's worth remembering. Jeff