From: Olivier Hainque <hainque@adacore.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Nicolas Roche <roche@adacore.com>
Subject: Re: fix libcc1 dependencies in toplevel Makefile
Date: Mon, 03 Jul 2017 21:05:00 -0000 [thread overview]
Message-ID: <604C3764-9C64-4E7F-9AB6-027D49038E55@adacore.com> (raw)
In-Reply-To: <orpodp5hwg.fsf@lxoliva.fsfla.org>
Hi Alex,
(Back from a few days away)
> On 27 Jun 2017, at 21:50, Alexandre Oliva <aoliva@redhat.com> wrote:
>
>> I don't quite understand this: we're using the same prerequisite as target
>> libraries, e.g. all-target-libstdc++-v3 or all-target-libbacktrace
>
> Not quite. Target libraries have deps on e.g. target-libgcc, look below
> the following comments in Makefile.in:
>
> # Dependencies for target modules on other target modules are
> # described by lang_env_dependencies; the defaults apply to anything
> # not mentioned there.
>
> plus, maybe-configure*-target-libgcc depend on maybe-all*-gcc (see above
> those comments). The precise deps vary per bootstrap level, or
> non-bootstrap.
>
> But after the proposed patch there are no such deps for libcc1 in the
> bootstrap case, so we might very well attempt to build libcc1 in
> parallel with gcc. We shouldn't do that.
>
> But then, it all works out because we only build all-host after
> bootstrap is complete; all-stage* doesn't depend on libcc1 at all.
I think I see.
[...]
> So, would you like to give the automatic figuring out of
> non-bootstrap-on-bootstrap deps in dependencies, and guard them between
> @if gcc-no-bootstrap and @endif (then both configure- and all- libcc1
> deps would be adjusted this way)? (I'm not saying it should be trivial
> to do or anything like that; I'm not all that familiar with it and I'd
> have to figure it out myself if I were to do it, but I think that would
> be better than adding yet another means of introducing dependencies,
> while leaving another risky dep in place)
I'm willing to study this more and see what can be done
to improve things further. There are still a few details I don't
quite grasp so it'll just take a bit of time.
Thanks a lot for the additional set of extensive comments!
With Kind Regards,
Olivier
next prev parent reply other threads:[~2017-07-03 21:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 12:58 Olivier Hainque
2017-06-14 11:39 ` Nathan Sidwell
2017-06-14 21:11 ` Olivier Hainque
2017-06-15 12:03 ` Nathan Sidwell
2017-06-15 12:29 ` Olivier Hainque
2017-06-22 12:13 ` Alexandre Oliva
2017-06-26 7:41 ` Olivier Hainque
2017-06-27 16:32 ` Olivier Hainque
2017-06-27 19:53 ` Alexandre Oliva
2017-07-03 21:05 ` Olivier Hainque [this message]
2018-06-03 19:13 ` Alexandre Oliva
2018-06-12 2:50 ` Alexandre Oliva
2018-06-12 8:57 ` Olivier Hainque
2018-06-12 15:31 ` Jeff Law
2018-06-26 5:39 ` Alexandre Oliva
2018-06-27 19:53 ` Olivier Hainque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604C3764-9C64-4E7F-9AB6-027D49038E55@adacore.com \
--to=hainque@adacore.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=roche@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).