From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46952 invoked by alias); 3 Jul 2017 21:05:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46940 invoked by uid 89); 3 Jul 2017 21:05:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Back, risky, Alexandre, alexandre X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jul 2017 21:05:23 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id C7CBF81365; Mon, 3 Jul 2017 23:05:21 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aKb50HIiFgoK; Mon, 3 Jul 2017 23:05:21 +0200 (CEST) Received: from [192.168.0.12] (bny92-4-82-228-126-192.fbx.proxad.net [82.228.126.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 8632A81363; Mon, 3 Jul 2017 23:05:21 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: fix libcc1 dependencies in toplevel Makefile From: Olivier Hainque In-Reply-To: Date: Mon, 03 Jul 2017 21:05:00 -0000 Cc: GCC Patches , Nicolas Roche Content-Transfer-Encoding: 7bit Message-Id: <604C3764-9C64-4E7F-9AB6-027D49038E55@adacore.com> References: To: Alexandre Oliva X-SW-Source: 2017-07/txt/msg00147.txt.bz2 Hi Alex, (Back from a few days away) > On 27 Jun 2017, at 21:50, Alexandre Oliva wrote: > >> I don't quite understand this: we're using the same prerequisite as target >> libraries, e.g. all-target-libstdc++-v3 or all-target-libbacktrace > > Not quite. Target libraries have deps on e.g. target-libgcc, look below > the following comments in Makefile.in: > > # Dependencies for target modules on other target modules are > # described by lang_env_dependencies; the defaults apply to anything > # not mentioned there. > > plus, maybe-configure*-target-libgcc depend on maybe-all*-gcc (see above > those comments). The precise deps vary per bootstrap level, or > non-bootstrap. > > But after the proposed patch there are no such deps for libcc1 in the > bootstrap case, so we might very well attempt to build libcc1 in > parallel with gcc. We shouldn't do that. > > But then, it all works out because we only build all-host after > bootstrap is complete; all-stage* doesn't depend on libcc1 at all. I think I see. [...] > So, would you like to give the automatic figuring out of > non-bootstrap-on-bootstrap deps in dependencies, and guard them between > @if gcc-no-bootstrap and @endif (then both configure- and all- libcc1 > deps would be adjusted this way)? (I'm not saying it should be trivial > to do or anything like that; I'm not all that familiar with it and I'd > have to figure it out myself if I were to do it, but I think that would > be better than adding yet another means of introducing dependencies, > while leaving another risky dep in place) I'm willing to study this more and see what can be done to improve things further. There are still a few details I don't quite grasp so it'll just take a bit of time. Thanks a lot for the additional set of extensive comments! With Kind Regards, Olivier