From: Jason Merrill <jason@redhat.com>
To: Nathan Sidwell <nathan@acm.org>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PR c++/86610] lambda captures in templates
Date: Wed, 16 Jan 2019 22:32:00 -0000 [thread overview]
Message-ID: <6077ac57-e237-b80d-8e47-76156dd418d3@redhat.com> (raw)
In-Reply-To: <cb1d2107-6bc0-6b39-a933-685f6580ac05@acm.org>
On 1/16/19 4:48 PM, Nathan Sidwell wrote:
> This PR reports a bug where we select a non-const operator function and
> then apply it to a const object. That's happening because the
> expression 'c[0]' is not dependent, so we figure end up resolving it.
> But the lambda capture logic doesn't capture 'c' at that point and we
> have a non-const qualified 'c'. At instantiation time we do the capture
> and the by-value lambda results in const-qualified captures.
>
> Jason, the orginal test in process_outer_var_ref looked a little funky
> -- why not just processing_template_decl? That would satisfy what the
> comment says it checking. Anyway changing the test to check DECL's
> type-dependency makes the right things happen, and a bootstrap passes.
> Could you review please.
Hmm, I don't remember exactly my rationale for deferring captures within
a template, but if this doesn't obviously break anything it seems
reasonable. Go ahead.
Jason
next prev parent reply other threads:[~2019-01-16 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 21:48 Nathan Sidwell
2019-01-16 22:32 ` Jason Merrill [this message]
2019-01-22 22:25 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6077ac57-e237-b80d-8e47-76156dd418d3@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).