From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by sourceware.org (Postfix) with ESMTPS id 206233858C5F for ; Sat, 14 Oct 2023 21:47:03 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 206233858C5F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.244.62 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697320026; cv=pass; b=gIaJ04ShlXi1tHdXFXcoPSAYkdiMfL5O27tptgwHZad+ZX47/lWZ++6xDNRdTmwshPWqGoVwabTGMwmFrP3aO3UTmFLKY3njudOBKQqAI9biQvQwwzC6b+qAOFLFLfds2IJNlCtRKdvkdkgHTb4Jsq7XBbNaH0ugsjDLPjwky8U= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697320026; c=relaxed/simple; bh=yN7SwNjB6X/cIj137Eb97h5Obn6RVi0DH/u0zf6SFBQ=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=ORXLXzs4FtfDZPlIc+5I45xZEiVeDZZa+sFFX0jaJPn/ixqX3BbAko12b3H2oO5J8XKwEH1Jd1KBISO7svflDGydzZPhAJSOq30chCQJQzIGdhkvdvRbjsqcaAOj4w68pDYKGHmFKQ5Cwy69R3ImN2xjtOQSsqzO4l2yfeYNVoc= ARC-Authentication-Results: i=2; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 206233858C5F Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqfcF7fnWQhYKs3jzr0wIcis1syWqu54yyDkYG+dzf4gVI4GPa7Vt+TEVAhU+GC7029tvVd0jtaQDkwCSGCLwUEcT1ZxCe3s9Z6klUMWyzsUSUs9EKLAFv8zR19+5nAf1AacsKfn/Xqzh321eBrLb3HBn1xMyoqOLNuOvKVf7vM4OX20EiQ6bUdREBcD1HC2xCqmbeXrXxqNUs2jZyWKaIVYF8NenLQSwEIpuUxc2qTAb1gPVQMLlOOb2thw8q6WeuPY6ZNe7cFdSp6yokBAABAWdiKMGqO0F7Lkb/nFm1I/qhFaZ5yaKtegE/r7qiE0ruQoYNOaC43UUIiy+VI6vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s+vij+wct3hIJWFoyL7DvelC40mNgxNwJ5EmHtpaZpM=; b=l4uLjF2Vh7X6JiO2S+72j2mlCLPbT46C3vkruZsWvAZIYDWi+XJonU3///2GcXmMG8j/51cibIPHQXPmT/U4RpuNo9X4bOKx8fD0FhzRBIxxBTdZVZvYamTBav7lwG7B71l2KKfWbi7OkWAO2W0wFfq9BXZzE+SfCzv8gUMqXLK3dHY6TaHL7Rk0rIAHNcCpVItEvfRsM0V979xWriAB0ihkpt+xoaAcJfL9FawTLHFQQf4fRdV1a0sVsEJEM1ejnf16SNZX0hTH13e2x5+xI91hcAe1sEv1RxIEEQdmdqnikvepqsWJvL+Zk453IbKS2c+j3Uryfohwf+FP0GMmHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s+vij+wct3hIJWFoyL7DvelC40mNgxNwJ5EmHtpaZpM=; b=kk3uZkjkaGX8P8AvQ40joryBBDXOebmvaFY8bsZpKT0UGMJKy8gV6QNoMDzjOWHhr+U5LdTx0ws6i8r9pJ8VLryTQDCy+Rx65gsju+pw0oSoZb/qzXuMfd5rWNRz5Atgg2sXBZ/T6scUAZNKtw6E8USdZItZZM+ZXNjHm4tU4heQZ7XQS9a0DlTXlpm20NMlgYBvH/ep1EOvsXx6e7cgH2mTnEizEYGdRWZJFXLYUolMlx4pNoUcU0d0G8MKfsFrFnJcofNcX9LSKT0HP+LRWDImWhul2RbY3JAO9F4NIiHrKHVL7/zbZzXT6/Ta+AW5U6jIODA+kQFunmTr14uWpw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from CH2PR07MB7222.namprd07.prod.outlook.com (2603:10b6:610:ab::21) by PH7PR07MB9367.namprd07.prod.outlook.com (2603:10b6:510:15e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.30; Sat, 14 Oct 2023 21:46:59 +0000 Received: from CH2PR07MB7222.namprd07.prod.outlook.com ([fe80::3368:bb2d:b2b2:855d]) by CH2PR07MB7222.namprd07.prod.outlook.com ([fe80::3368:bb2d:b2b2:855d%6]) with mapi id 15.20.6863.032; Sat, 14 Oct 2023 21:46:58 +0000 Message-ID: <6080749f-12c5-5e0a-aa59-fd084c00bea4@siemens.com> Date: Sat, 14 Oct 2023 15:46:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [patch] libgomp.texi: Update "Enabling OpenMP" Content-Language: en-US To: Tobias Burnus , gcc-patches , Sandra Loosemore , Jakub Jelinek References: <507d6d48-1ca1-411a-a95d-45adb7a8f446@codesourcery.com> From: Sandra Loosemore In-Reply-To: <507d6d48-1ca1-411a-a95d-45adb7a8f446@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR05CA0005.namprd05.prod.outlook.com (2603:10b6:a03:c0::18) To CH2PR07MB7222.namprd07.prod.outlook.com (2603:10b6:610:ab::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR07MB7222:EE_|PH7PR07MB9367:EE_ X-MS-Office365-Filtering-Correlation-Id: 6420281d-7dfa-4f59-98ed-08dbccff16d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Me8rBgpHLjor8Q0pdr4+QshVRHMawxaCla37uMX8cv3sM+BxHORPJD0pAYPXYlZkTFVrEq/cYz1jGet0XZNBt4iCEF9xU+HpuOWQ//wUczBvgbalW9Ve6WM3wMThTgwolroM9KFO5udlrq9at2JxMQ1mqyeiAFbtUhxg/fvIF3xiRdiMoGKCLXXFFY8iz1fqz+m09GbHp03dsdwhr8qCqMBdGZYu3ZDBwtJwy2nr2q+Eo+s2PwCgDcs0jpDozralODxWiACigu6jzMb5fIsDx5+0f11gcfizLi+aMKzgqf1XK4KnPIIOBBf2rBOzg2ktjKSxlIUSXdSCO374uckT+YUjf4q6TOLcQ83GihgSiueWqjN1h9DB2nGI9LUpPeVQ2Ucr/oNf4NPf0bWGUlZPYYQDc2/5yE8xBnjU5lXjZMdHz34RlKEMStCMQbOoUgFluh7MXcUzVfKuYSE5I6qR6eF354GZfxkTMiUGctwea5ckgLocTnmM0JQE9UnqU2M+Ald5mL+BGYgSmY+l1uuN31JTusNOjH1oDnRiUWseRWELOo0DtILNehz3FbvqYzepT35RzoT99rrXr90vNPSnBv5oGptK4lfLXc8K4PE/W2iHOt2/EQIuRDABMbeK4XpPZHv8mzGbjAUttMkbLO6S5w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR07MB7222.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(366004)(39850400004)(376002)(136003)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(31696002)(86362001)(36756003)(41300700001)(66476007)(8676002)(66946007)(8936002)(66556008)(316002)(2616005)(2906002)(110136005)(44832011)(83380400001)(6506007)(966005)(6486002)(53546011)(6666004)(478600001)(5660300002)(31686004)(82960400001)(6512007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzhZTXp5UUFnR0hLUXVVNjZUVlI5NnpTWWJwTjJCdVBoRWhaZFY5VnRMY0py?= =?utf-8?B?SkFzb3h3N3dxNXY0eno5YzYxWnNVT0VoeDBhLzdQWmZrd3ZKakZaY2lQSnUr?= =?utf-8?B?ZWw0R0tsNDQ5cklWUkcrc0JyVmR5VXJ6ZlBBaDhkZnFPc0g1dm4zNC9ldHZC?= =?utf-8?B?T005Tzg0c3ptRU0vOWIyQW1BaDZTcnFkaHVJb1FXaEJaVExCbTB2Szd6ZTRy?= =?utf-8?B?Ym45UWlWNXJETFJKbWM3SXJBVGVyTjdoQXJqelFYUm5IUXZRbGJpYjdUa2N0?= =?utf-8?B?WmR4QVdsMThZTk1uSVJxcjJScnVocDJJaWJHeWxtOWhUUmFGQUZIYlFncWFO?= =?utf-8?B?U3YzQUdqUzFpSUtYUTd4WTRVTTlJTE01cFg3WktBMkJiWXByMS9qWnd3U3d2?= =?utf-8?B?dUEwV3BKanlJTXg0eTZkcU1zWHVZVnh1VGFOVmtxaFNKc3B1OU1kdWlMR1FF?= =?utf-8?B?L05DWDRRU2tzaXNSelNzN3IvNW9vbVgvSExhOFZ3cEwrTHo2SmdzaDhVR0NU?= =?utf-8?B?MFZLNjFMRCtRSDM3ODV4QWdNTVdaTEhGNUpMNmRCN2hnaE8vU2l5VUhrME1D?= =?utf-8?B?em15NEpDVnR0bmZLZjVDYWk2eE9wWnpWNzVEbjJYN0ZlWEprL1hieVJIZXdi?= =?utf-8?B?WC9zK0dXTjg2eXJla3lXb2h1N0duZGJxRGY3VkpZQmRyZURXZXRBblhFNUJO?= =?utf-8?B?a05BdHhOTG9vYW0wTlA3dllJMThHMkRkUWJJUDJmdkRGTW5pTmhhamVWbWpR?= =?utf-8?B?ODU2RXlmZS9mTFA0NDRQbTVBci9rK1NibTBqUUt4SUJCekhEaVV4ZE5KZVVP?= =?utf-8?B?SG1zcHcvUlBmb29xQkxIWHlUM1RYYkJIcXlUWE4wcjdCeU85S2lIVHFGL0tQ?= =?utf-8?B?SzIvbnJOMW1VN2drUEU0ZnBQbURkTnZ4OTFSVWNkbWQ4S2dEUTlIQlFBbGJD?= =?utf-8?B?OWlwb3UwcG1yQ0FWRzF0a0hheXJ2dDFwdUE3YURkRFo0UnE3VzZBZE93U0ZX?= =?utf-8?B?aWdpU0diQ0oybE1sN0xqUEpQZ29qbldybkZBM1VTL29RTU8rWUwvam1oaHpO?= =?utf-8?B?WXdWTkdKNnhnVi9Nb0VZZHNId1lBcG4rWEtxTFBoc0s2SEhIWGk1aGMwUlcw?= =?utf-8?B?TDdHeTVEUEY1NklmN1Vlc3hkN1p0Ui9BSHBqY3Rxb3NrbGFvWkFvRlhNcGFW?= =?utf-8?B?R1lBT25NR2tXdXBkd0dkZmdWYWIxV3diOWd3NXc1d1IwQzNPYVVtYW0wZEx1?= =?utf-8?B?SGk1bG9zMGdjTkp0cHR0NDlGVHhyNGtrRzNoWlg3d2FNdmlLOEU2U1JVVHpM?= =?utf-8?B?U1NpL2lQQ254TjZoUVpmVXRtN2JyNlNmOVNTRnFNWDhYQzdoNklNK2hWMTlI?= =?utf-8?B?K2daZ284TTd3SDVwblpUS2dZWHBDZk1tdHFleE5NV3JLRngxUlp2WW1zak5L?= =?utf-8?B?NWFaZVhLbTl4eEwrTTVWUzd6aWVScmN4STNXRktUdmhhOU5UaEg3TlNGb1hp?= =?utf-8?B?VTV0K2E4T2NYVGNkMEt2TU5aNGRsUzdDdWh1N3gvdUU1RGVBVXF2M2tYSmhn?= =?utf-8?B?dWEwaTBNQVJFSlB3Y2hRaVVuN3RYYmpLcDMvMUtOYUFxVmkrK2dMZXNmYW1N?= =?utf-8?B?a2tYbnF4RWM2U0tzd001OVVDTTlyV2JIekxxSzRhQjNaTmdMa2MrczVPdk1U?= =?utf-8?B?WTUydC81N2VHQ3RxUGl5V3puOFhKWHZOamNCZzdSdHdkTysrczFRNVVHVlJv?= =?utf-8?B?cGQzd25tV1IxSUlLaWlONTBWVy8wK3lBUGRYK3lNemdrbzlmbmtTNms1dlY4?= =?utf-8?B?SUNKN0FVemw5b0J0c3pQUVliZlRvcUlnRVlMWVZGN2JCMU5OS2dxemNSVXho?= =?utf-8?B?M3hHUEhFc0lHOXhTQmNQWGV5VXlVc3V0ZlpBNVYzWnNnTDEvYmFlN081Y01r?= =?utf-8?B?YTVxWnJMeHVqVDdMdHFMVHlxUE45RDc1YVFYV0pYd0RQQWJUc3ZGdWN5Z1pn?= =?utf-8?B?TjZQYnk3bzB3U2xLYzB5MnlLSGFycE12NnhFLzdaNkU3d293bUZCRnUvQjFk?= =?utf-8?B?cEN5RFVDWDc2QTJVVjdJSVpXUVg3VmxLSGRjN1A2eStwbEE4bWh2bkYzTTBs?= =?utf-8?B?SzlPbVBNUGNFNWFCdzJNWDBZc2hJUkhxb2xKMDdzRjZOa096QzdFaWRjdktl?= =?utf-8?B?enVJelFYSEUzYStjTWxmeG9CajlmTUt5cjVTeVQrRDlraUJxTGJFdVdFcUtH?= =?utf-8?B?WGx6RXFGVzlUc25nOGdOcGtZd25BPT0=?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6420281d-7dfa-4f59-98ed-08dbccff16d5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR07MB7222.namprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2023 21:46:58.2195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BHFtXBhDBTCScchE+p0hIYCdDro/VGKNoBi0ukQnN0F/dTkeXmoWDvXSyRpERRCFM+87TEAjYdbawcggBxbzPlBEti24RyvmsQc1iFE7HFs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR07MB9367 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/14/23 13:43, Tobias Burnus wrote: > When browsing libgomp doc, I came across > https://gcc.gnu.org/onlinedocs/libgomp/Enabling-OpenMP.html>> > First, I found especially the Fortran part difficult to read. Secondly, > it missed the C++ attribute syntax. And I also missed a reference to > -fopenmp-simd. > > The attached patch tries to improve this. Note that it talks about C and > C++ attributes, even though C23's [[omp::]] support has not yet landed. > (But is expected very soon.) Is somebody actively working on implementing that, and expecting to get it in before Stage 1 closes? I don't think we should document features that don't exist yet. This syntax for C also isn't even in the draft OpenMP 6.0 document so at this point it's just a hypothetical extension. To me it seems a better use of resources to finish implementing things that are actually in earlier versions of the OpenMP standard, and to fill in documentation for features that are actually implemented. Other than that... > diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi > index 526d1be2955..d8126f96fe4 100644 > --- a/libgomp/libgomp.texi > +++ b/libgomp/libgomp.texi > @@ -136,15 +136,22 @@ changed to GNU Offloading and Multi Processing Runtime Library. > @node Enabling OpenMP > @chapter Enabling OpenMP > > -To activate the OpenMP extensions for C/C++ and Fortran, the compile-time > -flag @command{-fopenmp} must be specified. This enables the OpenMP directive > -@code{#pragma omp} in C/C++ and @code{!$omp} directives in free form, > -@code{c$omp}, @code{*$omp} and @code{!$omp} directives in fixed form, > -@code{!$} conditional compilation sentinels in free form and @code{c$}, > -@code{*$} and @code{!$} sentinels in fixed form, for Fortran. The flag also > -arranges for automatic linking of the OpenMP runtime library > +To activate the OpenMP extensions for C/C++ and Fortran, the compile-time > +flag @command{-fopenmp} must be specified. For C and C++, this enables Use @option markup on options, not @command. > +the handling of the OpenMP directives using @code{#pragma omp} and the > +@code{[[omp::directive(...)]]}, @code{[[omp::sequence(...)]]} and > +@code{[[omp::decl(...)]]} attributes. For Fortran, it enables for > +free source form the @code{!$omp} sentinel for directives and the > +@code{!$} conditional compilation sentinel and for fixed source form the > +@code{c$omp}, @code{*$omp} and @code{!$omp} sentinels for directives and > +the @code{c$}, @code{*$} and @code{!$} conditional compilation sentinels. > +The flag also arranges for automatic linking of the OpenMP runtime library > (@ref{Runtime Library Routines}). And I think all those @code markups should be @samp instead, or you could just replace this whole blurb with something like "This flag enables recognition of the directive syntax documented in the OpenMP specification, and also arranges for automatic linking..." > +The @command{-fopenmp-simd} flag can be used to enable a subset of This should be @option too. > +OpenMP directives, which do not require the linking of neither the s/, which/ that/ s/neither/either/ > +OpenMP runtime library nor the POSIX threads library. > + > A complete description of all OpenMP directives may be found in the > @uref{https://www.openmp.org, OpenMP Application Program Interface} manuals. > See also @ref{OpenMP Implementation Status}. -Sandra