public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX Coudert <fxcoudert@gmail.com>
To: Tobias Burnus <burnus@net-b.de>
Cc: Jerry DeLisle <jvdelisle@verizon.net>,
	 "'fortran@gcc.gnu.org'" <fortran@gcc.gnu.org>,
	 gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR32987 - Allow TAB in FORMAT statements as extension and warn with -std=f*
Date: Thu, 09 Aug 2007 21:41:00 -0000	[thread overview]
Message-ID: <6089B186-BF3D-4D7A-BADA-3DBDABC172E9@gmail.com> (raw)
In-Reply-To: <46B4E1BC.9060001@net-b.de>

:REVIEWMAIL:

> 2007-08-04  Tobias Burnus  <burnus@net-b.de>
>
> 	PR fortran/32987
> 	* io.c (format_token): Add FMT_ERROR.
> 	(next_char_not_space): Print error/warning when
> 	'\t' are used in format specifications.
> 	(format_lex): Propagate error.
> 	(check_format): Ditto.

It looks OK.

> +  c = next_char_not_space (&error);
> +  if (error)
> +    return FMT_ERROR;

We now have to perform a check after each next_char_not_space; this  
seems to me rather heavy (in term of code simplicity/readability) for  
such an extension. Maybe you can think a something that would be less  
heavy (a macro?). Otherwise, it's OK, as I don't really have a good  
suggestion to implement instead :)

FX

  reply	other threads:[~2007-08-09 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-04 17:37 Tobias Burnus
2007-08-04 18:08 ` Jerry DeLisle
2007-08-04 20:30   ` Tobias Burnus
2007-08-09 21:41     ` FX Coudert [this message]
2007-08-09 22:05       ` Tobias Burnus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6089B186-BF3D-4D7A-BADA-3DBDABC172E9@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=burnus@net-b.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jvdelisle@verizon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).