From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 650553858C50 for ; Mon, 18 Sep 2023 17:44:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 650553858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1c3cbfa40d6so43023825ad.1 for ; Mon, 18 Sep 2023 10:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695059059; x=1695663859; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OijDbltqmFq9SBaDEu+ruBqxQxs60QyOxo/kIbQju9c=; b=hNJuKM3G7ef7Ol2Sj/Juv/1aCmIeUHrqdAqMTcb0b53fhKwLnqj0OcVfsK+kWT9cT4 FqH9OySG3X5RPySYDbnZzYh0C8Oso9EwYlZamhLc39e63BdhHEmjeTIPzlEGexGmJ5Sl dgyhcUo+abjP1uWUOAlIP5m1J73bqGs5RAwf6sSjRDjwQ9+bX6w2KA/YLr9McOv1BfGU TuWYh5npVMJowySi6WSbnUAf4b+uZmlt1SDwSuTMVMQHhBlwC56A3+yt7+/Tt38aSzcx BxJCvnva5bAcLHtqQHGw24IbGWARN8Rt8ksQX9tXYeSPe/teoDGgNY3rXOsnlJxeeui8 4X4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695059059; x=1695663859; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OijDbltqmFq9SBaDEu+ruBqxQxs60QyOxo/kIbQju9c=; b=DhqITqFk0q9HjzTZBNYF3pRySLi2YrmI8H+ooQKuLiwX2GFeAFfNAITXkWMcWlwJ3L YzKwYX3/xS7Mn2KHloXCZk1+phjtvY8tw8/xCcI5wGUPZT0+FFn4IHssJNv0tc6wVCJU dduBV9WKBw91vPhbaefwcfvGIe1gZNhXWunHyBsfOAVr1xVfuidEEE/QDSoDyJq+0413 q2Hw1DcB3jzQ7zh8A8l+QqDa4CBoLHNWNqNoSKA00dgkm0GT1vG0RU1DIieoBJBjso+q QkOtmsjYtAnyejCQzdy6KSiwES8J0zjstvwP9RYjYC6DirJlg/n0n1wKucajsqMw1Q9n Lbmw== X-Gm-Message-State: AOJu0YzpqqG0aMwGsj3phFKutQ3PsJ9ygGjBSijjFunBvbrEAWmleEki d4JYH3Y+n0utJla2dr8QdqgNjtUWWRTHyg== X-Google-Smtp-Source: AGHT+IF8awUHkiRk/BNW8oIb3xo8bUB2BDrq0c1uivWHSePnTEQUiGGP/gWCCAtk3xZov5OCzoOJHA== X-Received: by 2002:a17:902:db0b:b0:1b9:de67:286f with SMTP id m11-20020a170902db0b00b001b9de67286fmr12217975plx.49.1695059059177; Mon, 18 Sep 2023 10:44:19 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id t17-20020a1709028c9100b001bdb85291casm8523675plo.208.2023.09.18.10.44.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 10:44:18 -0700 (PDT) Message-ID: <60aafd5d-cb7a-4a81-b0f2-e25990614877@gmail.com> Date: Mon, 18 Sep 2023 11:44:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] RISC-V: Bugfix for scalar move with merged operand Content-Language: en-US To: Robin Dapp , pan2.li@intel.com, gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, yanzhang.wang@intel.com, kito.cheng@gmail.com References: <20230917074234.1541088-1-pan2.li@intel.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/18/23 04:00, Robin Dapp wrote: >> I must be missing something. Doesn't insn 10 broadcast the immediate >> 0x2 to both elements of r142?!? What am I missing? > It is indeed a bit misleading. The difference is in the mask which > is not displayed in the short form. So we actually use a vec_dup > for a single-element move, essentially a masked vec_dup where only > one element is masked in. Ah :-) > > The problem was that the original doesn't use a merging "vec_set" > but a "destructive" one where the other elements get ignored. > > The fix is OK IMHO. Agreed. jeff