From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id B0EAD3857C51 for ; Fri, 18 Nov 2022 19:42:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0EAD3857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x629.google.com with SMTP id g10so5423834plo.11 for ; Fri, 18 Nov 2022 11:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eOE2dQCfz78oST1fRoZjrQWaEJreUBJGTmMbM69j2oA=; b=bb6jSnITRE4swafa477e/ol8efgHLU/ZY0GEZ9g8ET//p3fYg3nSv3jmwAOxPicYMS +JNgv0STW3Mw3a1f6GYqIacW4nxGCq66loawPHx7UFoe0+2oC/sfsdRGqA/1xhZtBb9x H49rMsBoM/Ft2XjbTxd4M2Cf7dGyezdKOiZ11b7GptjS6OJE6AGcI6SJYaaqB5lTWZFI tyxus4bJ8mxw2iZHaUiEtBFp8zH2I4SUboN5Ls0lNh+2OUqwr06OBC+3bf51/5YJKcQ9 XlCQd8GsvKn0NKZfpabFDGKLEvtaJYx6O2fvOdVaPqKwZnHIQYLLR0NX27GEfN/JHrNc +Drw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eOE2dQCfz78oST1fRoZjrQWaEJreUBJGTmMbM69j2oA=; b=iSQk1pCM/vWUZv+sUQ8UAQ1UhluQkP9J0RI4wLC6u9ZKcMUimDgLOvtm6dazZuNSdu w8ltzhra+g7dQOCMOXTOAvQwAYwilbVoETp456xu/+et8FbFL8CTsp9wAhvAWopkVqAM RRZvFFfNnN/I2TV3efhjF1YVi6U3nwHO1doCAV4HcTqvJ6j8gSyo2xGAuVrGcjhLzY8U C5sDhmUYZlGP9qjMxv1l8WhPqecqDuvX0ClIo13kR718FW/LdmUPPe7VZP9k725clYra Zr5/8DTSjNBKPl89K/WX+ojnPnAOoqZWp6eJi4EwMHnvjNWUc6XZuhrfgr+f460xUF/I Malg== X-Gm-Message-State: ANoB5plf9U4jZeU2uWx745ojPswRFi0mxdZ64D0PHvrFHDC05v077s4O uFd0MJ7GRxA48Au9ktxL4a0koRpTftI= X-Google-Smtp-Source: AA0mqf5JgtdH6G9/7KKJyYopHi1JLDUksFvJCpVwc23DDyx6A8z2nd8NLSfHydp+9/wpweY+Xamdbw== X-Received: by 2002:a17:90a:d50c:b0:218:722e:cac7 with SMTP id t12-20020a17090ad50c00b00218722ecac7mr9337753pju.47.1668800532610; Fri, 18 Nov 2022 11:42:12 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id x3-20020aa78f03000000b00561b02e3118sm3534970pfr.106.2022.11.18.11.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 11:42:11 -0800 (PST) Message-ID: <60cd8d77-8f33-bf5c-6316-f035f12c53d8@gmail.com> Date: Fri, 18 Nov 2022 12:42:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] genmultilib: Add sanity check Content-Language: en-US To: Christophe Lyon , gcc-patches@gcc.gnu.org References: <5fd04651-5fab-e1d1-ea01-9fc39a1cb207@arm.com> <20221103095259.4095606-1-christophe.lyon@arm.com> From: Jeff Law In-Reply-To: <20221103095259.4095606-1-christophe.lyon@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/3/22 03:52, Christophe Lyon via Gcc-patches wrote: > When a list of dirnames is provided to genmultilib, its length is > expected to match the number of options. If this is not the case, the > build fails later for reasons not obviously related to this mistake. > This patch adds a sanity check to help diagnose such cases. > > Tested by adding an option to t-aarch64 and no corresponding dirname, > with both bash and dash. > > v2: do not use arrays (bash feature). > > OK for trunk? > > gcc/ChangeLog: > > * genmultilib: Add sanity check. OK.  It should be interesting to see if it trips. jeff