From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id ABE9C3857C43 for ; Mon, 1 Aug 2022 02:03:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ABE9C3857C43 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2711a3Pq024527; Mon, 1 Aug 2022 02:03:37 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hnxxwyjxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Aug 2022 02:03:36 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2711tQ7X011559; Mon, 1 Aug 2022 02:03:35 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hnxxwyjww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Aug 2022 02:03:35 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2711qMju009791; Mon, 1 Aug 2022 02:03:33 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma02fra.de.ibm.com with ESMTP id 3hmv98sj6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Aug 2022 02:03:33 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27123TJS29753696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 1 Aug 2022 02:03:29 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC2864C040; Mon, 1 Aug 2022 02:03:29 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E1714C044; Mon, 1 Aug 2022 02:03:28 +0000 (GMT) Received: from [9.200.45.162] (unknown [9.200.45.162]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 1 Aug 2022 02:03:27 +0000 (GMT) Message-ID: <60e33434-d830-d580-2cb7-f7882d2d1b21@linux.ibm.com> Date: Mon, 1 Aug 2022 10:03:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Ping^2 [PATCH v6, rs6000] Implemented f[min/max]_optab by xs[min/max]dp [PR103605] Content-Language: en-US From: HAO CHEN GUI To: gcc-patches Cc: Segher Boessenkool , David , "Kewen.Lin" , Peter Bergner References: <504feaec-9e0c-8768-9adf-435e877dedc2@linux.ibm.com> In-Reply-To: <504feaec-9e0c-8768-9adf-435e877dedc2@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: O0jYSVLivp5OluRteVj3PhZimjfQ7hJZ X-Proofpoint-ORIG-GUID: KtApuDsprWTHgneg0eVYcmARO698GjIB Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-31_20,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 spamscore=0 impostorscore=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208010010 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 02:03:44 -0000 Hi, Gentle ping this: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597158.html Thanks. On 4/7/2022 下午 2:32, HAO CHEN GUI wrote: > Hi, > Gentle ping this: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597158.html > Thanks. > > On 24/6/2022 上午 10:02, HAO CHEN GUI wrote: >> Hi, >> This patch implements optab f[min/max]_optab by xs[min/max]dp on rs6000. >> Tests show that outputs of xs[min/max]dp are consistent with the standard >> of C99 fmin/max. >> >> This patch also binds __builtin_vsx_xs[min/max]dp to fmin/max instead >> of smin/max. So the builtins always generate xs[min/max]dp on all >> platforms. >> >> Bootstrapped and tested on ppc64 Linux BE and LE with no regressions. >> Is this okay for trunk? Any recommendations? Thanks a lot. >> >> ChangeLog >> 2022-06-24 Haochen Gui >> >> gcc/ >> PR target/103605 >> * config/rs6000/rs6000.md (FMINMAX): New. >> (minmax_op): New. >> (f3): New pattern by UNSPEC_FMAX and UNSPEC_FMIN. >> * config/rs6000/rs6000-builtins.def (__builtin_vsx_xsmaxdp): Set >> pattern to fmaxdf3. >> (__builtin_vsx_xsmindp): Set pattern to fmindf3. >> >> gcc/testsuite/ >> PR target/103605 >> * gcc.dg/powerpc/pr103605.c: New. >> >> >> patch.diff >> diff --git a/gcc/config/rs6000/rs6000-builtins.def b/gcc/config/rs6000/rs6000-builtins.def >> index f4a9f24bcc5..8b735493b40 100644 >> --- a/gcc/config/rs6000/rs6000-builtins.def >> +++ b/gcc/config/rs6000/rs6000-builtins.def >> @@ -1613,10 +1613,10 @@ >> XSCVSPDP vsx_xscvspdp {} >> >> const double __builtin_vsx_xsmaxdp (double, double); >> - XSMAXDP smaxdf3 {} >> + XSMAXDP fmaxdf3 {} >> >> const double __builtin_vsx_xsmindp (double, double); >> - XSMINDP smindf3 {} >> + XSMINDP fmindf3 {} >> >> const double __builtin_vsx_xsrdpi (double); >> XSRDPI vsx_xsrdpi {} >> diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md >> index bf85baa5370..ae0dd98f0f9 100644 >> --- a/gcc/config/rs6000/rs6000.md >> +++ b/gcc/config/rs6000/rs6000.md >> @@ -158,6 +158,8 @@ (define_c_enum "unspec" >> UNSPEC_HASHCHK >> UNSPEC_XXSPLTIDP_CONST >> UNSPEC_XXSPLTIW_CONST >> + UNSPEC_FMAX >> + UNSPEC_FMIN >> ]) >> >> ;; >> @@ -5341,6 +5343,22 @@ (define_insn_and_split "*s3_fpr" >> DONE; >> }) >> >> + >> +(define_int_iterator FMINMAX [UNSPEC_FMAX UNSPEC_FMIN]) >> + >> +(define_int_attr minmax_op [(UNSPEC_FMAX "max") >> + (UNSPEC_FMIN "min")]) >> + >> +(define_insn "f3" >> + [(set (match_operand:SFDF 0 "vsx_register_operand" "=wa") >> + (unspec:SFDF [(match_operand:SFDF 1 "vsx_register_operand" "wa") >> + (match_operand:SFDF 2 "vsx_register_operand" "wa")] >> + FMINMAX))] >> + "TARGET_VSX && !flag_finite_math_only" >> + "xsdp %x0,%x1,%x2" >> + [(set_attr "type" "fp")] >> +) >> + >> (define_expand "movcc" >> [(set (match_operand:GPR 0 "gpc_reg_operand") >> (if_then_else:GPR (match_operand 1 "comparison_operator") >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr103605.c b/gcc/testsuite/gcc.target/powerpc/pr103605.c >> new file mode 100644 >> index 00000000000..1c938d40e61 >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr103605.c >> @@ -0,0 +1,37 @@ >> +/* { dg-do compile } */ >> +/* { dg-require-effective-target powerpc_vsx_ok } */ >> +/* { dg-options "-O2 -mvsx" } */ >> +/* { dg-final { scan-assembler-times {\mxsmaxdp\M} 3 } } */ >> +/* { dg-final { scan-assembler-times {\mxsmindp\M} 3 } } */ >> + >> +#include >> + >> +double test1 (double d0, double d1) >> +{ >> + return fmin (d0, d1); >> +} >> + >> +float test2 (float d0, float d1) >> +{ >> + return fmin (d0, d1); >> +} >> + >> +double test3 (double d0, double d1) >> +{ >> + return fmax (d0, d1); >> +} >> + >> +float test4 (float d0, float d1) >> +{ >> + return fmax (d0, d1); >> +} >> + >> +double test5 (double d0, double d1) >> +{ >> + return __builtin_vsx_xsmindp (d0, d1); >> +} >> + >> +double test6 (double d0, double d1) >> +{ >> + return __builtin_vsx_xsmaxdp (d0, d1); >> +}