From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 209683855029 for ; Thu, 29 Jul 2021 12:42:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 209683855029 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16TCdrgl162718; Thu, 29 Jul 2021 08:42:30 -0400 Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a3uqj1xp9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Jul 2021 08:42:30 -0400 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16TCcmlw020972; Thu, 29 Jul 2021 12:42:29 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma05wdc.us.ibm.com with ESMTP id 3a2364ng2w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Jul 2021 12:42:29 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16TCgSUN50135334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Jul 2021 12:42:28 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4DB7CBE056; Thu, 29 Jul 2021 12:42:28 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 21972BE053; Thu, 29 Jul 2021 12:42:26 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.211.91.192]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 29 Jul 2021 12:42:26 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 42/55] rs6000: Handle gimple folding of target built-ins To: will schmidt , gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org References: <91c28178ab7912df2a6b8f8299ef6563a69781b5.1623941442.git.wschmidt@linux.ibm.com> From: Bill Schmidt Message-ID: <60e83e75-6c86-2c78-492b-1d56ac1857a6@linux.ibm.com> Date: Thu, 29 Jul 2021 07:42:26 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: iyBOEnRjXHJ2oGEJ2kYa4PBy4aRry9UV X-Proofpoint-GUID: iyBOEnRjXHJ2oGEJ2kYa4PBy4aRry9UV X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-29_10:2021-07-29, 2021-07-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107290081 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 12:42:33 -0000 On 7/28/21 4:21 PM, will schmidt wrote: > On Thu, 2021-06-17 at 10:19 -0500, Bill Schmidt via Gcc-patches wrote: > > > + /* Vector compares; EQ, NE, GE, GT, LE. */ > + case RS6000_BIF_VCMPEQUB: > + case RS6000_BIF_VCMPEQUH: > + case RS6000_BIF_VCMPEQUW: > + case RS6000_BIF_VCMPEQUD: > + fold_compare_helper (gsi, EQ_EXPR, stmt); > + return true; > + > + case RS6000_BIF_VCMPNEB: > + case RS6000_BIF_VCMPNEH: > + case RS6000_BIF_VCMPNEW: > + fold_compare_helper (gsi, NE_EXPR, stmt); > + return true; > + > Noting that entries for _CMPNET,_VCMPEQUT, etc are missing from this > version versus the non-new version of this function. > I believe thiswas/is deliberate and by design. > Same with entries for P10V_BUILTIN_CMPLE_1TI, etc below. Indeed not!  This is something I missed when new code was added after I posted the original patch series.  I'll reinstate the quadword compares.  Thanks for spotting this! Bill >