From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id DDB4D385AC3E for ; Fri, 3 Dec 2021 03:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDB4D385AC3E Received: by mail-pg1-x530.google.com with SMTP id s37so1681983pga.9 for ; Thu, 02 Dec 2021 19:18:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5scJjNIj/QgGjI2bxSS4zkrKgul02V2f6b43PvU9Q6I=; b=iBpFfvevPf5NO9RZmHiuA8ZFJmXqgLKmQf6zWv9qiv5lj1SfWi3aBg4kbDdlUdy11U YHNSSlR12Ml7/NO96TQ7fP+G+fCZejAmVm8tE99m3WsYRmG98Y/ILl3k8KWtdS+AmjP6 hxgjbGXE8KkAaycLFjNVvlKzZSZWdq8gBvDVCxiMt37LCBr+2KS3rxuK9lw/h8yo5Ip7 W3FsyRSGIxksr5mUIuN0tSoHcUwTAGqMTudDRxysgO/wQ9RUwD6wFqkB75fn8ZCF5nPo D5eP6VsqYEgbdbxLXGaiMTV8j6Q3wVQgZlvNoIe0RQKEUFrq4tvzUlqxP97W9ZnetskZ 3MQw== X-Gm-Message-State: AOAM530DsALJpeSVyBkqmCQgdj00ljZlvsBVTZA3vEeCKq6UClb1kd3L 2K1/jPCM15OEIE3MgYFFNow= X-Google-Smtp-Source: ABdhPJzIlRQNOW6DEHHgcLkAHCLtCqDrfDdgRpJk6vRILU/hV3N7pBF5dz8fSBuM1eUFlsJZFWrybQ== X-Received: by 2002:a63:83c1:: with SMTP id h184mr2661293pge.152.1638501526074; Thu, 02 Dec 2021 19:18:46 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id p3sm755681pjd.45.2021.12.02.19.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 19:18:45 -0800 (PST) Message-ID: <6149c497-e681-7f97-0a01-963431b681ce@gmail.com> Date: Thu, 2 Dec 2021 20:18:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 2/4] Add x86_64-linux support for off-stack trampolines Content-Language: en-US To: Maxim Blinov , gcc-patches@gcc.gnu.org Cc: iain@sandoe.co.uk, Andrew Burgess References: <20211113094525.96299-1-maxim.blinov@embecosm.com> <20211113094525.96299-2-maxim.blinov@embecosm.com> From: Jeff Law In-Reply-To: <20211113094525.96299-2-maxim.blinov@embecosm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 03:18:51 -0000 On 11/13/2021 2:45 AM, Maxim Blinov wrote: > Implement the __builtin_nested_func_ptr_{created,deleted} functions > for the x86_64-linux platform. This serves to exercise the > infrastructure added in libgcc (--enable-off-stack-trampolines) and > gcc (-foff-stack-trampolines) in supporting off-stack trampoline > generation, and is intended primarily for demonstration and debugging > purposes. > > Co-authored-by: Andrew Burgess > > libgcc/ChangeLog: > > * config/i386/heap-trampoline.c: New file: Implement off-stack > trampolines for x86_64. > * config/i386/t-heap-trampoline: Add rule to build > config/i386/heap-trampoline.c > * config.host (x86_64-*-linux*): Handle > --enable-off-stack-trampolines. > * configure.ac (--enable-off-stack-trampolines): Permit setting > for target x86_64-*-linux*. > * configure: Regenerate. I'd probably drop this.   I realize it's useful for testing purposes, but I'm not sure we want it in the tree. jeff