From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2045.outbound.protection.outlook.com [40.107.247.45]) by sourceware.org (Postfix) with ESMTPS id B47593858028 for ; Thu, 15 Jun 2023 08:15:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B47593858028 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f+iraSeBp1J/ASI4ZRgdR/RnEZndBPXRhIkGUDQ5DFkpapo66ulH1NmX2ybE+LjQFcMhrb2spr2lfZSFR4+AcSu2s6Os9Y/sRntqwnuDjWBMn4QyCEtTaKlVxnJRwIDjEVTejiyS82EJ1L8nqZYxlxzlupEX3lO5YpE4wT76uU2ki6g9bfJOC8SQ9sWTeF+Bb9F7gPfUJsUVtkV9K4fel+yeV0wo6kC/fTdPXz9WzEcMq2DqxLA54qGE5Bwu0UFCZ3eDNsiumWMIVP8UdpaBJBEz4Qx6xmBkcGRTJKUu/IXrQOBDbPUdB1gE1/wbYYKPeropKrmqbgQAqZ63jOAHMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0i224xdfJ3a0mAjPGv1QVqPIEvKIZFmZPZ7qg8UpQ5Y=; b=NPD/Z4iTDsAs+bRL5QeSCcTIVejdhPXTmMjdq7iKxTHGqtjZwka1r+RaHgxWIgsaE1ndjeSvAZsVV8hdlEOsy0HZae5j3hjpvMPSEvRC0cjxI7s/zxPLU4ZdBnq4nhkkCLTovLTvgQ/q3zB/H3qjQ4aSgTJ+VunnFArfRf6Q6Fxqcs7bmGoAj9czQAKZkUTIQD8q/Mr2aSLkJxd3smNnrFGs3UwOUMbHzBAauGDMkkLcgvQt+BG66GifRzg9a3/2Ul9UXtjkGzzSTfMXghpjeMarMTd0M+orkpUtAL6RqO0paOqxaUz2ZrWBtpoqyfrUqdm7BWk4wu6zQpoSli7ABQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0i224xdfJ3a0mAjPGv1QVqPIEvKIZFmZPZ7qg8UpQ5Y=; b=AN5dAWgtA+ruJLo/QNTdxHv41zBS2GYjDp0D4y8abzyXNq9G7VDAgvBmqoGBDAEJ6jfspOPN++cP9OnH+Ok8VxdCMsojohjvgbV9qhKUWJct91hWtIvb+Z9H1jf0eOScmN35YUVTewLvSArZBzZQGrljCZAxNfArh7DZ93OZLTTew/3uJtnyczFTujZg/aRHsYMZ5EHGEs7g/C/6pSJqEdDmLmXw6IFT6FWob7PeLQm/T6DejJFGzXy+YvJD7ST9Q/2HbS+OKzEsso3Pphpua1pQLRfA0tHDyXRSYTC3MNGO+eKD3zKZkXU7941QYrdci4OlwF7yll/ybQt9sjpQdA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6913.eurprd04.prod.outlook.com (2603:10a6:208:184::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Thu, 15 Jun 2023 08:15:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Thu, 15 Jun 2023 08:15:28 +0000 Message-ID: <614c258d-9168-a67e-eb51-00bb2060ded4@suse.com> Date: Thu, 15 Jun 2023 10:15:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] x86: correct and improve "*vec_dupv2di" Content-Language: en-US To: Hongtao Liu Cc: "gcc-patches@gcc.gnu.org" , Hongtao Liu , Kirill Yukhin , Uros Bizjak References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM0PR04MB6913:EE_ X-MS-Office365-Filtering-Correlation-Id: 71bc8de7-2f54-4264-c156-08db6d78ae19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pVVVcjt7mJudGgAsvLPxjaS1CHyAq3b9BXVThGQBzEiXplkT5z4O/JRKxyLysphiD+rSDzyIf+zwg46glBUfcvqagprv9qiGGTKAyt+sOO10NM5vSJl6RisaWEBHXSKoRi7SuI/4CKS3taftR+hcCEqpeoBNiv8TGnXOQ7TR45/ST2zwoBO4rK0UWacztWEbDK7eECtV2TBNNhyARojnuNimfAMQAmQLIZsE3VBapRy67nCwnkpyiVujG/OroZm74sPrCAQ6iUow5w6QM8tSbAHTF4fWO+egOrsig1yGZjQL14sxzxi2eSoSclNs9chdxu1zTdahAgrRuNrm92V2IYlKH9ljmmVf6bLu8DIVLwwe//kTkPh9AVyS4SPKCex1Hhxp8fWQZruII0vRzCLpua44WB5zkC4nmzwlCbjMcfTEEXt2ws5fx9MMdMHcofadds7bHMpSYffTagdQOHn8sGkoQzDdh+KXizFL2TfZ4yQMcrAa7s6ygi/LWZf5IdA++9IKe46CpagYMcKpdEEu1ml8/q61SKSZtZF/N3sXPD8FqV9II1BT3YBHTeU3pB33qvB4Ed/2KUozZIS115OJsbw6nRxt9DPRQkhy4dGauMtGTWwIqdB1miNabC6vZvSvmtOCxd2x+ZMZQT3ddgcUgg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199021)(31686004)(26005)(186003)(6512007)(5660300002)(6506007)(41300700001)(53546011)(36756003)(478600001)(86362001)(4326008)(8936002)(66946007)(2906002)(66476007)(2616005)(66556008)(54906003)(8676002)(316002)(6486002)(6916009)(38100700002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUpESkRlV296cVlaSFdaUHhUTGFUMTBabTJ5QUpWeFdpbHhOYitrQTlSZmlW?= =?utf-8?B?ZitpUlVQaWNhcGErMmFlN2FYMlBYWUZ4b1MrRURDYTdmYm42cnJuZWhxQVVX?= =?utf-8?B?RmJlUlA3L3ZHWVFNR1V6TnVkNkJHV0RPTE5LenB0b3B2cEtkOWFwMGVtQ2d3?= =?utf-8?B?MHFEWE1YTW04L0RYSHdaQS9jYUZHcXlodGQrMTNLYjh3WlBnSkEzOU5FZTJl?= =?utf-8?B?OEVTZDkvdWhvRy9BVEEzNlFhRy9DUmpDU2xMWVoxMFlMcnFOL0s1dmpOSktq?= =?utf-8?B?SXJldDVURjNSUTk1TVM1M05jMnRSRzQ0K2hWZnZ0REFrUVE2a0hwaG1DMlFX?= =?utf-8?B?K1htY1RoOWpxWnk3dndNZHFWVmQ1MzE2eHlqUkJvb1ZFblBBTGdHZHZVTExB?= =?utf-8?B?RXN3dVcwRVVoeGFNY2FxMUFHV0ZtTEVMS1B0VGJGcnpZRkdUaTdBT3pNMUJH?= =?utf-8?B?YVZKbnVDeVVnR0tmK3lSd3pQSmpHcDlXYUE0WkE1Qk91Y0crYjlsYWtxRUk1?= =?utf-8?B?Y0JncnA4SnUyc0JWemJsa1ROTldhQTYzeWwzU2VDUU9VYWpwd1pCa0hodUZu?= =?utf-8?B?NGgwQngzSnFVdk9qRzFjSjNqa2pMT1luajRGa01QYkNmMzcyNnFKUUVvU2Vy?= =?utf-8?B?dGt6QVlQL0tHQlZmeVlObnRWdnFuYUZyMEFtQ281bllpcUpSS3ZPNHpEeXln?= =?utf-8?B?L0ZUcFhsVEJLTnpPMEpBYjlibWsyb24rTVBXYlV3WXBXU3VwVC9ZaExkaGh5?= =?utf-8?B?c2FPRmxFMDExVUNWYkZ1YVRxYlRSNHRUMWpheHNTSko2M0hLQXozR2l4VHVV?= =?utf-8?B?WitoZnptL240ZnlXdFJVWUIwdnF4QjhkUmZIdHJrYUNqLzRpU3F1NkdMa1RR?= =?utf-8?B?T2t6Z01Tb0xTQitHQk82YS9kZExNTlE0eGcycUs5K25LVTlaSmlvYVltVWF3?= =?utf-8?B?T1lNK3dDYUhMSGY2WFdoUnNIY1Q5eHpBNUphWFhqUG92NWVQREpTMVcrd01S?= =?utf-8?B?NUhacWhvOExDWUhPdUJWYlpOcUtSMVlYOUxhTkdzci9Ua2hMeHl3ZUxmdGdK?= =?utf-8?B?Ny9BUUlNSmVXbVg0L3lQZDg0NUhaMXJrVGliajJaQzBpN3g4OGg1eXZwZ1Jz?= =?utf-8?B?cEIzVmI1THBHQ0xPcWJqcWdUTVI2MlJRNUcvcTF3OXZTelkzZGJvMXRoVHhj?= =?utf-8?B?OVhoaDE1ampLUDNTV0NtZW9Da0RIeUN6UEpuSmdoS3FSMGUyV2NNbjRxOGZl?= =?utf-8?B?WlkzRmREOC85Uk9lVUIzTVc2azlHVUhQM3FuQ1UzS0htNUlaVi90MFBpRWVU?= =?utf-8?B?d2Y0U3JIYVZUMDFpKzNZT3dvbktJWjE2UmtXSmwvUFloY1UyWDcwTytXeWFT?= =?utf-8?B?ZHpRU3dJWkRtMkdzZTVvZ3ZnandRUjE2U21RMnVFUnU5SzRoVkNlNVRwUGxS?= =?utf-8?B?amtMZnc5RWxyMm1vSTd0dmhLbEF2WE9HV0k3STZyVlRHWXdscXA3aXIwQzdk?= =?utf-8?B?WDRaMjZ0OEkzM0FrVjNYbURyNE1IVFBJYURuK0NaaFRHekp2R1RrVDFxY0F4?= =?utf-8?B?QmEwamF0aERYZFo5ZHkzQTI1Ykt5bHBxNUY3K0dpMlJ4THpaSmt3dWp2ZWlM?= =?utf-8?B?Tk5TNEhhZzhwcURmazZXWG15b3lPRm9lblBqbUl5bCs4MkpyUHhWUE9HZVJF?= =?utf-8?B?T1RNNXQxbjVVWjlkTFMrTisvd0ZTZXFyeDVqZG5Fb0hidGlLeGUyWWNzeC8r?= =?utf-8?B?RE90WTZ6clJoUWVCY2IzZGpidWhObHhDdnh4a2pTYTN2dHo5Zm5xWkdNQXNw?= =?utf-8?B?L3U0SGNleEdhcWJSRDl0VFpkd0xPa2tHZVAyRzB2dFNqYVVyTW84Wml5Q21p?= =?utf-8?B?dmRYRTdZZTVlSHFNTk1iU3ZCbHNlbW53ZklTWkxCSVBQZjlXT1l0ZDJOYlRx?= =?utf-8?B?c28yV1FtM04rQTlDa016VCtYd0VZRjkrQnFtTU80eTREeitkMXdvUEEzanFh?= =?utf-8?B?bUFaVzRhdlkwUGRUOXhRb3VSZnhuMVJoZ2VhaHpiSzlKN2xvRnJGWGRLR08x?= =?utf-8?B?S1hFTjZMdUpwUlBBUDlqeEhEKzBONk54UUN6YS95NmFhQXFjUDM0UE8zNUlz?= =?utf-8?Q?E5LMQ7utwz5jalIPgLHY5DLp3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71bc8de7-2f54-4264-c156-08db6d78ae19 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 08:15:28.8768 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WlqT+YjuILh8se+zRt7yT7daUaSALbBddrZw/Si5f9xuG/sC+7zSpEHPHWB8xgp0L+G500heKJxtVNhx73VLWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6913 X-Spam-Status: No, score=-3027.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.06.2023 09:45, Hongtao Liu wrote: > On Thu, Jun 15, 2023 at 3:07 PM Uros Bizjak via Gcc-patches > wrote: >> On Thu, Jun 15, 2023 at 8:03 AM Jan Beulich via Gcc-patches >> wrote: >>> + case 3: >>> + return "%vmovddup\t{%1, %0|%0, %1}"; >>> + case 4: >>> + return "movlhps\t%0, %0"; >>> + default: >>> + gcc_unreachable (); >>> + } >>> +} >>> + [(set_attr "isa" "sse2_noavx,avx,avx512f,sse3,noavx") >>> + (set_attr "type" "sselog1,sselog1,ssemov,sselog1,ssemov") >>> + (set_attr "prefix" "orig,maybe_evex,evex,maybe_vex,orig") >>> + (set_attr "mode" "TI,TI,TI,DF,V4SF") > alternative 2 should be XImode when !TARGET_AVX512VL. This gives me a chance to actually raise a related question I stumbled across several times: Which operand does the mode attribute actually describe? I've seen places where it's the source, but I've also seen places where it's the destination. Because of this mix I wasn't really sure that getting this attribute entirely correct is actually necessary, and hence I hoped it would be okay to not further complicate the attribute here. Jan