From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 67C8C3858432 for ; Mon, 13 May 2024 23:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67C8C3858432 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 67C8C3858432 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715643417; cv=none; b=EpLFuxK4K9jvFZpIBhwJwLcAcDrh36hdwc7ZA0IU36BnUwAejPcTzTcU+CKDkh1xOuuXn+bU8KB2aSxI+ZurrZAYiGomgtr+fXMr4+O4C8F7XnnPtkn5Dg3fthuE67EDXq87t7ID8qcimUQ6ZTXwgpuaaGxM6On709wQIHWjemU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715643417; c=relaxed/simple; bh=GuoT/zOwZULnYLPRQpjt+iqXIqygqt0s+zIdpJ2cpKs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=PORkmNR0cHytVAvDzMOxlf2Qct6Y+FxPsCw4aZiQPX1Kw4JxxVVl22Ay873e1UOiMdmnqFn8aVcp/ekHpfZFMc0guT1ua/ms7GvIfZuYInuQSkHfoZ8MBxuhvdcsn6GwJJtpr1sZPrP1fKct8zgzZ7K4I/59HTiQcchaqtZGWlw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6f4f2b1c997so2037042b3a.0 for ; Mon, 13 May 2024 16:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715643414; x=1716248214; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j4LpELA3IrBlDDLAyrC7QRdXOn80O8FnSIzbG/SD91M=; b=l7wU80v7DiSjnWW0urvn9+vXcTEKr1n5HQAWCNjIO7kDzMH4CAFJQYkEy3RvBWexYu 2Es8El29gfVXEcJEQWmyMEiFJNF8pFfxkGns8Rz9MvmKbV5gH6RbBmWT2NSDHWn06c6H goGiMEOm1cEwiSAl28cUoUhx+gO9/6yviDwolkyYVoR68ig4JGOXIOF1nJc8+b+bJoA8 9Mv1AL9Eu8bzcWC7RqxJi/VUDK70OKInWYa/tqqe+g8XEIKQl5gyIXjVP6PzibM1oN7t 8svsbONzzJghukNWlswqr0ch0ViBFcwjDoE2ZbbCkwaM/OTtJ4QU9fn3+fTClPJfoUpL faEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715643414; x=1716248214; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j4LpELA3IrBlDDLAyrC7QRdXOn80O8FnSIzbG/SD91M=; b=sBBeiCmYeUIWhcMR/f/OUAj8oqP6NbIbapKbYj3JYjvenUQpXBNRvTeJYDsdv/N9EY gXlAUOT7iFVAcp1ULdoa2P4bSfON9lfvoz0j8ZBwBGfd7pVRZUBeeHaYmiLY/xQQSthK wYur1ffpeGrgQLfaAasiKait/ceqOf8m9iej5dZnu+bDw8er63aipuQHfG/rk7Q3J/Jw e7fd8ZYijuVRaUGdFyF9UCS0mALieONoIPdY6wvuygi/JS/wOE3SXb27CNlQRYcV7Zua jvIM2O69rn7z9KLznHcylkA+AVNgnmrbdo0Wb0V0YzKEPETSJwImTXFrsXzgMnhyre4b BmOg== X-Forwarded-Encrypted: i=1; AJvYcCVt4rTkoQPU0Q6JGKC3KN3MrfSdO9XPQaoBj+LFylVykQUdkXsE7GdnRqtNxLzgWSVlZAYemTDlCOUH+lXzYMamfzcCDuWaSg== X-Gm-Message-State: AOJu0YxVdwn5+SbC3BcYrMyK/WkvSkPDY2KZf3eQzw+HSV38eO/1BUxh LkN5MVoHxo9fmyKQr5IrfMIcRLgraAMJmtwyUFsmADxV3VFwXZqVKEsHfkVf X-Google-Smtp-Source: AGHT+IFFwuLsT8kdRj6MB/Z43bYiUIKhkIkccjygvBXMlJ6OGHdZwOuk8/S+c/jrUR5z+jF16cCObQ== X-Received: by 2002:a05:6a20:9150:b0:1af:ad46:cd4d with SMTP id adf61e73a8af0-1afde10f38fmr11514650637.32.1715643414156; Mon, 13 May 2024 16:36:54 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d1e59sm84631325ad.13.2024.05.13.16.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 16:36:53 -0700 (PDT) Message-ID: <6157777f-1584-47da-93c6-66ccaf135a3e@gmail.com> Date: Mon, 13 May 2024 17:36:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2 1/3] RISC-V: movmem for RISCV with V extension Content-Language: en-US From: Jeff Law To: Sergei Lewis , gcc-patches@gcc.gnu.org References: <20231219095348.356551-1-slewis@rivosinc.com> <20231219095348.356551-2-slewis@rivosinc.com> <5098d3c3-845f-4b71-ba8f-751b03b73240@gmail.com> In-Reply-To: <5098d3c3-845f-4b71-ba8f-751b03b73240@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/19/23 10:28 PM, Jeff Law wrote: > > > On 12/19/23 02:53, Sergei Lewis wrote: >> gcc/ChangeLog >> >>      * config/riscv/riscv.md (movmem): Use >> riscv_vector::expand_block_move, >>      if and only if we know the entire operation can be performed >> using one vector >>      load followed by one vector store >> >> gcc/testsuite/ChangeLog >> >>      PR target/112109 >>      * gcc.target/riscv/rvv/base/movmem-1.c: New test > So this needs to be regression tested.  Given that it only affects RVV, > I would suggest testing rv64gcv or rv32gcv. > > > >> +(define_expand "movmem" >> +  [(parallel [(set (match_operand:BLK 0 "general_operand") >> +   (match_operand:BLK 1 "general_operand")) >> +    (use (match_operand:P 2 "const_int_operand")) >> +    (use (match_operand:SI 3 "const_int_operand"))])] >> +  "TARGET_VECTOR" >> +{ >> +  if ((INTVAL (operands[2]) >= TARGET_MIN_VLEN/8) >> +    && (INTVAL (operands[2]) <= TARGET_MIN_VLEN) >> +    && riscv_vector::expand_block_move (operands[0], operands[1], >> +         operands[2])) >> +    DONE; >> +  else >> +    FAIL; >> +}) > Just a formatting nit.  A space on each side of the '/' operator above. So I've fixed the formatting nit and tested on rv64gc and rv32gcv. I hadn't planned to push it, but muscle memory kicked in and 1/3 has been pushed. I'll be looking at 2/3 and 3/3 tomorrow (or possibly a bit tonight to take advantage of overnight CI runs). jeff