From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>, Martin Jambor <mjambor@suse.cz>
Subject: Re: [PATCH][RFC] Make expansion of balanced binary trees of switches on tree level.
Date: Fri, 18 Aug 2017 11:05:00 -0000 [thread overview]
Message-ID: <615dfc0a-aded-22e5-333e-f613eb577c7c@suse.cz> (raw)
In-Reply-To: <CAFiYyc0Q9g5w4NgtXENWpZ1pEzoK+WUR24VYcX8Cf1xsuTyx+g@mail.gmail.com>
On 08/18/2017 11:30 AM, Richard Biener wrote:
> On Tue, Aug 15, 2017 at 2:37 PM, Martin Liška <mliska@suse.cz> wrote:
>> On 08/14/2017 10:32 AM, Richard Biener wrote:
>>> Hmm, but the existing "lowering" part is called from the
>>> switch-conversion pass. So
>>> I'm not sure a new file is good.
>>
>> Good, I'm not against having that in a single file. So new version of the patch
>> does that.
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
>
> Hmm, I see you duplicate add_case_node for example. Is that just temporary?
> If not can you please factor out the data structure and common code?
> (case.[Ch]?)
You are right. As we'll generate just jump table in stmt.c the proper fix is to remove
all usages of 'case_node' in the file because simple iteration of labels will work fine.
Let me do it incrementally to minimize fall out :)
Martin
>
> Thanks,
> Richard.
>
>> Martin
next prev parent reply other threads:[~2017-08-18 10:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 11:20 Martin Liška
2017-08-02 11:51 ` Richard Biener
2017-08-02 12:49 ` Martin Liška
2017-08-03 9:02 ` Jan Hubicka
2017-08-03 16:11 ` Jeff Law
2017-08-03 12:22 ` Steven Bosscher
2017-08-10 8:54 ` Martin Liška
2017-08-14 9:26 ` Richard Biener
2017-08-15 12:50 ` Martin Liška
2017-08-18 10:29 ` Richard Biener
2017-08-18 11:05 ` Martin Liška [this message]
2017-08-24 17:21 ` Martin Liška
2017-08-29 12:58 ` Richard Biener
2017-08-29 15:11 ` Martin Liška
2017-08-30 9:18 ` Rainer Orth
2017-08-30 12:29 ` Martin Liška
2018-03-25 10:12 ` [testsuite, committed] Make scan pattern more precise in vrp104.c Tom de Vries
2017-08-02 13:38 ` [PATCH][RFC] Make expansion of balanced binary trees of switches on tree level David Malcolm
2017-08-03 12:52 ` Steven Bosscher
2017-08-03 12:56 ` Richard Biener
2017-08-03 13:20 ` Jan Hubicka
2017-08-03 13:28 ` Steven Bosscher
2017-08-04 11:19 ` Martin Liška
2017-08-04 11:19 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=615dfc0a-aded-22e5-333e-f613eb577c7c@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mjambor@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).