From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id E38DC3858400 for ; Wed, 10 Nov 2021 18:37:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E38DC3858400 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 6Ix0uMsNpVxy9iWGkEtAu1FY5dp27aK4ieVPqkHFgexKFPynqj7Rh+bnpQXQW4AFez46ueKqSG oFkCm7FKm6U36UD1WuNizcgTWajJeqJ9HN9DTgR3LlpjVe2LBdAx1k3e84pdyaqFXs7pyt82lj bCKVM/x5GkkWn0G3HAmabQHR95/V34/YsfrNN5cMTkECAqzfKwM37GanAgf4ii2oO5+F8eOGJU /Yy5/EvdBOvB60EhoU7SfpJsTRD+DR9HwWth8z5I6ThUYvvnuGN9pAX5bKGSQt4BLl7OjAPdlY oLH1ME7SzMFRMh6WvimEthbp X-IronPort-AV: E=Sophos;i="5.87,224,1631606400"; d="scan'208";a="68326572" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 10 Nov 2021 10:37:58 -0800 IronPort-SDR: 6OxqLhWuVZWGBsTw3NH9yaR1KGrJprgs9CkxhANF/zEhx/u5xdneCgc/6Be4tVaTJ0MPy5RZ0I lb4QBlvHsLmLWBGQQPbhBSFbuxHLxouIctW//n+WXKHFlcoHcUhGxcOhwPHPa5SM7n0G8L7Lpv v2weAeIGpv9AZavajOLf/br0+beVzr4L0pJuPzjkj4wccvtt1w7cBbQXDQ23zZ2CFlVWXxN/zF wVvVVleq+HyCiIdBKkPmTxGbwivzRJG3uL4ujXgEd9lxKsVRwr7Dyzitwjp8m3KLN9MS7hKs2c RzE= Subject: Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks. To: Tamar Christina , CC: , Newsgroups: gmane.comp.gcc.patches References: From: Sandra Loosemore Message-ID: <617e70fb-7250-d599-bf38-41899ed99e5c@codesourcery.com> Date: Wed, 10 Nov 2021 11:37:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 18:38:02 -0000 On 11/10/21 4:54 AM, Tamar Christina via Gcc-patches wrote: > Hi All, > > These test don't work on vector ISAs where the truth > type don't match the vector mode of the operation. > > However I still want the tests to run on these > architectures but just turn off the ISA modes that > enable masks. > > This thus turns off SVE is it's on and turns off > AVX512 if it's on. > > Regtested on aarch64-none-linux-gnu with SVE on, > and x86_64-pc-linux-gnu with AVX512 on and no > issues. > > Committed under the obvious rule. > > Thanks, > Tamar > > gcc/testsuite/ChangeLog: > > * gcc.dg/signbit-2.c: Turn of masks. > * gcc.dg/signbit-5.c: Likewise. I'm seeing this failure on nios2-elf: FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized "\\s+>\\s+{ 0, 0, 0, 0 }" 1 I don't understand what it is expecting to happen here. Should it be skipped on this target, or restricted to ARM and x86? Adding some comments to the testcase to explain the significance of that pattern might be useful too. -Sandra