From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-333421-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4124 invoked by alias); 3 Dec 2012 19:50:05 -0000
Received: (qmail 4111 invoked by uid 22791); 3 Dec 2012 19:50:04 -0000
X-SWARE-Spam-Status: No, hits=-3.5 required=5.0	tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,TW_LV
X-Spam-Check-By: sourceware.org
Received: from qmta10.emeryville.ca.mail.comcast.net (HELO qmta10.emeryville.ca.mail.comcast.net) (76.96.30.17)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 19:49:52 +0000
Received: from omta17.emeryville.ca.mail.comcast.net ([76.96.30.73])	by qmta10.emeryville.ca.mail.comcast.net with comcast	id X7d71k0031afHeLAA7psCo; Mon, 03 Dec 2012 19:49:52 +0000
Received: from bag6-1-pt.tunnel.tserv3.fmt2.ipv6.he.net ([IPv6:2001:470:1f04:ae1::2])	by omta17.emeryville.ca.mail.comcast.net with comcast	id X7pr1k00d0P3DwE8d7psjq; Mon, 03 Dec 2012 19:49:52 +0000
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: [PATCH] asan unit tests from llvm lit-test
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <20121203193645.GD2315@tucnak.redhat.com>
Date: Mon, 03 Dec 2012 19:50:00 -0000
Cc: Wei Mi <wmi@google.com>, GCC Patches <gcc-patches@gcc.gnu.org>, David Li <davidxl@google.com>, Diego Novillo <dnovillo@google.com>, Kostya Serebryany <kcc@google.com>, Dodji Seketeli <dseketel@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <61CA111A-9834-4A7D-AD93-8221AB01F34B@comcast.net>
References: <CA+4CFy5jX04sXyvVNWx=jwch5PP6JE0amCK3XGntqKKNjr7SEQ@mail.gmail.com> <20121128101420.GG2315@tucnak.redhat.com> <CA+4CFy5nPQvs+Akq1J2-6exacAS8WMUyNxXsCog8Wc7UxuSo7g@mail.gmail.com> <20121203110018.GR2315@tucnak.redhat.com> <6A035ADC-7D20-4017-9DBF-7943C68F2E1C@comcast.net> <20121203193645.GD2315@tucnak.redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-12/txt/msg00163.txt.bz2

On Dec 3, 2012, at 11:36 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> The env vars are used by the target libs when running the test executable.
> So, are you suggesting we name it dg-set-target-env-var instead of
> dg-set-env-var, so that in the future we can also have
> dg-set-{host,build}-env-var?

Yes.  The set-build-env I think is non-sensical.  The set-host-env version,=
 I think makes since for hosted reasons, even if we don't implement it toda=
y (no need, yet).

> Or if [is_remote target] ?

Yeah.

> if [is_remote target]
>  return [list "unsupported" ""]

Looks nice.