From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: gcc-patches@gcc.gnu.org, nickc@redhat.com,
ramana.radhakrishnan@arm.com, kyrylo.tkachov@arm.com,
richard.sandiford@arm.com
Subject: Re: [arm] Fix insn type of *thumb1_tablejump
Date: Tue, 17 Sep 2019 15:00:00 -0000 [thread overview]
Message-ID: <61c1e8b3-c0b1-e468-865d-30f1e3e30a4f@arm.com> (raw)
In-Reply-To: <mpt5zlr3req.fsf@arm.com>
On 17/09/2019 15:53, Richard Sandiford wrote:
> *thumb1_tablejump had type "no_insn", which doesn't seems to correspond
> to its documented use:
>
> an insn which does not represent an instruction in the final output,
> thus having no impact on scheduling.
>
> Indirect jumps use the same instruction and have type "branch",
> so the patch uses "branch" here too.
>
> Tested on armeb-none-eabi. OK to install?
>
> Richard
>
>
> 2019-09-17 Richard Sandiford <richard.sandiford@arm.com>
>
> gcc/
> * config/arm/thumb1.md (*thumb1_tablejump): Change type from
> "no_insn" to "branch".
>
> Index: gcc/config/arm/thumb1.md
> ===================================================================
> --- gcc/config/arm/thumb1.md 2019-07-01 09:37:07.224524452 +0100
> +++ gcc/config/arm/thumb1.md 2019-09-17 15:52:16.454952314 +0100
> @@ -1944,7 +1944,7 @@ (define_insn "*thumb1_tablejump"
> "TARGET_THUMB1"
> "mov\\t%|pc, %0"
> [(set_attr "length" "2")
> - (set_attr "type" "no_insn")]
> + (set_attr "type" "branch")]
> )
>
> (define_insn_and_split "thumb_eh_return"
>
Ok.
It probably makes no real difference to scheduling though as branch
instructions end a basic block.
R.
prev parent reply other threads:[~2019-09-17 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 14:53 Richard Sandiford
2019-09-17 15:00 ` Richard Earnshaw (lists) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c1e8b3-c0b1-e468-865d-30f1e3e30a4f@arm.com \
--to=richard.earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=nickc@redhat.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).