public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: VRP: make range_includes_zero_p handle value_ranges
Date: Fri, 24 Aug 2018 18:38:00 -0000	[thread overview]
Message-ID: <61d7995c-ff95-0a0b-1ec4-5dd3485f7636@redhat.com> (raw)
In-Reply-To: <CAFiYyc2tqy0-1+EW_XbB2gtehLNhXPvhspWJN3G6SL4mYpjrXw@mail.gmail.com>



On 08/24/2018 05:08 AM, Richard Biener wrote:

> @@ -1407,7 +1407,10 @@ extract_range_from_binary_expr_1 (value_range *vr,
>         && code != POINTER_PLUS_EXPR
>         && (vr0.type == VR_VARYING
>            || vr1.type == VR_VARYING
> -         || vr0.type != vr1.type
> +         || (vr0.type != vr1.type
> +             /* We can handle POINTER_PLUS_EXPR(~[0,0], [x,y]) below,
> +                even though we have differing range kinds.  */
> +             && code != POINTER_PLUS_EXPR)
>            || symbolic_range_p (&vr0)
>            || symbolic_range_p (&vr1)))
>       {
> 
> is redundant now (spot the code != POINTER_PLUS_EXPR check at the
> beginning of context)

Hey, no fair making my code irrelevant mid way through a review! :)

> 
> OK with this hunk removed.

Done.

Thanks.
Aldy

      reply	other threads:[~2018-08-24 18:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15  1:33 VRP: rewrite the division code (to handle corner cases including 0) Aldy Hernandez
2018-08-21  9:46 ` Richard Biener
2018-08-21 14:17   ` Jeff Law
2018-08-21 17:35   ` Aldy Hernandez
2018-08-23 12:51     ` Richard Biener
2018-08-23 13:18       ` Aldy Hernandez
2018-10-17 11:16       ` Aldy Hernandez
2018-10-17 12:30         ` Richard Biener
2018-08-22  9:32   ` VRP: make range_includes_zero_p handle value_ranges Aldy Hernandez
2018-08-23  9:59     ` Richard Biener
2018-08-23 14:50       ` Aldy Hernandez
2018-08-24  9:08         ` Richard Biener
2018-08-24 18:38           ` Aldy Hernandez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61d7995c-ff95-0a0b-1ec4-5dd3485f7636@redhat.com \
    --to=aldyh@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).