From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106505 invoked by alias); 24 Apr 2019 09:22:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106236 invoked by uid 89); 24 Apr 2019 09:22:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2528 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Apr 2019 09:22:33 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3O9MNDa022154 for ; Wed, 24 Apr 2019 05:22:31 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2s2msj9ddh-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 24 Apr 2019 05:22:29 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Apr 2019 10:20:19 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 24 Apr 2019 10:20:17 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3O9KHNS51249278 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 09:20:17 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC50A4204D; Wed, 24 Apr 2019 09:20:16 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E186F42049; Wed, 24 Apr 2019 09:20:15 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.147.132]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 24 Apr 2019 09:20:15 +0000 (GMT) Subject: Re: [PATCH, RFC, rs6000] PR80791 Consider doloop in ivopts To: Jakub Jelinek References: <20190424084858.GZ21066@tucnak> Cc: GCC Patches From: "Kewen.Lin" Date: Wed, 24 Apr 2019 09:25:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190424084858.GZ21066@tucnak> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit x-cbid: 19042409-0016-0000-0000-00000272DBBA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19042409-0017-0000-0000-000032CF4C17 Message-Id: <62208d74-e52b-18b8-8271-48e2df218f85@linux.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00917.txt.bz2 Thanks for catching, Jakub! The update listed below, will integrate it with next revision patch. gcc/ChangeLog 2019-04-24 Kewen Lin PR middle-end/80791 * target.def (predict_doloop_p): New hook. * targhooks.h (default_predict_doloop_p): New declaration. * targhooks.c (default_predict_doloop_p): New function. * doc/tm.texi.in (TARGET_PREDICT_DOLOOP_P): New hook. * doc/tm.texi: Regenerate. * config/rs6000/rs6000.c (invalid_insn_for_doloop_p): New function. (costly_iter_for_doloop_p): Likewise. (rs6000_predict_doloop_p): Likewise. (TARGET_PREDICT_DOLOOP_P): New macro. * expr.c (produce_memory_decl_rtl): New function. (prepare_decl_rtl): Likewise. * expr.h (produce_memory_decl_rtl): New declaration. (prepare_decl_rtl): Likewise. * tree-ssa-loop-ivopts.c (tree_ssa_iv_optimize_loop): Call predict_doloop_p hook. (tailor_cmp_uses): New function. (preserve_ivs_for_use): New function. (computation_cost): Call refactored prepare_decl_rtl, consider zero cost iv use. (dump_use): Dump zero_cost_p field. (record_use): Init zero_cost_p field. (produce_memory_decl_rtl): Remove. (prepare_decl_rtl): Remove. gcc/testsuite/ChangeLog 2019-04-24 Kewen Lin PR middle-end/80791 * gcc.dg/tree-ssa/ivopts-lt.c : Adjust. on 2019/4/24 ÏÂÎç4:48, Jakub Jelinek wrote: > On Wed, Apr 24, 2019 at 04:41:01PM +0800, Kewen.Lin wrote: >> gcc/ChangeLog > > Not a review, just ChangeLog nits. > >> 2019-04-24 Kewen Lin >> >> PR middle-end/80791 >> * target.def (predict_doloop_p): New. >> * targhooks.h (default_predict_doloop_p): New. >> * targhooks.c (default_predict_doloop_p): Likewise. >> * doc/tm.texi.in (TARGET_PREDICT_DOLOOP_P): New. >> * doc/tm.texi: Regenerate. >> * config/rs6000/rs6000.c (invalid_insn_for_doloop_p): New. >> (costly_iter_for_doloop_p): New. >> (rs6000_predict_doloop_p): New. > > There should be no leading spaces after the tab on the lines that don't contain > a filename, so: > * config/rs6000/rs6000.c (invalid_insn_for_doloop_p): New. > (costly_iter_for_doloop_p): New. > (rs6000_predict_doloop_p): New. > instead (and instead of saying just New. usually we write what kind of > new thing it is, so New function., New declaration. (or Declare.), New > macro. (or Define.), New method. etc. > >> * gcc/expr.c (produce_memory_decl_rtl): New. > > The gcc/ prefixes don't belong into gcc/ChangeLog, the filenames are always > relative to the ChangeLog file referencing those. > > Jakub >